bug: pass bool (not int) to api_plugin_register_hook() enable argument (#271)

Cacti 1.3 types api_plugin_register_hook() 5th arg as bool enable. These calls passed int 1, which only coerces while the file lacks declare(strict_types=1); pass true so they stay type-correct. php -l clean.
This commit is contained in:
TheWitness authored and GitHub committed 2026-10-08 15:00:36 -04:00
1 parent 0409ecb532
commit 353766eba5
2 files changed
+2 -1

No files matched your search

+1
View File
@@ -2,6 +2,7 @@
--- 3.0 ---
* bug: Pass a boolean (not the integer 1) to api_plugin_register_hook()'s $enable argument so the hook registration stays type-correct under Cacti 1.3's strict bool type-hint (the int only coerces while the file lacks declare(strict_types=1))
* feature: Adopt the Cacti plugin table API and relocate schema provisioning into includes/database.php
* feature: Add a fleet-wide manifest.json with upgrade-time file pruning
* feature: Consolidate per-theme override stylesheets from themes/ into css/
+1 -1
View File
@@ -334,7 +334,7 @@ function monitor_check_upgrade() {
monitor_setup_table();
monitor_upgrade_tables();
api_plugin_register_hook('monitor', 'page_head', 'plugin_monitor_page_head', 'setup.php', 1);
api_plugin_register_hook('monitor', 'page_head', 'plugin_monitor_page_head', 'setup.php', true);
db_execute('ALTER TABLE host MODIFY COLUMN monitor char(3) DEFAULT "on"');