mirror of
https://github.com/Cacti/plugin_monitor.git
synced 2026-10-24 03:56:53 +09:00
TheWitness
0409ecb532
* Fix select2 change recursion from double-wired Criticality device filter Gate the client-side Criticality filter injection on whether core already rendered the field (device_filters/CactiTableFilter) instead of a CACTI_VERSION string. When core renders it natively the handler now bails, avoiding the second widget/handler that drove the select2 change -> selection:update recursion. Legacy releases still inject once, matching core's widget engine and binding a single namespaced change handler. * test: cover monitor_device_table_bottom() filter injection Exercise the device_table_bottom hook that injects the legacy Criticality filter, locking in the select2 change-recursion fix: the bail guard when core already rendered the field, a single namespaced change.monitor handler, a single widget engine (never both), theme gating, and the selected-option build. Covers the previously untested changed lines (setup.php patch-coverage gate).
84 lines
2.7 KiB
PHP
84 lines
2.7 KiB
PHP
<?php
|
|
/*
|
|
+-------------------------------------------------------------------------+
|
|
| Copyright (C) 2004-2026 The Cacti Group |
|
|
+-------------------------------------------------------------------------+
|
|
*/
|
|
|
|
/*
|
|
* Regression coverage for monitor_device_table_bottom(), the device-list
|
|
* 'device_table_bottom' hook that injects the Criticality filter on legacy
|
|
* Cacti releases. These lock in the select2 change-recursion fix: a bail
|
|
* guard when core already rendered the field, a single namespaced change
|
|
* handler, and a single widget engine (never both at once).
|
|
*/
|
|
|
|
beforeAll(function () {
|
|
require_once __DIR__ . '/../../setup.php';
|
|
|
|
// The function gates on CACTI_VERSION; the unit bootstrap does not load
|
|
// Cacti's globals, so pin a legacy value that takes the injection path
|
|
// where the fix lives.
|
|
if (!defined('CACTI_VERSION')) {
|
|
define('CACTI_VERSION', '1.2.29');
|
|
}
|
|
});
|
|
|
|
function monitor_render_device_table_bottom(): string {
|
|
ob_start();
|
|
monitor_device_table_bottom();
|
|
|
|
return (string) ob_get_clean();
|
|
}
|
|
|
|
it('bails without re-injecting when core already rendered the criticality field', function () {
|
|
$GLOBALS['__test_selected_theme'] = 'modern';
|
|
|
|
$html = monitor_render_device_table_bottom();
|
|
|
|
expect($html)->toContain("if ($('#criticality').length)");
|
|
expect($html)->toContain('return;');
|
|
});
|
|
|
|
it('injects the criticality select with the requested value marked selected', function () {
|
|
$GLOBALS['__test_selected_theme'] = 'modern';
|
|
$GLOBALS['__test_request']['criticality'] = '2';
|
|
|
|
$html = monitor_render_device_table_bottom();
|
|
|
|
expect($html)->toContain('<select id="criticality">');
|
|
expect($html)->toContain('<option selected value="2">');
|
|
expect($html)->toContain('<option value="1">');
|
|
});
|
|
|
|
it('wires exactly one namespaced change handler and defines applyFilter', function () {
|
|
$GLOBALS['__test_selected_theme'] = 'modern';
|
|
|
|
$html = monitor_render_device_table_bottom();
|
|
|
|
expect(substr_count($html, "on('change.monitor'"))->toBe(1);
|
|
expect($html)->toContain("off('change.monitor')");
|
|
expect($html)->toContain('window.applyFilter = function()');
|
|
});
|
|
|
|
it('widgetizes with a single engine, never both, on non-classic themes', function () {
|
|
$GLOBALS['__test_selected_theme'] = 'modern';
|
|
|
|
$html = monitor_render_device_table_bottom();
|
|
|
|
expect($html)->toContain('if ($.fn.select2 != null)');
|
|
expect($html)->toContain('} else if ($.fn.selectmenu != null)');
|
|
});
|
|
|
|
it('omits the widget block on the classic theme', function () {
|
|
$GLOBALS['__test_selected_theme'] = 'classic';
|
|
|
|
$html = monitor_render_device_table_bottom();
|
|
|
|
expect($html)->not->toContain('.select2()');
|
|
expect($html)->not->toContain('.selectmenu()');
|
|
expect($html)->toContain('<select id="criticality">');
|
|
|
|
unset($GLOBALS['__test_selected_theme']);
|
|
});
|