* This is not all the feature, just saving the work.
* It's going to take a few commits to completely implement this feature
* This version adds a new column to notifification_queue
* It adds a % at Site in addition to raw number of devices in a site
* It starts the logic of expiration of notification delays
* ToDo: Custom Email and Command notification based upon restoration or expiration
* ToDo: Adding new Notification delays to the list of existing notifications.
* feature: Mass Enable/Disable at Template Level
* feature: Make Enabling and Disabling a Thold Different than Enabling or Disabling a Template
* QA: Cleanup some of the state calculation logic to make similar between pages.
* issue#406: THOLD 1.3.4 no 1 minute cycle/Trigger option
* issue#407: Error php deprecated when delete any graph
* issue#409: Cannot send mail due to default From mail is invalid
* issue#410: php error when creating threshold - Undefined index: data_type
* issue#411: The newly added device In Stat value incorrect
* issue: When Data Manipulation type is Percentage, RPN Expression column is shown
For those of you watching, you may have thought I was never going to commit again. Well, you were wrong 👍 I'm alive and still working on Cacti and a number of plugins. Just not in a very public way. You may be aware of my other work, and if so, that's great!
My current employer is allowing me to port a number of thold changes back to the Cacti community from our forked version.
It was a necessity since the Cacti core version of the plugin has advanced so much since our forked version was first created.
Of the commits that will be forthcoming, this is the first. In this first commit, I'm adding the following:
* Adding some additional hooks to the Notification List functionality for one of my non-public plubins.
* Adding Acknowledgment functionality to thold
* Allowing optional per threshold and per template specific email body support for both warnings and alerts
* Allow optional command line execution as the result of a threshold alert breach or restoral event.
* Allow threshold actions to be hooked by other plugins. These hooks will be used by some of my non-public plugins for performing specific thold actions
* Add hooks for threshold and and template editing and saving
* Some faily significant code cleanup and code reduction
* In addition, I've found a number of smaller bugs that I will remediate via the GitHub issues list.
There are additional changes that I will be making subsequent to this commit, that include:
* Using a Threshold template to drive the creation of Graphs. It's kind of backwards, but it works pretty well.
* Possible additional changes to the various hooks as I modify my gridalarms plugin to work with this version of thold.
* Any bug fixes that I discover from this major change.
Note, that you must be using Cacti 1.2 in order to leverage this new version of thold. You are free to test it prior to it's release formal release of course. I'm pretty sure all the core functionality is there as of right now. However be warned, that I may for example pull or add a column or two, but you can rest assured that forcing another upgrade should fix things automatically.
Finally, let's not all get too excited. I'm doing this work for my employer who has been kind enough to allow this work to happen. None-the-less, I'm glad to be back, if only for a short time.
TW
After this change, you will have to run the following SQL command, and
then goto the Threshold console pick to completely resolve.
UPDATE plugin_config SET version='1.0 WHERE directory='thold';
Thanks for reporting.
this revision of thold will require a re-install, or you may manually
register new hooks and create the new 1.0 table. the new features
include specifying thold templates at the device template level, and
adding an option to autocreate tholds when saving a device.
TheWitness