Files
Cactiplugin_thold/tests/Unit/ThresholdBaselineCharacterizationTest.php
TheWitnessandCopilot 9b217e0e3a INFO: set compat to 1.2.29 (#838)
* INFO: set compat to 1.2.32

* docs: update Copilot instructions Cacti baseline to 1.2.32 (matches INFO compat)

* INFO: back off compat to 1.2.29

* Add manifest.json + upgrade-time file pruning

* Prune phpunit.xml on upgrade and ignore markdown-lint configs

phpunit.xml ships in the repo for CI but is a dev-only test artifact, so it
is removed from manifest.json 'expected', pruned from installs on upgrade
(like tests/), and excluded from the manifest drift check.

The retired markdown-lint configs (.mdlrc, .md_style.rb) are deleted, and
.md* is now ignored like .git*: protected from pruning and excluded from
drift if it reappears.

* Move thold_functions.php and thold_webapi.php into includes/; flatten css

The main threshold library becomes includes/functions.php and the web API
helper becomes includes/webapi.php; every caller (setup.php, includes/*, the
CLI/poller/notify entry points and the test suite) loads them from includes/.
Each per-theme stylesheet css/<theme>/main.css becomes css/<theme>.css so users
can drop their own css/<theme>.css into the css base, and the page_head hook
looks there. Old paths are tombstoned so existing installs drop the stale
copies on upgrade.

* Regenerate cacti.pot for the includes/ file relocations

Moving the plugin's library files into includes/ changed the source-reference
lines in the translation template; regenerate it so the 'Verify translation
template' CI check passes.

* Harden the hook-include test and make RPN integer ops explicit

The HookFunctionsIncludeTest invokes real hooks with placeholder input purely
to execute their relocated include_once lines; it now swallows engine
notices/warnings/deprecations during those calls (and restores the error
handler and config afterward) so it cannot trip the suite's failOnDeprecation
or leak state into other tests. The RPN % and ^ operators now cast their
operands to int explicitly, matching their long-standing integer-truncation
behaviour while silencing the implicit float-to-int conversion deprecation.

* Harden prune against tampered-manifest path traversal

The upgrade-time prune now rejects any tombstone containing '.'/'..' segments
(which could escape the plugin directory or resolve to its root) and treats
ancestors of whitelist entries as protected, so a tombstone on a parent
directory can no longer delete a whitelisted file beneath it.

* docs: update and align the Project Structure block

Point the structure tree at the relocated files (libraries now under
includes/, data files under docs/, stylesheets under css/) and align the
trailing '# ...' comments to a single column so they no longer drift right.

* docs/tests: standardize test header and correct manifest-contract notes

- Use the full license header (from the plugin's own setup.php) in
  tests/Unit/PruneFilesTest.php instead of the abbreviated copyright banner.
- Document that the manifest drift check and the upgrade-time prune also
  handle phpunit.xml and .md* files, matching the implemented behavior.

* refactor: rename prune helpers to the plugin-slug function prefix

The repository naming contract reserves the plugin_<name>_ prefix for plugin
lifecycle / hook-registration functions; all other functions use the plain
<name>_ prefix. Rename the internal upgrade helpers accordingly:

  plugin_<name>_prune_files() -> <name>_prune_files()
  plugin_<name>_rmtree()      -> <name>_rmtree()

The call site, unit tests, and the copilot-instructions.md references are
updated to match. No behavioral change.

* chore: set the Cacti compatibility floor to 1.2.29

Align the compat metadata (and the contributor-guide references) with the
team decision to standardize the minimum supported Cacti version at 1.2.29;
the previously proposed 1.2.32 floor was not adopted.

---------

Co-authored-by: Copilot <copilot@users.noreply.github.com>
2026-10-01 01:40:00 -05:00

187 lines
5.4 KiB
PHP

<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
/**
* What a baseline threshold does over one poll.
*
* This arm compares the reading against statistics rrdtool reports for a
* reference window, so the scenario supplies those statistics rather than the
* bounds the other two arms use. A reference average of 100 with a ten percent
* band puts the normal range at 90 to 110.
*/
final class ThresholdBaselineCharacterizationTest extends TestCase {
/**
* @return void
*/
public static function setUpBeforeClass(): void {
self::loadPluginSource('includes/functions.php');
self::loadPluginSourceAlways('includes/arrays.php');
self::loadPluginConstants();
}
/**
* @param array<string, mixed> $overrides
*
* @return ThresholdScenario
*/
private function baseline(array $overrides = []) {
return ThresholdScenario::threshold($overrides + [
'thold_type' => 1,
'bl_type' => 0,
'bl_pct_up' => 10,
'bl_pct_down' => 10,
'bl_ref_time_range' => 3600,
'bl_fail_trigger' => 1,
])
->alertRecipient('ops@example.org')
->referenceStatistics(100, 100, 100, 100);
}
/**
* @return void
*/
public function testReadingInsideTheBandEmitsNothing(): void {
$outcome = $this->baseline(['lastread' => 100])->poll();
$this->assertTrue($outcome->isSilent());
$this->assertSame(0, $outcome->thold['bl_alert']);
}
/**
* @return void
*/
public function testReadingAboveTheBandAlerts(): void {
$outcome = $this->baseline(['lastread' => 500])->poll();
$this->assertSame(STAT_HI, $outcome->thold['bl_alert']);
$this->assertSame([ST_NOTIFYAL], $outcome->logStatuses());
$this->assertSame(1, $outcome->mailCount());
}
/**
* @return void
*/
public function testReadingBelowTheBandAlerts(): void {
$outcome = $this->baseline(['lastread' => 1])->poll();
$this->assertSame(STAT_LO, $outcome->thold['bl_alert']);
$this->assertSame([ST_NOTIFYAL], $outcome->logStatuses());
$this->assertSame(1, $outcome->mailCount());
}
/**
* @return void
*/
public function testReturningToTheBandNotifiesTheRestoral(): void {
$outcome = $this->baseline([
'lastread' => 100,
'bl_alert' => STAT_HI,
'bl_fail_count' => 3,
])->poll();
$this->assertSame(0, $outcome->thold['bl_alert']);
$this->assertSame([ST_RESTORAL], $outcome->logStatuses());
$this->assertSame(1, $outcome->mailCount());
}
/**
* When rrdtool returns no reference statistics the arm cannot decide
* anything, so it reports -1 and leaves the threshold alone. This is the
* state a newly created baseline threshold sits in until its reference
* window has filled.
*
* @return void
*/
public function testMissingReferenceStatisticsEmitsNothing(): void {
$outcome = ThresholdScenario::threshold([
'thold_type' => 1,
'bl_type' => 0,
'bl_pct_up' => 10,
'bl_pct_down' => 10,
'lastread' => 50,
])->alertRecipient('ops@example.org')->poll();
$this->assertSame(-1, $outcome->thold['bl_alert']);
$this->assertTrue($outcome->isSilent());
}
/**
* @return void
*/
public function testBreachBelowTheTriggerDoesNotNotify(): void {
$outcome = $this->baseline([
'lastread' => 500,
'bl_fail_trigger' => 3,
'bl_fail_count' => 0,
])->poll();
$this->assertSame(0, $outcome->mailCount());
}
/**
* @return void
*/
public function testMaintenanceWindowSuppressesNotification(): void {
$outcome = $this->baseline(['lastread' => 500])->inMaintenance()->poll();
$this->assertSame(0, $outcome->mailCount());
}
/**
* @return void
*/
public function testAcknowledgedThresholdDoesNotMailOnBreach(): void {
$outcome = $this->baseline([
'lastread' => 500,
'acknowledgment' => 'on',
])->poll();
$this->assertSame(0, $outcome->mailCount());
}
/**
* An absolute-deviation baseline adds the configured amount to the
* reference rather than a percentage of it, so 100 with a band of 10 gives
* the same 90 to 110 range for a very different configuration.
*
* @return void
*/
public function testAbsoluteDeviationUsesTheBandAsAnAmount(): void {
$inside = $this->baseline([
'bl_type' => 2,
'lastread' => 105,
'bl_pct_up' => 10,
'bl_pct_down' => 10,
])->poll();
$this->assertSame(0, $inside->thold['bl_alert']);
}
/**
* @return void
*/
public function testAbsoluteDeviationAlertsOutsideTheAmount(): void {
$outcome = $this->baseline([
'bl_type' => 2,
'lastread' => 200,
'bl_pct_up' => 10,
'bl_pct_down' => 10,
])->poll();
$this->assertSame(STAT_HI, $outcome->thold['bl_alert']);
}
}