Files
Cactiplugin_thold/tests/Unit/ThresholdTimeBasedCharacterizationTest.php
TheWitnessandCopilot 9b217e0e3a INFO: set compat to 1.2.29 (#838)
* INFO: set compat to 1.2.32

* docs: update Copilot instructions Cacti baseline to 1.2.32 (matches INFO compat)

* INFO: back off compat to 1.2.29

* Add manifest.json + upgrade-time file pruning

* Prune phpunit.xml on upgrade and ignore markdown-lint configs

phpunit.xml ships in the repo for CI but is a dev-only test artifact, so it
is removed from manifest.json 'expected', pruned from installs on upgrade
(like tests/), and excluded from the manifest drift check.

The retired markdown-lint configs (.mdlrc, .md_style.rb) are deleted, and
.md* is now ignored like .git*: protected from pruning and excluded from
drift if it reappears.

* Move thold_functions.php and thold_webapi.php into includes/; flatten css

The main threshold library becomes includes/functions.php and the web API
helper becomes includes/webapi.php; every caller (setup.php, includes/*, the
CLI/poller/notify entry points and the test suite) loads them from includes/.
Each per-theme stylesheet css/<theme>/main.css becomes css/<theme>.css so users
can drop their own css/<theme>.css into the css base, and the page_head hook
looks there. Old paths are tombstoned so existing installs drop the stale
copies on upgrade.

* Regenerate cacti.pot for the includes/ file relocations

Moving the plugin's library files into includes/ changed the source-reference
lines in the translation template; regenerate it so the 'Verify translation
template' CI check passes.

* Harden the hook-include test and make RPN integer ops explicit

The HookFunctionsIncludeTest invokes real hooks with placeholder input purely
to execute their relocated include_once lines; it now swallows engine
notices/warnings/deprecations during those calls (and restores the error
handler and config afterward) so it cannot trip the suite's failOnDeprecation
or leak state into other tests. The RPN % and ^ operators now cast their
operands to int explicitly, matching their long-standing integer-truncation
behaviour while silencing the implicit float-to-int conversion deprecation.

* Harden prune against tampered-manifest path traversal

The upgrade-time prune now rejects any tombstone containing '.'/'..' segments
(which could escape the plugin directory or resolve to its root) and treats
ancestors of whitelist entries as protected, so a tombstone on a parent
directory can no longer delete a whitelisted file beneath it.

* docs: update and align the Project Structure block

Point the structure tree at the relocated files (libraries now under
includes/, data files under docs/, stylesheets under css/) and align the
trailing '# ...' comments to a single column so they no longer drift right.

* docs/tests: standardize test header and correct manifest-contract notes

- Use the full license header (from the plugin's own setup.php) in
  tests/Unit/PruneFilesTest.php instead of the abbreviated copyright banner.
- Document that the manifest drift check and the upgrade-time prune also
  handle phpunit.xml and .md* files, matching the implemented behavior.

* refactor: rename prune helpers to the plugin-slug function prefix

The repository naming contract reserves the plugin_<name>_ prefix for plugin
lifecycle / hook-registration functions; all other functions use the plain
<name>_ prefix. Rename the internal upgrade helpers accordingly:

  plugin_<name>_prune_files() -> <name>_prune_files()
  plugin_<name>_rmtree()      -> <name>_rmtree()

The call site, unit tests, and the copilot-instructions.md references are
updated to match. No behavioral change.

* chore: set the Cacti compatibility floor to 1.2.29

Align the compat metadata (and the contributor-guide references) with the
team decision to standardize the minimum supported Cacti version at 1.2.29;
the previously proposed 1.2.32 floor was not adopted.

---------

Co-authored-by: Copilot <copilot@users.noreply.github.com>
2026-10-01 01:40:00 -05:00

195 lines
6.0 KiB
PHP

<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
/**
* What a time-based threshold does over one poll.
*
* This arm is a copy of the hi/low arm that has drifted, so several tests here
* exist to record where the two now disagree. Those are marked, with the issue
* that tracks the disagreement.
*/
final class ThresholdTimeBasedCharacterizationTest extends TestCase {
/**
* @return void
*/
public static function setUpBeforeClass(): void {
self::loadPluginSource('includes/functions.php');
self::loadPluginSourceAlways('includes/arrays.php');
self::loadPluginConstants();
}
/**
* @param array<string, mixed> $overrides
*
* @return ThresholdScenario
*/
private function bounded(array $overrides = []) {
return ThresholdScenario::threshold($overrides + [
'thold_type' => 2,
'time_hi' => 90,
'time_low' => 10,
])->alertRecipient('ops@example.org');
}
/**
* @return void
*/
public function testReadingInsideBothBoundsEmitsNothing(): void {
$outcome = $this->bounded(['lastread' => 50])->poll();
$this->assertTrue($outcome->isSilent());
}
/**
* @return void
*/
public function testBreachAtTriggerNotifiesAndLogsTheAlert(): void {
$outcome = $this->bounded(['lastread' => 95, 'time_fail_trigger' => 1])->poll();
$this->assertSame(1, $outcome->mailCount());
$this->assertSame([ST_NOTIFYAL], $outcome->logStatuses());
$this->assertSame(STAT_HI, $outcome->persistedAlertState());
}
/**
* @return void
*/
public function testBreachBelowTheLowerBoundRecordsTheLowState(): void {
$outcome = $this->bounded(['lastread' => 5, 'time_fail_trigger' => 1])->poll();
$this->assertSame(STAT_LO, $outcome->persistedAlertState());
}
/**
* The hi/low arm mails on restoral. This one writes the restoral to the log
* and clears the state, but sends nothing, so an operator watching a
* time-based threshold sees the alert and never the all-clear.
*
* Restoral requires the log-derived fail count to have reached the trigger
* (issue #746) - the harness always stubs that count to 0, so the trigger
* is set to 0 here to still exercise a threshold with no minimum streak.
*
* @return void
*/
public function testRestoralLogsButDoesNotMail(): void {
$outcome = $this->bounded([
'lastread' => 50,
'thold_alert' => STAT_HI,
'thold_fail_count' => 3,
'time_fail_trigger' => 0,
'time_warning_fail_trigger' => 0,
])->poll();
$this->assertSame([ST_NOTIFYRS], $outcome->logStatuses());
$this->assertSame(STAT_NORMAL, $outcome->persistedAlertState());
$this->assertSame(0, $outcome->mailCount());
}
/**
* See testRestoralLogsButDoesNotMail() for why the trigger is 0 here.
*
* @return void
*/
public function testRestoralResetsTheFailCounts(): void {
$outcome = $this->bounded([
'lastread' => 50,
'thold_alert' => STAT_HI,
'thold_fail_count' => 3,
'thold_warning_fail_count' => 2,
'time_fail_trigger' => 0,
'time_warning_fail_trigger' => 0,
])->poll();
$this->assertSame(['alert' => 0, 'warning' => 0], $outcome->persistedFailCounts());
}
/**
* The early-restoral branch (neither fail count reached its trigger) must
* apply the same acknowledgment-reset side effect as the two branches
* above it, or an acknowledged threshold that recovers before retriggering
* stays acknowledged forever.
*
* @return void
*/
public function testRestoralClearsAcknowledgmentWhenResetAckEnabled(): void {
$outcome = $this->bounded([
'lastread' => 50,
'thold_alert' => STAT_HI,
'thold_fail_count' => 3,
'acknowledgment' => 'on',
'reset_ack' => 'on',
])->poll();
$this->assertTrue($outcome->acknowledgmentCleared());
}
/**
* @return void
*/
public function testMaintenanceWindowSuppressesNotification(): void {
$scenario = $this->bounded(['lastread' => 95, 'time_fail_trigger' => 1])
->inMaintenance();
$fixture_root = realpath(dirname(__DIR__) . '/Fixtures');
$base_path = realpath($GLOBALS['config']['base_path']);
$this->assertNotFalse($fixture_root);
$this->assertNotFalse($base_path);
$this->assertStringStartsWith($fixture_root . DIRECTORY_SEPARATOR, $base_path . DIRECTORY_SEPARATOR);
$outcome = $scenario->poll();
$this->assertSame(0, $outcome->mailCount());
}
/**
* @return void
*/
public function testAcknowledgedThresholdDoesNotMailOnBreach(): void {
$outcome = $this->bounded([
'lastread' => 95,
'time_fail_trigger' => 1,
'acknowledgment' => 'on',
])->poll();
$this->assertSame(0, $outcome->mailCount());
}
/**
* @return void
*/
public function testUnknownReadingEmitsNoAlert(): void {
$outcome = $this->bounded([
'lastread' => 'U',
'thold_alert' => 2,
'thold_fail_count' => 3,
])->poll();
$this->assertSame(0, $outcome->mailCount());
$this->assertNull($outcome->persistedAlertState());
}
/**
* @return void
*/
public function testThresholdWithNoBoundsNeverBreaches(): void {
$outcome = ThresholdScenario::threshold(['thold_type' => 2, 'lastread' => 99999])
->alertRecipient('ops@example.org')
->poll();
$this->assertTrue($outcome->isSilent());
}
}