Copilot and admdly
35ae244041
Gate debug bar to debug mode, harden URL/error handling, and fix UpdatePatcher query typing/binding ( #3508 )
...
* Initial plan
* fix: apply requested routing, patcher, and test hardening diffs
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/e959bfdb-4f67-4b6b-a029-cc296b5e8057
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* test: make theme invalid-action status assertion compatible with live API helper
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/675d486f-4242-4143-9d17-987d7e104fd2
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-10 17:39:58 +01:00
Copilot and admdly
a0add76892
Clarify lookup error variable intent and tighten invalid action assertion ( #3500 )
...
* Initial plan
* Refine test naming and endpoint error assertion
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/c72c8914-fa26-41e3-8318-66a8eb660534
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-10 06:58:01 +01:00
Copilot and admdly
aa45a9dbd1
Initialize Plesk DNS params, normalize Staff service naming/docs, and harden admin integration tests ( #3499 )
...
* Initial plan
* Apply requested fixes for Plesk, Staff service, and tests
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/bac3f6d2-a36b-4de4-b716-074e94a52148
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-08 08:00:43 +01:00
Copilot and admdly
654ea31f2f
Clarify exception annotations, remove dead massmailer code, normalize staff permission schema, and harden integration test assertions ( #3498 )
...
* Initial plan
* Apply requested fixes for annotations, permissions, and tests
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/724562e3-bb44-420b-9399-fef57791b724
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Narrow ip lookup test error suppression to warnings only
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/724562e3-bb44-420b-9399-fef57791b724
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Simplify invalid action regex and document error severity delegation
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/724562e3-bb44-420b-9399-fef57791b724
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Sanitize ip lookup warning text before logging in system test
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/724562e3-bb44-420b-9399-fef57791b724
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-08 07:06:28 +01:00
FOSSBilling Bot and FOSSBilling Bot
0ba0512618
Apply PHP Code Styling & Quality Changes ( #3497 )
...
Co-authored-by: FOSSBilling Bot <fossbilling-bot>
2026-05-08 05:47:16 +01:00
Copilot and admdly
cfa1c16a6b
Fix spelling, grammar, strict comparison, and style issues in UpdatePatcher and AdminTest ( #3478 )
...
* Initial plan
* fix: correct spelling, grammar, strict comparison, and code style in UpdatePatcher and AdminTest
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/96e4e3ba-aa45-4ff5-b9f9-5d47a74424bf
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-03 23:47:21 +01:00
Copilot and admdly
6f609e982a
Fix missing isIpLookupAvailable() method and test cleanup issues in AdminTest ( #3473 )
...
* Initial plan
* Fix missing isIpLookupAvailable(), remove redundant comment, add try-finally in AdminTest
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/46242128-f435-4909-a07b-2ecd4b43f029
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-02 03:55:22 +01:00
Adam Daley and Copilot Autofix powered by AI
87d7e2b99b
Fixes for code quality findings in System module ( #3470 )
...
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
---------
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
2026-05-02 03:31:15 +01:00
Copilot and admdly
5292c10d0e
Fix spelling, test correctness, and code quality across System/Invoice modules ( #3469 )
...
Apply fixes: spelling, test assertions, strict equality, try-finally, and named constants
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/a85810bc-0126-402f-89ac-2da2d08d8fd9
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-02 03:14:06 +01:00
Copilot and admdly
0cd6913d7f
Remove invalid loading="lazy" from script tags; improve AdminTest coverage ( #3462 )
...
* Initial plan
* fix: remove invalid loading="lazy" from script tags; improve AdminTest coverage and DataProvider usage
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/2b9d02ed-eb73-469b-8286-b311d701efb7
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* fix: rename 'subshell' key to 'sub-shell' to fix spellcheck CI failure
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/be0ff0c6-9e75-4078-a5fe-a598fc47110d
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-04-30 18:51:21 +01:00
FOSSBilling Bot and FOSSBilling Bot
47944d18ea
Apply PHP Code Styling & Quality Changes ( #3460 )
...
Co-authored-by: FOSSBilling Bot <fossbilling-bot>
2026-04-30 16:44:41 +01:00
f86498c187
Fix for 1 code quality finding ( #3457 )
...
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Fix call site for renamed method isIpLookupAvailable in AdminTest
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/57c457e8-07ac-40a6-9640-e05601d5e656
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-04-28 19:59:07 +01:00
Copilot and admdly
3c8298056d
Fix multiple code quality bugs in API controller, Client service, and tests ( #3456 )
...
* Initial plan
* Apply code quality fixes across Api/Controller/Client.php, Client/Service.php, and tests
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/8f544bdc-a7a5-47aa-b25f-bafe2536dd5c
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Add nullable type declaration for apiConfig property
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/8f544bdc-a7a5-47aa-b25f-bafe2536dd5c
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Fix test expectations to match corrected SQL placeholders in Client/ServiceTest.php
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/1f23a81e-b05f-4684-86df-aa53a165b298
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-04-28 18:47:32 +01:00
FOSSBilling Bot and FOSSBilling Bot
ae4ed4410c
Apply PHP Code Styling & Quality Changes ( #3454 )
...
Co-authored-by: FOSSBilling Bot <fossbilling-bot>
2026-04-28 15:33:40 +01:00
72c6dcc532
Fixes for 3 code quality findings ( #3450 )
...
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* fix: add VERIFYPEER and VERIFYHOST to cspell ignoreWords
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/c79bcd25-22d6-424f-b7cb-b17b6ef16246
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-04-26 23:01:11 +01:00
Adam Daley and Copilot Autofix powered by AI
9ba38e4fea
Fixes for 2 code quality findings ( #3448 )
...
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
---------
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
2026-04-26 22:11:02 +01:00
Adam Daley and Copilot Autofix powered by AI
f981ceb518
Fixes for 4 code quality findings ( #3446 )
...
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
---------
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
2026-04-26 21:41:16 +01:00
Adam Daley and Copilot Autofix powered by AI
e2052adbb2
Fixes for 2 code quality findings ( #3445 )
...
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* Apply suggested fix to tests/Modules/System/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
---------
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
2026-04-26 21:12:02 +01:00
Copilot and admdly
ade0c4d0c1
Fix bugs and typos in installer/pricing templates, improve System admin test coverage ( #3444 )
...
* Initial plan
* Fix HTML/JS bugs and typos in installer and pricing templates, improve test coverage
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/d16eb3f4-9538-40af-a14b-3f110fe8bed1
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-04-26 21:04:48 +01:00
52081d284a
Improved type casting and removed unnecessary parameters ( #3431 )
...
* Cast ticket ID to integer
* Added type casting and removed unnecessary $per_page params
* Fixed tests
* Updated ddev PHP and nginx config
* Support ticket validation and upgrade checks
* Add order mock and constants in ServiceTest
* Require active status for API auth and clear tokens
* Validate client/admin sessions against DB
* Invalidate sessions on user status deactivation
* Check locale availability before toggling
* Escape database name properly
* Validate and cast rel_id to int in ticketCreateForClient to prevent TypeError
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/ce700346-2168-43cc-8309-fc6baee7cc82
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Improve rel_id validation error message to include the invalid value
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/ce700346-2168-43cc-8309-fc6baee7cc82
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Fix Notification AdminTest mock expectation to match actual paginateDoctrineQuery call
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/2fb587cf-6312-4b98-89e5-10f074646eaa
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Validate interface and custom interface inputs
* Tighten custom interface hostname validation
* Accept `per_page` in paginated API responses
* Validate HTTP interfaces and normalize upgrades
* Enforce active status and secure config export
* Cast rel_type/rel_task/rel_status to string in SupportTicketValidator to prevent TypeError
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/1ecf2bb3-1139-420f-8421-41ae8f6d1d5f
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Use FILTER_VALIDATE_INT instead of is_numeric for rel_id validation in Service.php
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/7bacd505-ba15-42da-8f52-7621afa1d634
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Validate rel_new_value as a positive integer before using as Product ID in upgrade tickets
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/842c7e1c-255b-4f09-8235-f34681e0392b
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Tighten `sValidHttpInterface` validation
* Add page parameter to pager calls
---------
Co-authored-by: Adam Daley <admdly@users.noreply.github.com >
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-04-26 20:30:22 +01:00
Belle Aerni
07698df6be
Re-enable the network interface tests ( #2810 )
...
* Re-enable the network interface tests
I am pretty sure a Symfomy HTTP client bug was causing the issue we saw. Some time ago they published fixes related to the BIND_TO option with IPv6
* We actually should expect the result to be empty here
2025-07-07 08:48:59 -07:00
Adam Daley
c0cc400b9d
Fix Live Tests ( #2325 )
...
* Refactor `getExternalIP()` to use `RetryableHttpClient`
Refactor `FOSSBilling\Tools` `getExternalIP()` function to use `RetryableHttpClient`.
* Fix incorrect parameter names and add cURL timeout
* Disable Network Interface live-tests
2024-07-02 21:20:10 +01:00
Belle Aerni
917b812835
Trying to resolve / workaround sporadic failures ( #2313 )
2024-06-26 11:59:13 -07:00
Belle Aerni and John @ S4
037acce702
Bulk fix of many grammar / phraseology mistakes ( #2166 )
...
* Bulk fix of many grammar / phraseology mistakes
* Small fixes after self-review
* Corrections
* Update mod_currency_settings.html.twig
* Update mod_currency_settings.html.twig
* Update mod_formbuilder_field.html.twig
---------
Co-authored-by: John @ S4 <64874788+John-S4@users.noreply.github.com >
2024-02-27 03:01:07 -08:00
Belle Aerni
0493c3a3e5
Further test improvements ( #2122 )
...
* Slight structure change to the testcases
* Fix
* Ported some random low-level tests
* Spelling
* Ported over some other low-level tests
* Fixes
* And now other fixes
* Another one
2024-02-06 13:13:04 -08:00
