b82df887fe
Enhance CI/CD with Docker optimizations and error handling ( #3509 )
...
* Bump Dockerfile syntax to 1.18
* Add getStatusCode to Response and update test
* Expect error code 740 for invalid theme action
* Use Docker-based CI/test image and live test script
* Add PHP 8.5 to CI matrix
* Add Buildx caching and optimize Docker build
* Add CI timeouts, quoting fixes, and release tree build
* Add concurrency, caching, and cleanup to CI
* Grant permissions for preview-build job
* Map error code 740 to HTTP 404 and update test
* Update cache-scope names in GitHub workflows
* Remove redundant status guard in theme admin test
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/b20f484f-0aaa-4afc-ae43-adb264bb05aa
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Grant cache export permissions to CI build job
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/a088c94f-a176-40fb-9e0b-ee3cac2aeb5b
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Disable cache for release artifact build
* Fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-10 22:43:16 +01:00
Copilot and admdly
35ae244041
Gate debug bar to debug mode, harden URL/error handling, and fix UpdatePatcher query typing/binding ( #3508 )
...
* Initial plan
* fix: apply requested routing, patcher, and test hardening diffs
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/e959bfdb-4f67-4b6b-a029-cc296b5e8057
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* test: make theme invalid-action status assertion compatible with live API helper
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/675d486f-4242-4143-9d17-987d7e104fd2
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-10 17:39:58 +01:00
Copilot and admdly
a0add76892
Clarify lookup error variable intent and tighten invalid action assertion ( #3500 )
...
* Initial plan
* Refine test naming and endpoint error assertion
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/c72c8914-fa26-41e3-8318-66a8eb660534
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-10 06:58:01 +01:00
Copilot and admdly
aa45a9dbd1
Initialize Plesk DNS params, normalize Staff service naming/docs, and harden admin integration tests ( #3499 )
...
* Initial plan
* Apply requested fixes for Plesk, Staff service, and tests
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/bac3f6d2-a36b-4de4-b716-074e94a52148
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-08 08:00:43 +01:00
Copilot and admdly
654ea31f2f
Clarify exception annotations, remove dead massmailer code, normalize staff permission schema, and harden integration test assertions ( #3498 )
...
* Initial plan
* Apply requested fixes for annotations, permissions, and tests
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/724562e3-bb44-420b-9399-fef57791b724
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Narrow ip lookup test error suppression to warnings only
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/724562e3-bb44-420b-9399-fef57791b724
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Simplify invalid action regex and document error severity delegation
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/724562e3-bb44-420b-9399-fef57791b724
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Sanitize ip lookup warning text before logging in system test
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/724562e3-bb44-420b-9399-fef57791b724
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-08 07:06:28 +01:00
Copilot and admdly
3ddd77f505
Improve staff password update form accessibility and strengthen invalid theme action error assertions ( #3491 )
...
* chore: outline plan for accessibility and test assertions fixes
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/daf9b5cb-e907-47da-a054-c0efce9e49a9
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Initial plan
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* fix accessibility in staff password update form and strengthen theme invalid-action test
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/daf9b5cb-e907-47da-a054-c0efce9e49a9
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* add aria-readonly to readonly email field in staff password update form
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/daf9b5cb-e907-47da-a054-c0efce9e49a9
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* refine test assertion message and keep readonly email input minimal
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/daf9b5cb-e907-47da-a054-c0efce9e49a9
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* fix Theme Admin invalid-action test to assert API error payload from response
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/b050fc4d-67fd-4d52-b1c0-3a4916c2a801
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-07 00:04:08 +01:00
Copilot and admdly
435852feb9
Fix label/input mismatch, duplicate autofocus, and improve error test assertions in staff password reset ( #3493 )
...
* Initial plan
* Fix email input accessibility, label/for mismatch, duplicate autofocus, and improve error test assertions
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/ff78cfe6-ae66-4c93-ba35-5af569b40725
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-06 23:42:05 +01:00
Adam Daley and Copilot Autofix powered by AI
0215699491
Fix for 1 code quality finding ( #3488 )
...
Apply suggested fix to tests/Modules/Theme/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
2026-05-06 21:09:28 +01:00
Adam Daley and Copilot Autofix powered by AI
6a6ff9d37e
Fix for 1 code quality finding ( #3487 )
...
Apply suggested fix to tests/Modules/Theme/AdminTest.php from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
2026-05-06 15:07:47 +01:00
Copilot and admdly
0c9a5fe6a7
Refactor test doubles, fix cron admin mock inconsistency, and add missing coverage ( #3486 )
...
* Initial plan
* Refactor test helpers: extract named doubles, fix mock inconsistencies, add return types and negative test cases
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/e732bafd-6bd7-40c6-b976-f13240612867
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Fix CI failures: use named class instead of addMethods(), fix checkInvoiceAuth assertion
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/c519e2d3-203c-4eba-962a-547a5f1ddfe0
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
* Fix testTryTokenLoginRejectsCronAdminToken: give dbAdmin and cronAdmin the same ID so the ID-match check throws the expected exception
Agent-Logs-Url: https://github.com/FOSSBilling/FOSSBilling/sessions/ae7acf19-c6bf-43c4-abaf-d50a321d69b3
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: admdly <2807620+admdly@users.noreply.github.com >
2026-05-06 14:59:18 +01:00
Yağızhan Burak Yakar and Adam Daley
091bd5c67b
Refactor guest API routes and reduce the information passed ( #3474 )
...
* Remove guest API system version endpoint
* Moved theme information to Admin API
* Removed references to the old "comment" module
* Remove unused cron endpoints
* Don't pass registrar information to guests
* Filter out Product toApiArray properties
* Redact public ticket information passed via the guest API
* Move redaction logic to the serializer
* Moved honeypot information to a Twig function
* More redaction
* Fixed tests
* Block additional paths
* Reduce the amount of information passed to clients
* Mask file downloads behind sendFile rather than serializing original path
* Move honeypot information to the new Twig function
* Add missing curly bracket
* Removed unused `get_slider` endpoint
* Turn publicMessageToApiArray into an allowlist
---------
Co-authored-by: Adam Daley <admdly@users.noreply.github.com >
2026-05-04 21:48:11 +01:00
