Commit Graph
22 Commits
Author SHA1 Message Date
Belle Aerni 50043e6211 Run Rector against our tests (#1761)
* Update rector config to include tests

* Run Rector against the tests

* Delete test-results

* Update .gitignore

* Correctly set the PHP min to 8.1, split the configs

* Corrected PHPDoc

* Deleted tests we can't really get to pass

PHPunit is hard-coded to fail when a class has a return type of `never`, which is the correct return type of our redirect function (and rightfully so).

No way to disable the exception as far as we can tell
2023-11-11 18:41:09 +00:00
Adam Daley 276df9a58e Update PHPUnit to version 10 (#1798)
* Update PHPUnit to version 10

Update composer and CI version of PHPUnit to 10, and migrate XML config to updated schema.

* Update tests for PHPUnit 10

Update tests to replace depreciated functions in PHPUnit 10. Also, remove risky tests which don't assert anything.
2023-11-09 10:43:30 +01:00
Adam Daley 230b10f6ea Replace direct config references with constants (#1768)
* Fix PATH_DATA constant to use config

Update `PATH_DATA` constant to use the `path_data` config option.

* Replace direct config references with constants

Replace direct references to `config.php` file and specific config options in favour of global constants, where available.

* Drop BB prefix on global constants

Rename global constants to drop `BB_` prefix, where appropriate.
2023-11-06 07:55:23 +00:00
Belle Aerni 602b537996 Opt-in error reporting via Sentry.io (#1732)
* Began implementing Sentry.io support

* Added to the installer

* Added the ID to the bug report template and UI

* Hook it into our error handler, added the ability to filter by error code

* Attempting to add the DSN via GH actions

* Spelling and making PHPstan happy

* Skip exceptions for various incomplete configurations

Also brings in some of the category suggestions made by @Anuril in #195

* Update tests to account for changes

* Added & renamed exception classes

* Fix tests

* Change a bunch of items to be InformationExceptions

* Use a lighter HTTP client, fixed API error reporting

* I guess that's not needed now?

Arighty then

* Improvements, additional info added

* Update SentryHelper.php

* Improved error logging, added instance ID to error page

Also made it so that errors are correctly sent to Sentry rather than exclusively exceptions

* Make the tests happy

* Added the link, improved wording

Also removed the "performance" part of the reporting as it needs to be added to the front-end and I'm not currently implementing that

* Began implementing UI alerts and info

* Added the ability to toggle, fixed tests, use path constants

* Added some useful info & links to the page

* These should be InformationException

* Fix the automated Sentry DSN entry

* Fix the install number text

* Minor cleanup, converted more to InformationException

* Replaced some direct config references with constants

We have the BB_DEBUG constant to indicate if we have debug mode enabled or not, so we shouldn't be directly referencing it in the config file unless we actually need to do so.

Using the constant means there's less locations to update the reference if the config structure is changed

* Bugfix

* Consistency & fixed a PHPDoc

* Corrections

* We actually do want exceptions thrown here

* Change how we get the instance ID

* Stability improvements

Having support for translatable error pages was proving to be problematic, so I had to remove it.

I also had to update the exception class to handle cases where the trans function wasn't setup yet (needed for the /run-patcher page if an error occurs)

* Missed this change on git

* Also fix the variable names...

* Re-added new deps after rebase

* This should also accept "Error" types

* Added more info to the bug report and removed a dug line

* This wasn't supposed to get renamed

* Updated some missed references to Box_Exception
2023-10-28 18:40:39 -07:00
Belle Aerni e0b84e58a7 Fix and improve cron messages in the admin panel (#1666)
* Fix and improve cron messages in the admin panel

* Add a note that the message is cached for 15 min
2023-10-02 03:32:03 -07:00
Christoph Schläpfer 95cdf9d329 Replaced Bank Clearing Code with BIC / SWIFT Code 2023-09-27 22:10:54 +02:00
Christoph Schläpfer a36695365d Made invoice to be checked against client as well. 2023-09-27 11:23:07 +02:00
Christoph Schläpfer 5cab8a3d8f Added option to configure if the bank information should be displayed on the bottom of every page 2023-09-27 11:14:50 +02:00
Christoph Schläpfer 0c5320b7db Fixed Test 2023-09-27 10:42:24 +02:00
Belle Aerni b9c35a1747 Replace Box_Session and improve session handling (#1332)
* Replace Box_Session and improve session handling

* Improve weights, capitalize class name correctly

* Make the tests pass, update the SQL structure

* Tweak to the fingerprint class, fix more tests

* Regenerate session IDs when logging in

* Improve readability

* Update ServiceTest.php

* Tweak weights and added Huntr badge to the readme

* Improve readability, add PHPDocs, and updated weight

* Update SECURITY.md
2023-06-19 04:14:29 -07:00
Adam Daley 0e5109a0a5 Refactor System Updater (#1252)
* Refactor System Updater

Refactor Box/Update to clean things up, merge related functionality, improve error checking, and move to FOSSBilling namespace.

Also refactor foss-update.php into core class, `UpdatePatcher`.

* Refactor file system actions to use Symfony Filesystem

Refactor file system actions to use Symfony Filesystem component, and declare all used resources at start of files rather than duplicating throughout.
2023-05-26 15:30:39 +01:00
Adam Daley e54569d2cd Introduce namespaces and strict typing for FOSSBilling library classes (#1206) 2023-05-04 01:02:06 +01:00
Adam Daley 053f22a8bb Remove Box DI class in favour of native dependencies (#1193) 2023-04-30 08:47:52 +01:00
Yağızhan 191233ff86 Renamed Box_Requirements and Box_Version (#1146)
* Renamed Box_Requirements and Box_Version

* Fixed the reference in the GitHub workflow
2023-04-22 18:55:48 +02:00
Adam Daley ca67aeb44f Refactor request handling to use native functionality (#1122)
Refactor request handling to remove custom library/Box/Request class where possible and instead use native PHP functionality.
2023-04-21 15:07:59 +02:00
Adam Daley a2abdbddfa Refactor Box/Tools to remove unnecessary functions (#1115)
* Refactor Box/Tools to remove unnecessary functions

Refactor Box/Tools to remove functions which essentially duplicate PHP functionality, or provide a thin wrapper around such functions.

* Move config migrate/update to relevant class

Move config update functionality from Box/Tools to Box/Update.

* Move Gravatar function to class where used

Moved Gravatar function to Twig filter where it is used, rather than in a custom Box/Tool function.
2023-04-17 20:48:49 -07:00
Belle Aerni 16c929f5e7 Automatically select locale based on browser info (#1109)
* Detect browser locale

* Workaround for two char locales being detected
2023-04-16 19:28:03 +02:00
Belle Aerni 9faa981c58 Replace usage of array_get (#989)
* Replace usage of array_get

* Fixes

* And a few more

* Remove remaining references

* Update Service.php

* Few more fixes

* Fix.. I think?

* Fix Client / Invoice updates

* Fix stats

* Fix issues noticed during code review

* More fixes

* And some more fixes :)
2023-03-27 23:44:30 -07:00
Adam 11a1906ee7 Fix broken module tests (#867)
* Fix typo in Email module tests

Fix missing semicolon in tests for Email module causing PHPUnit to fail.

* Fix module test errors due to RedBean

Fix module tests causing error due to RedBean when being mocked in PHPUnit.

* Fix module test failures

Update module tests to fix failures, and remove obsoleted tests causing failure.
2023-02-27 10:38:20 -08:00
Belle Aerni 18ee32f357 Move the locales to a submodule (#537)
* Move the locale folder to a submodule

* Create locale

* Update the tasks

* Remove that part of the check
2022-12-06 18:52:51 -08:00
Yağızhan 59027f6535 Dark variant option for the company logo (#497)
* +dark variant option for the company logo

* Updated content dates

* Fixed the default logo not being picked up

* Tests
2022-12-01 21:08:05 +01:00
Belle Aerni edd6f72634 Drop the "BB" prefix 2022-11-28 17:22:50 +03:00