mirror of
https://github.com/FOSSBilling/FOSSBilling.git
synced 2026-11-05 03:27:33 +09:00
- Servicedomain order validation accepts the product context like its sibling service modules, fixing a TypeError when ordering domains through the cart. Fixes FOSSBILLING-Q0R. - cPanel account sync casts the suspended flag to bool, fixing a TypeError when the API reports it as an integer. Fixes FOSSBILLING-N3T.
117 lines
4.3 KiB
PHP
117 lines
4.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Symfony\Component\HttpClient\MockHttpClient;
|
|
use Symfony\Component\HttpClient\Response\MockResponse;
|
|
use Symfony\Contracts\HttpClient\HttpClientInterface;
|
|
|
|
function createWhmManager(HttpClientInterface $httpClient): Server_Manager_Whm
|
|
{
|
|
return new class(['host' => 'whm.example.com', 'username' => 'admin', 'password' => 'secret'], $httpClient) extends Server_Manager_Whm {
|
|
public function __construct(array $options, private readonly HttpClientInterface $httpClient)
|
|
{
|
|
parent::__construct($options);
|
|
}
|
|
|
|
public function getHttpClient(): HttpClientInterface
|
|
{
|
|
return $this->httpClient;
|
|
}
|
|
};
|
|
}
|
|
|
|
function createWhmAccount(Server_Package $package, bool $reseller): Server_Account
|
|
{
|
|
return (new Server_Account())
|
|
->setUsername('example')
|
|
->setDomain('example.com')
|
|
->setPassword('secret')
|
|
->setClient((new Server_Client())->setEmail('client@example.com'))
|
|
->setPackage($package)
|
|
->setReseller($reseller);
|
|
}
|
|
|
|
function actionOf(array $request): string
|
|
{
|
|
return basename((string) parse_url($request['url'], PHP_URL_PATH));
|
|
}
|
|
|
|
function createWhmAccountCreationClient(array &$requests): MockHttpClient
|
|
{
|
|
return new MockHttpClient(function (string $method, string $url, array $options) use (&$requests): MockResponse {
|
|
$requests[] = ['method' => $method, 'url' => $url, 'options' => $options];
|
|
|
|
if (str_contains($url, 'listpkgs')) {
|
|
return new MockResponse(json_encode(['package' => []]));
|
|
}
|
|
|
|
if (str_contains($url, 'createacct')) {
|
|
return new MockResponse(json_encode(['result' => [['status' => 1]]]));
|
|
}
|
|
|
|
return new MockResponse(json_encode(['status' => 1]));
|
|
});
|
|
}
|
|
|
|
test('createAccount sets up the reseller but does not touch the ACL list when the plan has no acl custom value', function (): void {
|
|
$requests = [];
|
|
$manager = createWhmManager(createWhmAccountCreationClient($requests));
|
|
$account = createWhmAccount(new Server_Package(), true);
|
|
|
|
expect($manager->createAccount($account))->toBeTrue();
|
|
|
|
$actions = array_map(actionOf(...), $requests);
|
|
|
|
// Calling "setacls" with an empty acllist would strip the initial privileges "setupreseller"
|
|
// just granted, so it must be skipped when the plan has no 'acl' custom value.
|
|
expect($actions)->toBe(['listpkgs', 'addpkg', 'createacct', 'setupreseller'])
|
|
->and($actions)->not->toContain('setacls');
|
|
});
|
|
|
|
test('createAccount assigns the plan\'s acl custom value to the reseller via setacls', function (): void {
|
|
$requests = [];
|
|
$manager = createWhmManager(createWhmAccountCreationClient($requests));
|
|
$package = (new Server_Package())->setCustomValues(['acl' => 'reseller_basic']);
|
|
$account = createWhmAccount($package, true);
|
|
|
|
expect($manager->createAccount($account))->toBeTrue();
|
|
|
|
$actions = array_map(actionOf(...), $requests);
|
|
expect($actions)->toBe(['listpkgs', 'addpkg', 'createacct', 'setupreseller', 'setacls']);
|
|
|
|
$setaclsRequest = $requests[array_search('setacls', $actions, true)];
|
|
parse_str((string) $setaclsRequest['options']['body'], $fields);
|
|
|
|
expect($fields)->toMatchArray([
|
|
'reseller' => 'example',
|
|
'acllist' => 'reseller_basic',
|
|
]);
|
|
});
|
|
|
|
test('synchronizeAccount casts the suspended flag to bool', function (): void {
|
|
$client = new MockHttpClient(fn (): MockResponse => new MockResponse(json_encode([
|
|
'acct' => [
|
|
['suspended' => 1, 'domain' => 'example.com', 'user' => 'example', 'ip' => '1.2.3.4'],
|
|
],
|
|
])));
|
|
$manager = createWhmManager($client);
|
|
$account = createWhmAccount(new Server_Package(), false);
|
|
|
|
$updated = $manager->synchronizeAccount($account);
|
|
|
|
expect($updated->getSuspended())->toBeTrue();
|
|
});
|
|
|
|
test('createAccount never calls setupreseller or setacls for a non-reseller account', function (): void {
|
|
$requests = [];
|
|
$manager = createWhmManager(createWhmAccountCreationClient($requests));
|
|
$package = (new Server_Package())->setCustomValues(['acl' => 'reseller_basic']);
|
|
$account = createWhmAccount($package, false);
|
|
|
|
expect($manager->createAccount($account))->toBeTrue();
|
|
|
|
$actions = array_map(actionOf(...), $requests);
|
|
expect($actions)->toBe(['listpkgs', 'addpkg', 'createacct']);
|
|
});
|