Files
FOSSBilling/tests/modules
Christoph SchlaepferandBelle Aerni 7a38450458 Make system version & company info visibility through the guest API configurable (#1504)
* Add feature to hide public FOSSBilling version and Company information

* Cleaned up

* Added Test cases for Version & Company information

* Fixed Authorization Mock

* Fixed Tests so isAdminLoggedIn is false when testing Public Access

* Cleaned up

* Implemented Suggested code and fixed tests.

* Removed manual Version for API.js string and replaced with twig filter "script_tag"

* Added Twig filter for Version and replaced guest.system_version

* Added Message to Admin Settings

* Now let's do all of that, but better

- A filter is the wrong way to get the system version to the front end
- The wording in the admin panel for these settings didn't correctly describe what they did and they had poor grammar
- The version check should be returning a string, not an array & the code can be significantly cleaned up.
- Inverting the behavior of these toggles means that existing installations will continue to have the same behavior as before without us forcibly changing it. Otherwise, we need to introduce a DB patch to add the new values with them being on to match what was the old behavior.
- For new installations, we can pretty safely turn these options off to give a bit more privacy / security and allow them to be turned back on if wanted.
- New installations can keep the current behavior. We will highlight that this feature is added & if it's something the administrator wants, they can adjust the settings for themselves

* Cursed spelling *angry hand movements*

* That should have never been an array to being with

---------

Co-authored-by: Belle Aerni <belleaerni@gmail.com>
2023-08-02 19:40:43 +02:00
..
2023-07-03 14:54:23 -07:00
2023-07-14 17:03:22 +03:00