mirror of
https://github.com/FOSSBilling/FOSSBilling.git
synced 2026-11-04 02:57:11 +09:00
* ✨ Show promo redemption history on the promo detail page
Adds a Redemption History table to the product promotion detail page,
listing the individual clients, orders, invoices, phase, status, and
discount amount for every redemption of a promo code. The admin API
(product_promo_redemption_get_list) and backing data model already
existed; the promo list page even linked to a #promo-redemptions
anchor that didn't exist yet. This wires it up.
Refs #588
* 🔒 Don't auto-delete install/ when APP_ENV is ambiguous
checkInstaller() (src/load.php) runs on every bootstrap and, once the
app is installed, deletes the src/install/ directory automatically.
It gated that irreversible delete on Environment::isProduction(),
which silently treats a missing or unrecognized APP_ENV as production.
APP_ENV=dev is only set inside DDEV's web container, so any process
that touches load.php outside of it (a bare `php console.php`, a
stray `php -S`, etc.) resolves to production by default and wipes
install/ with no warning. This happened in a local dev checkout.
Add Environment::isExplicitlyProduction(), which is only true when
APP_ENV is literally "prod", and require it specifically for this
delete. isProduction()'s existing default-to-production behavior is
left untouched elsewhere, since other checks rely on it (email-sending
gates, DNS validation strictness, admin nudges) in ways that are
either non-destructive or where failing toward production is correct.
Also logs before removing the directory instead of doing so silently.
* 🐛 Prevent request query params from overriding the promo_id
CodeRabbit review: merge(request) ran last in the redemption list query,
so a crafted ?promo_id= query param could override the promo actually
being viewed and show another promotion's redemption data. Force
promo_id last so it always reflects the page's own promo, while still
letting per_page/page follow the pagination controls as intended.
(cherry picked from commit 176f295a2b)
206 lines
6.5 KiB
PHP
206 lines
6.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;
|
|
|
|
/*
|
|
|--------------------------------------------------------------------------
|
|
| Test Case
|
|
|--------------------------------------------------------------------------
|
|
|
|
|
| The closure you provide to your test functions is always bound to a specific
|
|
| PHPUnit test case class. By default, that class is "PHPUnit\Framework\TestCase".
|
|
|
|
|
| You can define custom test case classes in this file and use them via the
|
|
| `uses()` function.
|
|
|
|
|
*/
|
|
|
|
// Global test configuration
|
|
putenv('APP_ENV=test');
|
|
define('PATH_TESTS', __DIR__);
|
|
|
|
// Bump the memory limit. The strict-variables render-everything harness
|
|
// parses every FOSSBilling template and allocates many stubs and AST nodes,
|
|
// which exceeds the default 128M limit and causes the pest process to exit
|
|
// with 255 mid-suite. 2G is comfortably above peak usage (~185M).
|
|
ini_set('memory_limit', '2G');
|
|
|
|
// Disable DEBUG mode to prevent FOSSBilling\Exception from logging stack traces
|
|
// Must be defined BEFORE load.php is included
|
|
if (!defined('DEBUG')) {
|
|
define('DEBUG', false);
|
|
}
|
|
|
|
// Pre-declare translation functions to prevent Box_Translate from trying to redefine them
|
|
// These stubs will be used if the full translation system isn't initialized
|
|
if (!function_exists('__trans')) {
|
|
function __trans(string $msgid, ?array $values = null): string
|
|
{
|
|
return $values ? strtr($msgid, $values) : $msgid;
|
|
}
|
|
}
|
|
if (!function_exists('__pluralTrans')) {
|
|
function __pluralTrans(string $msgid, string $msgidPlural, int $number, ?array $values = null): string
|
|
{
|
|
return $values ? strtr($msgid, $values) : $msgid;
|
|
}
|
|
}
|
|
|
|
// Load application bootstrap
|
|
require_once __DIR__ . '/../src/load.php';
|
|
require_once __DIR__ . '/../src/vendor/autoload.php';
|
|
|
|
// Load test helpers
|
|
require_once __DIR__ . '/Helpers/Container.php';
|
|
require_once __DIR__ . '/Helpers/Factories.php';
|
|
require_once __DIR__ . '/Helpers/Api.php';
|
|
require_once __DIR__ . '/Helpers/DummyBean.php';
|
|
require_once __DIR__ . '/Support/CombinedTwigLoader.php';
|
|
require_once __DIR__ . '/Support/PermissiveStub.php';
|
|
require_once __DIR__ . '/Support/PermissiveContainer.php';
|
|
require_once __DIR__ . '/Support/VariableCollectorVisitor.php';
|
|
require_once __DIR__ . '/Support/StrictTemplateRenderer.php';
|
|
require_once __DIR__ . '/Support/TwigAstLinter.php';
|
|
require_once __DIR__ . '/Support/ToApiArrayAuditor.php';
|
|
|
|
// Load test datasets
|
|
require_once __DIR__ . '/Datasets/PeriodCodes.php';
|
|
require_once __DIR__ . '/Datasets/ValidationData.php';
|
|
require_once __DIR__ . '/Datasets/GeographicData.php';
|
|
|
|
/**
|
|
* Construct an API endpoint with the default test container.
|
|
*
|
|
* @template T of FOSSBilling\Api\AbstractApi
|
|
*
|
|
* @param T $api
|
|
*
|
|
* @return T
|
|
*/
|
|
function apiEndpoint(FOSSBilling\Api\AbstractApi $api): FOSSBilling\Api\AbstractApi
|
|
{
|
|
$api->setDi(Tests\Helpers\container());
|
|
|
|
return $api;
|
|
}
|
|
|
|
/**
|
|
* Runs $callback with APP_ENV set to $value (or unset entirely when $value is null),
|
|
* restoring the previous value afterward regardless of outcome.
|
|
*/
|
|
function withAppEnv(?string $value, callable $callback): mixed
|
|
{
|
|
$previous = getenv('APP_ENV');
|
|
|
|
if ($value === null) {
|
|
putenv('APP_ENV');
|
|
} else {
|
|
putenv('APP_ENV=' . $value);
|
|
}
|
|
|
|
try {
|
|
return $callback();
|
|
} finally {
|
|
putenv($previous === false ? 'APP_ENV' : 'APP_ENV=' . $previous);
|
|
}
|
|
}
|
|
|
|
// Define TestLogger class after autoloader is registered
|
|
// This must be done here because it extends Box_Log which is loaded via the autoloader
|
|
// Using eval() to defer class definition until runtime when Box_Log is available
|
|
// @phpstan-ignore-next-line
|
|
if (!class_exists(Tests\Helpers\TestLogger::class)) {
|
|
// @phpstan-ignore-next-line
|
|
eval('
|
|
namespace Tests\Helpers;
|
|
|
|
class TestLogger extends \Box_Log
|
|
{
|
|
public array $calls = [];
|
|
|
|
public function __construct()
|
|
{
|
|
$this->calls = [];
|
|
}
|
|
|
|
public function __call($method, $params): void
|
|
{
|
|
$this->calls[] = ["method" => $method, "params" => $params];
|
|
}
|
|
}
|
|
');
|
|
}
|
|
|
|
// Redirect error_log to /dev/null during tests to prevent "PHPUnit controlled exception" clutter
|
|
ini_set('error_log', '/dev/null');
|
|
|
|
// Configure Unit tests base with Mockery integration
|
|
uses(MockeryPHPUnitIntegration::class)
|
|
->beforeEach(function (): void {
|
|
// Unit test setup
|
|
})
|
|
->in('Unit');
|
|
|
|
// Configure E2E tests - requires live instance with API access
|
|
// Run with: ./vendor/bin/pest --testsuite=E2E
|
|
// Requires APP_URL and TEST_API_KEY environment variables
|
|
$appUrl = getenv('APP_URL');
|
|
$testApiKey = getenv('TEST_API_KEY');
|
|
|
|
if ($appUrl && $testApiKey) {
|
|
uses()
|
|
->beforeEach(function () use ($appUrl, $testApiKey): void {
|
|
Tests\Helpers\ApiClient::setBaseUrl($appUrl);
|
|
Tests\Helpers\ApiClient::setApiKey($testApiKey);
|
|
})
|
|
->in('E2E');
|
|
}
|
|
|
|
/*
|
|
|--------------------------------------------------------------------------
|
|
| Expectations
|
|
|--------------------------------------------------------------------------
|
|
|
|
|
| When you're writing tests, you often need to check that values meet certain
|
|
| conditions. The "expect()" function gives you access to a set of useful
|
|
| expectation methods.
|
|
|
|
|
*/
|
|
|
|
expect()->extend('toBeDomain', function (): void {
|
|
$this->not->toBeEmpty();
|
|
expect($this->value)->toBeString();
|
|
expect(filter_var($this->value, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME))->not->toBeFalse();
|
|
});
|
|
|
|
expect()->extend('toBeEmail', function (): void {
|
|
$this->not->toBeEmpty();
|
|
expect($this->value)->toBeString();
|
|
expect(filter_var($this->value, FILTER_VALIDATE_EMAIL))->not->toBeFalse();
|
|
});
|
|
|
|
expect()->extend('toBeUrl', function (): void {
|
|
$this->not->toBeEmpty();
|
|
expect($this->value)->toBeString();
|
|
expect(filter_var($this->value, FILTER_VALIDATE_URL))->not->toBeFalse();
|
|
});
|
|
|
|
expect()->extend('toBeUuid', function (): void {
|
|
$this->not->toBeEmpty();
|
|
expect($this->value)->toBeString();
|
|
expect(preg_match('/^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i', $this->value))->toBe(1);
|
|
});
|
|
|
|
/*
|
|
|--------------------------------------------------------------------------
|
|
| Functions
|
|
|--------------------------------------------------------------------------
|
|
|
|
|
| While Pest is very powerful out-of-the-box, you may have some testing code
|
|
| specific to your project that you don't want to repeat in every file.
|
|
| Here you can define custom helper functions and expect() extensions.
|
|
|
|
|
*/
|