Files
Juan DenisandClaude Fable 5 5417c39100 perf(models): index every foreign-key column
An audit found 102 FK columns with no index — every join, per-parent
listing, and the delete cascades from _delete_cascade_policy scanned
whole tables on them (deployments.app_id, audit_logs.user_id,
dns_records.zone_id, webhook_logs.webhook_id, ...). All FK columns now
declare index=True; migration 096 creates the same indexes on existing
installs, deriving the list from the live schema at upgrade time (so
it is idempotent and cannot drift from what an install actually has).

Ratchet: test_every_fk_column_is_indexed pins the rule with no
allowlist — a new FK column is born indexed or the build fails.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-31 20:42:53 -04:00

42 lines
2.1 KiB
Python

from datetime import datetime
from app import db
from app.models.mixins import TimestampMixin, SerializableMixin
class ManagedDnsRecord(SerializableMixin, TimestampMixin, db.Model):
"""Ledger of DNS records ServerKit created in an external provider zone.
The single source of truth for "we own this record". It's written whenever the
panel creates/updates a record through a connected provider — the /dns Zones
page, Dynamic DNS, WordPress custom-domain auto-DNS, and email — and removed on
delete.
The never-touch-foreign guard and the live zone mirror read from here to tell
ServerKit's own records apart from the user's pre-existing ones (their "Maria &
Pedro" records), which the panel must never mutate.
"""
__tablename__ = 'managed_dns_records'
id = db.Column(db.Integer, primary_key=True)
dns_provider_config_id = db.Column(
db.Integer, db.ForeignKey('dns_provider_configs.id'), nullable=True, index=True)
provider = db.Column(db.String(64), nullable=False) # cloudflare, ...
provider_zone_id = db.Column(db.String(128), nullable=False, index=True)
provider_record_id = db.Column(db.String(128), index=True) # set once known
record_type = db.Column(db.String(10), nullable=False)
name = db.Column(db.String(256), nullable=False) # FQDN
content = db.Column(db.Text)
ttl = db.Column(db.Integer)
priority = db.Column(db.Integer)
# Nullable on purpose: rows predating migration 092 do not know these
# provider attributes. Restore must preserve/hydrate unknowns, not invent
# a default that could change live DNS behavior.
proxied = db.Column(db.Boolean)
source = db.Column(db.String(40)) # zone|ddns|preset|wordpress|email
app_id = db.Column(db.Integer, db.ForeignKey('applications.id'), nullable=True, index=True)
# Serialization comes from SerializableMixin; these columns stay out
# of API payloads (parity with the deleted hand-written to_dict).
__serialize_exclude__ = ('dns_provider_config_id',)