mirror of
https://github.com/jhd3197/ServerKit.git
synced 2026-11-09 05:24:49 +09:00
on_restore_domain deliberately does not re-issue a certificate -- ssl_enabled can still be True over cert files that expired while the row sat in the bin, and quietly talking to Let's Encrypt is not something a "put it back" button should do. That decision stays. What was missing is telling anyone. The domain returns on plain HTTP while its row still reads ssl_enabled, so the first sign is a browser warning. A restore now has three outcomes instead of two: the side effect FAILED (warning, error toast), it succeeded but left something actionable (notice, warning toast), or it just worked. An on_restore hook returns a string to raise a notice; it rides on the item so it cannot be confused with the error slot. The notice only fires when nothing is actually serving HTTPS for that name -- app_vhost_kwargs re-attaches a covering wildcard, and warning about a domain that came back on HTTPS anyway would just be noise. 3 tests: notice present, notice suppressed under a covering wildcard, and no notice for a domain that was never HTTPS. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>