mirror of
https://github.com/jhd3197/ServerKit.git
synced 2026-11-10 14:03:14 +09:00
Juan DenisandClaude Opus 5
fc000a3b97
Plan 73 item 5. The Domains SSL modal asked for a contact email on every single certificate, and the backend hard-required one per call. The app-detail Settings tab did remember it -- in localStorage, so the memory was per browser and invisible to the other surface. The two never agreed, and neither could help the paths with no form at all: domain attach passed `admin@<host>` when it had nothing else, an address that usually does not exist, which is where every expiry notice for those certificates went to die. There is now a single panel-wide ACME contact in system settings. get_acme_contact() resolves an explicit address first and falls back to the stored one; remember_acme_contact() writes it back whenever a request carries an explicit address. Both are best-effort on the settings side by design: a settings failure must not break issuance, and failing to remember an address must not turn a successful certificate into an error. An empty input never clears a stored contact, since the automatic paths pass whatever they were given and that is frequently nothing. Wired into every issuance entry point -- the domain SSL enable route, the generic certificate route, and domain attach, which now consults the stored contact before falling back to the admin@<host> guess. The address is only remembered after issuance actually succeeds; remembering one Let's Encrypt rejected would be worse than remembering none. Prefill needed its own endpoint. The settings routes are all admin-gated, but issuing a certificate for an app you can edit is not an admin action, so GET /ssl/acme-contact is jwt_required only -- it returns an address the operator chose for notices, not a credential. The Domains modal and the Settings tab both prefill from it, and the Settings tab keeps its localStorage seed so a browser that already has the value shows it without a flash. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>