mirror of
https://github.com/jhd3197/ServerKit.git
synced 2026-11-03 18:46:47 +09:00
Juan DenisandClaude Opus 5
81928ec7ff
Plan 73 item 1. SSLService hardcoded /usr/bin/certbot, so the install method certbot itself recommends -- snap, which lands in /snap/bin -- produced a FileNotFoundError the panel surfaced as an opaque failure. is_command_available had the same blind spot: it probed /usr/bin, /usr/sbin and the two local dirs but never /snap/bin, which is routinely absent from a service's $PATH. resolve_certbot_bin() now tries the CERTBOT_BIN override, then shutil.which, then the explicit candidate list including the snap path. Positive results are cached (an install location does not move mid-process) but negative ones are not, so installing certbot is picked up without a panel restart; install_certbot clears the cache outright. CERTBOT_BIN as a class attribute is gone -- it captured the value at import time, which is exactly why an override set later never took effect -- replaced by certbot_bin() plus CERTBOT_FALLBACK so a command built on a host with no certbot still fails cleanly. The second half is the failure the reviewer actually hit on stream: with certbot present but its nginx plugin missing, `certbot --nginx` dies deep inside certbot with "the nginx plugin is not working / binary doesn't exist", and we passed that through raw. obtain_certificate now preflights -- nginx on the box, then `certbot plugins` for an enabled `* nginx` -- and returns an actionable error naming python3-certbot-nginx before certbot is ever invoked for issuance. A failing plugins probe falls back to the distro package check rather than blocking issuance on a host where the plugin is clearly present. AdvancedSSLService's wildcard and multi-domain commands go through the same resolution instead of the bare name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>