65 Commits
Author SHA1 Message Date
Thomas Vincent 62063a29e0 fix(theme): [develop] correct CSS cascade, invalid values and responsive selectors (#8293)
* fix(themes): correct CSS cascade, font fallbacks and responsive selectors

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix(themes): remove validated empty and redundant CSS rules

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* style(css): remove reviewed inactive rules and redundant separators

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* style(themes): consolidate two reviewed duplicate selectors

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix(themes): remove identical whitespace declaration after consolidation

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix(theme): keep context menu fallbacks in Cacti overrides

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test(theme): measure native CSS and header coverage

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* ci: retain bootstrap coverage and validate request dispatch

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test: synchronize native coverage fixture dispatch

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test: measure coverage at the exact PR revision

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test: cover Midwinter and graph heading CSS repairs in Chromium

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* ci: take the theme coverage base from the merge commit parent

- github.event.pull_request.base.sha can predate the develop tip the checkout was merged onto, which counted develop's own CSS lines as the PR's.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

---------

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
2026-10-14 22:51:15 -04:00
TheWitness e25a67c31f Common graph drilldown hamburger toggle across all themes (#8308)
* Graph drilldown: common hamburger toggle across all themes

The graph action icons were revealed by hovering to the right of the graph, implemented per-theme (dark/midwinter/sunrise main.js) and always-on elsewhere.

Hide the icons by default behind a small fa-bars hamburger overlaid on the graph's top-right. Clicking it opens the icon strip, which stays until a second click, leaving the strip, or an outside click. The behaviour is now centralized in include/layout.js (initGraphDrilldown) and include/css/graph_drilldown.css, and the per-theme hover JS is removed.

* changelog: 8308 feature fragment

* Graph drilldown: address review (a11y, positioning, spikekill, POT)

- Anchor the toggle to the shrink-wrapped graph holder (width:fit-content) so the hamburger sits on the graph's top-right, not the full-width column edge.

- Keep the hamburger focusable while visually hidden (opacity instead of display:none); reveal on hover, keyboard focus, open, and hover-less devices.

- Expose aria-expanded on the toggle and update it in every open/close path; add aria-haspopup/aria-label.

- Close any open SpikeKill submenu (spikeKillClose) when the strip closes or switches, matching the removed per-theme handlers.

- Remove the now-duplicate Midwinter top-right ellipsis pseudo-element.

- Add the new 'Graph Actions' msgid to locales/po/cacti.pot.
2026-10-11 17:20:06 -04:00
TheWitness 22ab16cac9 themes: unify login page styling across all core themes (#8230)
* themes: unify login page styling across all core themes

Flatten the dark themes' login page/card gradients (dark, paper-plane) to flat surfaces, give every theme a clean bordered login card, and add a browser -webkit-autofill override per theme so saved credentials keep the theme's input colors instead of the browser's olive tint. Re-point the Deepness and MidWinter themes' login styling from the legacy .login*/.cactiLogin* classes to develop's .cactiAuth* markup (including .cactiAuthLeft, which auth_login.php targets) so their login pages render correctly. Light themes keep their signature login backdrops.

* changelog: add fragment for login page theme unification (#8230)
2026-10-08 13:32:01 -04:00
TheWitness 6f57c319dd midwinter: colour the graph drilldown action icons from the theme palette (develop port of #8228) (#8229)
* midwinter: colour the graph drilldown action icons using theme-palette variables (distinct task-appropriate hues, dark + light modes)

* changelog: add fragment for midwinter graph drilldown icon colours (#8229)
2026-10-08 13:30:50 -04:00
MurisandTheWitness 2c791b3db8 Fix printing of the detailed graph view on develop (#8193)
* Fix detailed graph print layout on develop

* Reference develop PR 8193 in changelog fragment

---------

Co-authored-by: TheWitness <thewitness@cacti.net>
2026-10-06 13:56:38 -04:00
TheWitnessandTheWitness d4b8cd3814 fix: align Force Uninstall icon (.piforceremove) on the Plugins page (#8110)
* fix: align Force Uninstall icon by adding .piforceremove to icon-padding rule

The orphaned-plugin (-5) control introduced in #8107 renders a .piforceremove anchor, but that class was missing from the plugin-action icon padding rule, so the icon lost its 0 3px padding and misaligned in the Actions column. Add .piforceremove alongside .pierror in every theme stylesheet.

* fix: align Force Uninstall confirm wording to standard 'Otherwise click Cancel.' pattern

develop counterpart of the #8109 dialog copy fix. develop already uses the non-modal displayDialog() with a plain-text message, so only the closing sentence is aligned to the house pattern (with trailing period). cacti.pot msgid updated to match.

* fix: bump midwinter core.css cache-buster hash to match the updated file

The Force Uninstall (.piforceremove) alignment change edited
include/themes/midwinter/css/media/core.css, changing its content md5 to
afd5bc6f4d45884846ab715f1583123c, but main.css still imported it with the old
?ad4ed321... query string. Browsers holding the pre-change stylesheet in cache
would keep the icon misaligned. Update the import hash so the change is picked up.

---------

Co-authored-by: TheWitness <copilot@users.noreply.github.com>
2026-09-29 16:32:46 -05:00
J.P. Pasnak 5e4be9188e typo (#7064) 2026-04-25 17:59:44 -04:00
Browniebraun b814eb4b20 MidWinter - replacing third party libraries by native Vanilla (#7060)
replacing third party libraries by native Vanilla
2026-04-22 12:56:21 -04:00
Browniebraun d703edb6e6 Latest State of MidWinter Refactoring (#7043)
* support dynamic resizable rrdgraph

* introducing the newest version of navigationBox including plugin support. This allows reusable navigation Boxes e.g. different trees and so on.
2026-04-13 19:31:05 +02:00
TheWitness 7919efd137 Issues found in testing (#6595)
* QA: Add database session clear out to change password

* QA: Can not determine average fully loaded

* QA: Synchornize Spikekill with 1.2.x

* Removing Variance as it's not mathmatically correct

* Removing Variance as it's not mathmatically correct

* Properly re-draw graph
2026-02-03 12:02:39 -05:00
Browniebraun 932a2aca0e MidWinter .... Development still ongoing ... 2025-12-16 20:44:41 +01:00
Browniebraun e8115d34e4 MidWinter
- reduce padding (and line-height if inline help is not available) of formRow elements.
2025-07-22 11:33:31 +02:00
Browniebraun 13dbb364d2 MidWinter
- improve dialog layout
2025-07-13 08:37:19 +02:00
Browniebraun 115d9daebf MidWinter
- Elements on Top: Actions, Pagination as well as table title will stay on top
- introduce dialogues. (requires alignment with other Cacti core developers)
2025-07-13 07:39:22 +02:00
Browniebraun 46a4abf854 MidWinter
- fix control names in desktop view
2025-03-23 19:21:16 +01:00
Browniebraun 5fd1ab4f37 MidWinter
- colors - close to final.
- introduce sticky Container holding Table Title and Buttons.
2025-03-23 18:53:59 +01:00
Browniebraun d88d3acd30 reverting FontAwesome till better solution has been identified. 2025-01-15 23:04:14 +01:00
Browniebraun 5be7d7f18b Migrating icons from FontAwesome to Tabler 2025-01-05 20:58:36 +01:00
TheWitness 776f4bd864 QA: New core class and conserve real estate
* Need to compress the table space due to a few columns.
2024-12-01 15:31:29 -05:00
Browniebraun b082578f96 - feature advantage mode: new tooltips will remain within the borders of the image.
- feature: introduce tooltip orientation by class.
- fix: in quick mode zoom stopped while moving the mouse quickly into the opposite direction.
- fix: suppress livedata flickering while drawing the zoom areas.
2024-11-29 23:17:45 +01:00
Browniebraun 69318d4b6b - make MidWinter compatible with the latest table layout changes.
- change positioning to flex-start
2024-11-17 18:43:50 +01:00
Browniebraun cb59e9325f - prepare themes for live-data Zoom update 2024-11-17 18:02:12 +01:00
Browniebraun 9e3e219754 - MidWinter: change default font to Roboto. 2024-11-07 20:48:37 +01:00
Browniebraun c8d1cd9f9e - MidWinter: update zoomLevel on mouse movement, change it on release. 2024-11-06 16:18:39 +01:00
Browniebraun b4bce822f7 - fix missing scroll bar. ensure resetting affected containers as long as layout.js is directly injecting inline styles instead of using CSS classes. 2024-11-03 07:01:07 +01:00
Browniebraun 9330fcce8a - fix select2 menus in MidWinter after migration to layout.js 2024-10-20 22:25:58 +02:00
Browniebraun c97acd21ad - fix table header z-index issues with animated table gifs while scrolling 2024-09-29 07:56:58 +02:00
Browniebraun 8137a1711d - add animation support input search field within navigation boxes 2024-09-27 20:49:32 +02:00
Browniebraun 1fd4f73103 - change behaviour of navBoxSearch
- fix navBox menu before final replacement with jqueryUI menu()
2024-09-26 00:37:29 +02:00
Browniebraun 171d9954e7 - more modifications for MidWinter
- introduction of select2 emulation
2024-09-25 22:51:15 +02:00
Browniebraun 8f9512ecf8 - start with introduction of keyboard navigation
- small CSS button improvements
2024-07-21 20:37:39 +02:00
Browniebraun f6199ab2cf avoid that filter table content will be hidden by Cacti JS default action 2024-06-17 22:20:36 +02:00
Browniebraun 4cbaec2cf4 - hide CactiTableTitle and Button section if filter has been placed within a dock.
- Allow to show/hide passwords within login / password change.
2024-06-16 20:00:58 +02:00
Browniebraun 04cabc11e4 - last table column, text-alignment wrong 2024-06-07 06:26:31 +02:00
Browniebraun ea3298a044 - please note that this state of MidWinter is not fully functional. However, there is a ton of changes covered by this commit. 2024-06-05 23:22:39 +02:00
Browniebraun 11aeacb02a - Introduce table "inline scrolling" for better user experience. 2024-03-10 12:42:21 +01:00
Browniebraun 53709c17cf Improvements to MidWinter:
- fix breadcrumb navigation (open navigationBox + filter)
- fix breadcrumb colors
- replace breadcrumb separators by glyphs
- fix color for navigationBox search
- fix handling of individual navigationBox width
- introduce docks in main via grid layout
- introduce fixed table headers for better user experience while scrolling
- move table filters from right navigation box to docktop
- improve tab and table header highlighting
- introduce column reset button
2024-03-03 18:52:44 +01:00
Browniebraun 0b54540850 CSS improvements:
- more nestling & grouping
- navigationbox auto-resizing fully working
- replace table checkboxes by glyphs
- navigation boxes stay hidden during screen rotation.
- make formColumLeft & right flex containers to flip easily between row and column presentation for small screens.
- fix navigation content box scrolling when searchbox is visible.
- introduce a CSS reset.
- many stuff that I've already forgotten
2024-02-05 21:47:42 +01:00
Browniebraun 0cfec219e9 - more improvements for landscape / portrait mode
- make formRow's textarea and input fields responsive
2024-01-13 19:20:49 +01:00
Browniebraun 3ff7ee9878 start rebuilding MidWinter's portrait mode. 2024-01-06 13:45:27 +01:00
Browniebraun 64b395f16e more MidWinter updates 2024-01-01 20:12:24 +01:00
Browniebraun 5f6f65c215 - re-order CSS properties to default PHPStorm's default grouping
- classic mode
- proceed nesting and grid layout
2023-12-12 21:37:15 +01:00
Browniebraun 2fa5fe5531 - start moving from the classical layout approach to a CSS3 grid layout 2023-12-12 06:36:28 +01:00
Browniebraun 0529a37690 - fix width of saveRow in kiosk mode. start migration to native CSS nesting 2023-12-08 18:56:16 +01:00
Browniebraun 080e2245ea - first MidWinter CSS fixes for mobile view 2023-12-07 19:28:06 +01:00
Browniebraun 41d4c4bd99 just a CSS fixes:
- stop layout break within settings caused by an autofocus on right navigation bar.
- text alignment check box sliders had been lost
- wrong position attribute set for saveRow
- fix font-size of navigation search box.
- fix generic table column counts
2023-11-28 22:41:46 +01:00
Browniebraun d35224a33c - a few small css fixes (tree, save button row)
- switch form rows and columns to flex containers. For the first time, I see formheader collapse really animated.
2023-11-26 20:03:22 +01:00
Browniebraun afaf1c3e7b bring form action buttons to the foreground to avoid always scrolling down to the bottom of page. (table actions will be handled in a different way - this will be part of another commit later on) 2023-11-23 20:40:23 +01:00
Browniebraun 1369cf4803 - re-introduce mark.js and add search filter to the navigation Box model. the new search field will be handled separately in the scope of event functions and keeps its state individually. 2023-11-23 19:15:31 +01:00
Browniebraun 404dfd58c2 - bring console tooltip color inline with general color schema 2023-11-17 20:35:10 +01:00