admin/cacti
1
0 Fork 0
mirror of https://github.com/Cacti/cacti.git synced 2026-11-02 18:17:00 +09:00
Code Issues Packages Projects Releases Wiki Activity
16,265 Commits 65 Branches 85 Tags
develop
Commit Graph
157 Commits
Author SHA1 Message Date
Jing Chen 34c7079708 Cherry-pick two PR from 1.2.x branch (#5162) 2023-01-14 12:59:27 +00:00
Mark Brugnoli-Vinten 32ba2f19f4 Update copyright year for 2023 2023-01-03 20:34:26 +00:00
Mark Brugnoli-Vinten 8b29d12cc9 Define cacti system paths as constants for better code checking (#5120) 
This also provides a full run of src-fixer against all files to
ensure all code is now in alignment.

Closes #5120
 2023-01-01 01:03:15 +00:00
Mark Brugnoli-Vinten c8157e3cbb Switch to constants for common session/cookie options 2022-12-21 10:53:53 +00:00
TheWitness 3a387c053e Fixing #4896, #5102, #4951 Remote Offline Issues 
Porting these three fixes from the 1.2.x branch

* upgrading to 1.2.22 most of the plugins break in a multipoller setup
* When remote poller is in offline mode GUI inaccesible and poller times out
* When in Recovery Mode plugins that are designed to work remotely stop working
 2022-12-18 15:49:30 -05:00
netniV 2e1c16387f Make changelog more accessible for future feature changes 2022-11-26 23:23:07 +00:00
netniV 371f8b5253 Fix issues with backtracing and input validation (#3559, #3560) 
- When a developer uses backtracing, HTML output can be seen from command line bug confirmed
- When using `input_validate_xxx`, calls to `die_html_input_error()` do not pass variable name bug confirmed

Closes #3559
Closes #3560
 2022-11-26 18:28:29 +00:00
Mark Brugnoli-Vinten 6558b96eae Minor corrections 2022-11-26 16:51:23 +00:00
netniV cfd9f94371 Disable plugin hooks if plugin dependencies are also disabled #2767 2022-11-26 15:11:43 +00:00
netniV fd44f394a0 Remove the need for header=false 
Update loadPage calls to be loadUrl
Update loadPageNoHeader calls to be loadUrl calls

Also includes changes to make logout adhere to new html_auth_xxx functions
 2022-11-26 13:58:49 +00:00
TheWitness fbe340d973 Attempt to fix #4951 - Plugin Upgrades 2022-10-19 21:00:51 -04:00
TheWitness 2ee16e95e6 Another attempt at #4932 2022-09-24 16:50:03 -04:00
TheWitness cf2ca15256 Second update to #4932 2022-09-24 16:45:11 -04:00
TheWitness 28ec4692fa Fixing #4932 - Too many calls to plugin table 2022-09-24 15:34:54 -04:00
TheWitness 76e095be1b QA: Auto-disable from error too severe 2022-03-15 20:49:13 -04:00
TheWitness a777a75080 QA: Unable to install plugins due to replicate issues 2022-03-14 10:21:19 -04:00
TheWitness bcddab8447 QA: Per comments on #4614 
- Relocating the $plugin parameter to the end
- Adding a warning if someone is using it externally
 2022-03-14 08:38:21 -04:00
TheWitness b561568852 Fixing Issue #4617 
Dropping remote tables not supported in plugin API
 2022-03-13 19:43:01 -04:00
TheWitness 5b49db4586 Fixing Iseue #4616 - Plugin Replication Issues 
- When performing plugin actions from the Cacti UI, replication should be forced to Remote Collectors
- max_packet was not being calculated correctly.
- Cacti log function logging on verbosity NONE
 2022-03-13 19:32:01 -04:00
TheWitness 60baee04d9 Removing obsolete poller_command_args hook check 2022-03-13 16:18:01 -04:00
TheWitness 3ac42ebe46 Fixing Issue #4614 
- Cacti can not differentiate between execution remotely between the main poller loop vs. poller bottom
- Also QA including, better logging
- One Hooks in wrong section 'cacti_stats_update'
- I've noticed two hooks that are no longer in Cacti.  Need to see when they were removed 'poller_output' and 'poller_command_args'.
 2022-03-13 16:14:09 -04:00
TheWitness da4b7ba0f8 Second attempt at #4598 - Offline Tabs 2022-03-10 08:01:40 -05:00
TheWitness 335575c5a4 Fixing Issue #4598 - Remote Tab Visibility 
Plugin tab does not stay visible when main poller is offline
 2022-03-09 21:09:25 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness 0046763ab9 Fixing Issue #4539 - Dependency Message Incorrect 
Broken handling of plugin dependencies in 1.2.19
 2022-01-31 18:30:40 -05:00
TheWitness 63e1998aab Minor update related to #4390 
This allows $ret calls that were initially empty to not trigger an error.  This was applicable for the graph refresh hook that, if the user has no default setting, will initialize as null.
 2021-09-08 18:55:52 -04:00
TheWitness 888707aeca Fixing Issue #4390 - Add Plugin Chaining Warnings 
The plugin API should detect when plugins are not behaving properly with return variables required for chaining
 2021-09-06 12:28:47 -04:00
TheWitness 557f89bd67 Revert "Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x" 
This reverts commit 0b597f61cb, reversing
changes made to b062b2bb57.
 2021-01-26 19:48:30 -05:00
browniebraun 20e6223f6d Revert "Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x" 
This reverts commit 7e0da80345, reversing
changes made to 3ee16196ef.
 2021-01-26 19:09:33 +01:00
TheWitness e6258b6d8b Two additional boost optimizations 
- Do not overcall the plugin hook DB calls, or checking for rrdtool version in a single script instantiation repeatedly
 2021-01-25 12:54:36 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness c57a066226 Additional changes around #3985 
* Doing collate and charset as separate transactions
 2020-12-19 12:15:15 -05:00
TheWitness b2fce0ac75 Fixing Issue #3985 
Update database library function to properly handle collate
 2020-12-05 10:38:54 -05:00
TheWitness f86360fa96 Minor fix to #3977 2020-12-03 18:51:38 -05:00
TheWitness 1c9f332794 Fixing Issue #3977 
Cacti CLI upgrade_database.php misses constant IN_CACTI_INSTAL which may result in upgrade failures
 2020-12-03 08:34:54 -05:00
TheWitness 7fe7bbb693 Fixing Issue #3963 
Plugin table creation function misses the table collation setting
 2020-11-28 11:11:59 -05:00
TheWitness fc6ffc337a Remove warnings removing plugins 
When removing plugin entries from plugins that no longer exist in the plugin management area during upgrade generate warnings.
 2020-10-29 10:48:41 -04:00
TheWitness 74bf30cd1e Fixing Issue #3883 
No way to remove integrated/orphaned Plugin references from the Plugin Management interface
 2020-10-24 10:32:49 -04:00
ddb4github 61b8481fa7 Plugin realm files can not be updated by re-register due to delimiter typo (#3512) 2020-04-29 14:22:42 +01:00
ddb4githubandJing Chen 2dcc79763f More fixing for #2428 (#3460) 
* Fixed#2428: More fixing to impl:
	- plugins.php display name: info->name(<>lower(info->name)) > ucfirst(info->name)
	- plugin_xxx->directory is always directory name on disk.

* Update CHANGELOG for PR #3460

Co-authored-by: Jing Chen <three_chenjing@sohu.com>
 2020-04-16 15:16:21 -04:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 57ef005ed3 Resolving Issue #2877 
Problems sending reports
 2019-08-15 22:38:23 -05:00
cigamit e4b8770855 Revert "Resolving Issue #2786" 
This reverts commit 02e8c75e3b.
 2019-07-01 17:46:28 -05:00
cigamit 02e8c75e3b Resolving Issue #2786 
A non-numeric value encountered in \lib\plugins.php on line 930
 2019-07-01 17:33:46 -05:00
cigamit 492b3f8919 Resolving Issue #2744 
Undefined index: password_change in auth_changepassword.php
 2019-06-23 10:17:13 -05:00
Petr Macek 0710d27bc5 fix MySQL (8.0.1) reserved word function (#2736) 
* fix mysql (8.0.1) reserved word function

* resolving issue #2736
 2019-06-22 21:31:55 +08:00
netniV 6108e8759d Further resolve #2513 2019-03-13 16:35:57 +00:00
netniV 086b5c78df Resolving issue #2513 
When a plugin INFO file is malformed or missing elements, plugin_load_info_file() should fill missing elements with defaults which are now defined as:

'name'      => directory holding info file
'requires'  => blank
'longname'  => directory holding info file (first letter is uppercased)
'status'    => 0
'version'   => 0.0
'author'    => 'Unknown'
'homepage'  => If webpage is set, use that otherwise 'Not Stated'
'directory' => directory holding info file

This will ensure consistency and that any attempts to use a key such as requires will be present.
 2019-03-13 13:17:15 +00:00
cigamit 7b6e3a403e Resolving Issue #2326 
Due to issues reported in the thold plugin
 2019-02-09 09:32:59 -06:00
cigamit edc736d871 Additional fixes for Issue #2326 
This allows the row format to be dynamic only when the
innodb_file_format is Barracuda, and corrects a bug in detecting MySQL
vs. MariaDB in the version string.
 2019-01-26 09:42:37 -06:00