8 Commits
Author SHA1 Message Date
7ca0582b3c Refactor Perl scripts with Code Quality findings (#6594)
* add perl syntax checking for scripts

* Update .github/workflows/syntax.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* only show syntax errors

* Add support for ss

Fixed shell injection risk from piped netstat | grep by removing shell pipelines.
Added use strict; use warnings; and localized variables.
Added runtime fallback to ss when netstat is unavailable, with a clear failure when neither exists.

* Fix shell injection risk

apply fixes (safe open, strict/warnings, key whitelist, error handling).

* Update query_unix_partitions.pl

* Update unix_users.pl

add use strict/warnings  to flag issues
add better error handling

* Update weatherbug.pl

* add better suport for gree bsd

* Update loadavg.pl

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
2026-01-31 20:25:42 -05:00
Alex b3a070fe49 Resolving Issue #1889 (#1900)
$ENV{ENV} which running on FreeBSD
2018-09-07 06:08:36 -05:00
cigamit 7970b871fe Resolving Issue #1889
Insecure $ENV{ENV} which running setgid
2018-09-06 21:31:00 -05:00
Tony Roman 6c0cca5942 bug#0000656: Perl scripts using back ticks is not portable
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/branches/BRANCH_0_8_6/cacti@3439 860744bd-22fc-0310-8c96-e9fe5004b5ca
2005-12-21 02:56:49 +00:00
Ian Berry d5ad93b9fa long mount point bug (bug#67)
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/trunk/cacti@1094 860744bd-22fc-0310-8c96-e9fe5004b5ca
2003-07-09 19:34:35 +00:00
Ian Berry b6de8a791c got rid of percent sign in output, removed some \r's (bug#34)
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/trunk/cacti@864 860744bd-22fc-0310-8c96-e9fe5004b5ca
2003-04-18 02:20:18 +00:00
Ian Berry 87de6aa496 making scripts compliment with 0.8 output structure
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/trunk/cacti@535 860744bd-22fc-0310-8c96-e9fe5004b5ca
2003-02-17 08:39:38 +00:00
Ian Berry eb59dd520f Initial revision
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/trunk/cacti@2 860744bd-22fc-0310-8c96-e9fe5004b5ca
2002-05-18 20:29:57 +00:00