* Cacti scores low on performance audit on lighthouse audit
* This change enables generic caching of pages, but with a very short age for RRDtool generated graphics.
* It increses the SEO score through the use of specialty tags on anchors leveraging the _blank target attribute value
* It removes and unnecessary tooltip on the document element
There may be additional changes forthcoming. However, these changes raised the score from 0 to the mid twenties.
Some of the changes, like minification of JavaScript we do not do due to the nature of the project, but could be done by customers. Once the page is first rendered, it's in the browsers memory and cached for a good time, so this is not a big deal.
* Fixed: #2964 to add missed argv for all rrd_function_graph caller
* Fixed#2964: Apply security solution to aggregate graph preview and graph impage page
* CVE-2019-16723 Security issue allows to view all graphs
* Thischange restores the check inside of lib/rrr.php and updates all but on calling of the graph function to include the user.
- suppress lines breaks breaking graph output if error reporting level is high.
- avoid that remote pollers are requesting graphs from the main poller if the RRDproxy will be used as data storage. In this case remote pollers should directly talk to the proxy.
There are still three steps to go in this overall. The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized. Note, at this point the
develop branch should be thought of as slightly unstable
this is part three of project to remove the use of $_GET, $_REQUEST, and
$_POST in the code. Parts one and two have already been completed.
Part one was to remove the use of $_GET throughout the code, part two
was the incorporation of wrapper functions to handle specific
validation, verification and sanitization cases. This third part will
remove the use of the get_request_var_request() from the code. Part
four, and beyond will include the removal of both $_REQUEST and $_POST
super globals from the code.
When creating new graphs graph_json throws an error and spikes CPU.
[Sat Jan 30 00:06:27.947764 2016] [:error] [pid 44971] [client :64833] PHP Fatal error: Maximum execution time of 30 seconds exceeded in /var/www/html/cacti/graph_json.php on line 143, referer: http:///cacti/graph_view.php
This is until the graph has been created and can be found.
Changed it to check for a RRD and if not found set a placeholder image. Code doesn't loop anymore.
Mark Brugnoli-Vinten