admin/cacti
1
0 Fork 0
mirror of https://github.com/Cacti/cacti.git synced 2026-10-29 16:17:14 +09:00
Code Issues Packages Projects Releases Wiki Activity
13,652 Commits 69 Branches 85 Tags
main
Commit Graph
321 Commits
Author SHA1 Message Date
TheWitness c59b6b9b4d Fixing #5475 - Issue with ss_fping.php and PHP8 strict typing (#5477) 
* QA: Broken Function

* QA: Two additional QA Items

- Do a check for IP address as dns_get_records() does not have a timeout and I don't use DNS
- Properly display information about MariaDB 11.

* Fixing #5475 - Ping Issues with Advanced Ping an PHP8

PHP 8.x error - Unsupported operand types: float + string

* QA: Fix two typos
 2023-09-03 08:04:53 +01:00
TheWitness 54655a0fe2 QA: Update our defaults for Image Size and Rendering Mode 
* This should have been done a long time ago.
 2023-08-20 10:10:41 -04:00
Mark Brugnoli-Vinten 63887c315c Rows Per Page - Not all options are available (#5413) 
Closes #5413
 2023-07-23 11:11:06 +01:00
netniV 6fd07fcea6 Device form location drop down not populating (#5347) 2023-06-09 21:47:44 +00:00
TheWitness f9816fed45 Fixing #5238 - SQL Issues due to non-visible chars (#5240) 
Fixing #5238 - SQL Issues due to non-visible chars
Fixing #5232 Poller Stacking
Fixing #5236 - Edit Graph Template
Fixing #5243 - Export columns missing
 2023-02-20 00:40:44 +00:00
TheWitness 1c314f3c42 QA on #5214 - Basic Auth 
Don't give the users the auto-logout setting when using basic auth.
 2023-02-06 08:46:16 -05:00
Mark Brugnoli-Vinten d2a94dc3b3 Update copyright year for 2023 2023-01-03 22:46:09 +00:00
TheWitness f4cc94106d QA: Case and cacti.pot 2022-12-17 15:36:38 -05:00
TheWitness 6f4780389c Fixing #3578 - Automatic Reindex 
Scheduled Automatic Re-indexing of Devices
 2022-11-17 20:30:45 -05:00
TheWitness 757fa895c5 Fixing #4926 - Client TimeZone support 
Allow the user to override Cacti auto-client time zone detection
 2022-11-12 11:33:16 -05:00
TheWitness 8ecca4bba0 QA: Some spelling changes 2022-11-05 21:04:44 -04:00
TheWitness 3ffe28be10 QA: Two minor issues 2022-11-01 22:22:55 -04:00
Petr Macek c22121e13d Fix4639 - add rrdcheck (parallel process) (#4943) 
* fix#4639

* fix useless multiple file process

* changelog and formatting
 2022-10-07 07:29:15 -04:00
TheWitness cb94c77e15 QA: Spelling issue with Graph Settings 2022-09-18 16:42:31 -04:00
thurbanThomasUrban@urban-software.deTheWitness
 		b13709ca66 Added support for showing business hours (#4878) 
* Added support for showing business hours

* Added feature to limit display of business hours

Co-authored-by: ThomasUrban@urban-software.de <rJFsmBR9!15UGZB%G7uc>
Co-authored-by: TheWitness <thewitness@cacti.net>
 2022-08-18 08:14:28 -04:00
TheWitness ca2a654c8e Fixing #4892, #4890, #3131 - Re-index options 
Issue #3131 has been available through the Edit Device interface for some time.  So, marking that complete.  The other two address first a bug in 1.2.22 with the removal of re-index records from the poller_command table, and introduces parallel processing to the whole re-index game.
 2022-08-18 08:00:00 -04:00
TheWitness 15b096bc32 Add two new methods to #4533 Structured Paths 
- In my case, I would still have too many base directories.  So, this change will add a third possible level to spread out files within the file system.
 2022-08-09 18:46:16 -04:00
TheWitness 6c07b0465e Fixing #4882, #4881, #4880, #4533 - Boost and Structured Paths 
This change adds two features, and corrects some minor bugs:

* issue#4880: The MySQL get_lock() function can lead to stalled boost and dsstats processes
* issue#4882: Under rare conditions the boost process can get hung until the poller times out
* feature#4533: Restructuring RRDfile paths takes too long on large systems and will stop polling for potentially several hours
* feature#4881: When boost is running, it's not clear which processes are running and how long they have to complete
 2022-08-07 16:39:24 -04:00
thurbanThomasUrban@urban-software.deTheWitness
 		d2e12bbef1 Added Gradient Color support for AREA charts (#4870) 
* Added Gradient Color support for AREA charts

* Added Gradient Color support for AREA charts

* Minor formatting changes php-doc formatting

* Light formatting

Co-authored-by: ThomasUrban@urban-software.de <rJFsmBR9!15UGZB%G7uc>
Co-authored-by: TheWitness <thewitness@cacti.net>
 2022-07-20 18:08:13 -04:00
TheWitness 9469a3f33f More Changes to #4287 - Help (#4845) 
* More Changes to #4287 - Help

This change does a few things:

- Make a new setting to force either local or use docs.cacti.net
- Move response to JSON so we can create messages in HTML
- More selective messages depending on the error
- Updates language files again

* Updates after feedback

* Update help.php

* Update layout.js
 2022-06-29 20:47:55 -04:00
Josh SorefandJosh Soref 12ffd6bc7b Multiple Spelling Issues in Cacti (#4792) 
* spelling: about

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: accommodates

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: account

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: acquire

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: across

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: actual

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: addition

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: administrative

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: agent

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: algorithms

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: amongst

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: anchor

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: appropriate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: archive

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: arguments

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: assuming

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: asynchronously

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: attachments

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: attribute

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: availability

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: behaves

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: being

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: branch

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: calculate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: callback

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: case of

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: certainly

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: changes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: characters

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: coalition

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: column

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: configuration

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: confirm

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: connect to

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: consistently

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: containing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: convert

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: corrected

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: current

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: data

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: datasource

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: default

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: delimited

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: delimiter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: deprecated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: description

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: destination

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: determines

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: device

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: devices

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: diagnosing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dimensional

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: directory

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: disabling

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: distribution

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: documentation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dynamically

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: embedded

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: enough

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: especially

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: everything is

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: everything

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: example

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exceeds

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exclude

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: existence

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: explicitly

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exported

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extract

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extraneous

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: failed

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fails

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fallback

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fashioned

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: field values

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: foreground

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: format

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: function

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: functions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: gauge

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: get

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: global

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: graph

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: gzipped

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: hierarchy

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: identify

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: immediately

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: increase

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: increment

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: indexes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: inefficient

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: inherited

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: initialize

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: installation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: insufficient

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: irrelevant

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: label

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: latest

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: leaves

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: local

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: location

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: lockout

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: logging

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: manually

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: menus

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: minimum

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: modifiable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: multi

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: multiple

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: mutually

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: naturally

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: navigation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: necessary

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: network

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: number

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: occurrences

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: only

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: output

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: overridable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: overridden

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: override

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: package

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: parameters

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: perform

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: performing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: permanently

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: permission

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: piece

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: plugin

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: prevent

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: programmatically

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: propagated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: purpose

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: purposes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: push

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: queries

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: refresh

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: relevant

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: remainder

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: repetitions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: representing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: reserved

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resetting

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: response

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: responsible

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: results

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: retrieve

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: routines

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: running

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: section

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: separate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: sequences

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: session

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: settings

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: setup

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: snmp

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: some

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: specific

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: specification

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: specified

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: stacked

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: statistics

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: string

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: structure

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: structured

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: successful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: successfully

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: suggested

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: suppress

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: suppresses

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: switches

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: synchronization

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: synchronize

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: table

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: temperature

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: template

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: temporary

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: textarea

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: the

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: themselves

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: therefore

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: thoroughly

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: through

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: time

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: timed

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: timespan

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: tries

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: true

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: uninstall

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unless

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unlocks

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: up to

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: update

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: updating

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: useful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: utility

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: variable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: version

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: visibility

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: what is

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: when

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: whether

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: written

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2022-06-19 08:52:20 -04:00
TheWitness 8f33e4b648 QA: Selective Debug on Plugins not ordering alphabetically 2022-03-20 15:16:32 -04:00
TheWitness 8cf3cecdc1 Fixing Issue #4621 - RRDtool i18n 
RRDtool Graph Internationalization does not work as expected on RRDtool versions above 1.5
 2022-03-14 20:13:46 -04:00
TheWitness 5d1b8e6183 Fixing Multiple Bugs and one Feature #4576, #4579, #4573, #4575, #4577, #4578, #4574 
-security#4576: Stored XSS Issue in Cacti Device, Graph, Graph Template, and Graph Items callbacks
-security#4579: Cacti account lockout policies are not properly applied to LDAP and Domain Users
-issue#4573: The Cacti permission system does not scale to very large installations
-issue#4575: When you delete a user, their 'remember me' cookie data is not automatically removed
-issue#4576: Stored XSS Issue in Cacti Device, Graph, Graph Template, and Graph Items callbacks
-issue#4577: Cacti allows you to disable the currently logged in administrator disabling the user
-issue#4578: The Cacti login algorithm is complicated to understand due to too much strait line code
-feature#4574: Cacti needs some additional permission methods for larger installations

This change properly documents the file lib/auth.php using phpDocument format, and performed multiple sanity and readability changes such as the renaming of variables commonly used in multiple functions.

The the restructuring of the three authentication files:

- auth_login.php
- include/auth.php
- lib/auth.php

Makes the code more readable, it's not a complete solution, however, it is much easier to follow now.
 2022-02-27 15:26:28 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness aae896cab8 Fixing #4547 - LDaP Connection Backtraces and add LDAP Debug mode 
- Testing with LDAP authentication generating backtraces
- Add LDAP Debug Mode option for testing LDAP specific connection issues
 2022-02-06 12:11:54 -05:00
TheWitness 744797f720 Minor widen LDAP DN text fields for long domains 
Don't need a change log on this one.
 2022-02-06 11:12:21 -05:00
TheWitness c515bb50f8 Fixing Issue #4545 Reports User is always an admin 
- Reports Tab always shows 'Administration' despite a users permissions
- Improves the caching of permissions to include both true and false to reduce page query load.
- Also short circuits is_realm_allowed() for CLI's
- The user and admin realms where flipped.
 2022-02-05 21:54:08 -05:00
TheWitness f6f44ee5cc Feature: Expose the Hidden Language Processor 
This variable always existed, but was never exposed.  This change will expose that setting and cleanup a bit of the variable definitions.  We've gone between l10n and i18n in various areas of the API, and moving everything to i18n now too.
 2022-01-29 16:41:18 -05:00
TheWitness a108a6ec16 Fixing Issue #4536 - Basic Auth Issues 
* After authenticating via Web Basic Authentication, user always mapped as guest.
* This is a slight redesign to make provide a better flow.  It will require rework to merge back to develop.
* deprecated use of display_custom_error_message()
* Add custom error message for basic authentication
* Fix some display issues on the settings page related to new settings.
* Make it clear in the cacti.log that LOGIN messages are failed or otherwise.
 2022-01-29 15:03:44 -05:00
TheWitness 9f27a24e5f Fixing Issues #4495 and #4500 DSStats Issues 
* DSStats Does not Scale on Large Systems
* DSStats will get invalid data for some devices after reboot requiring purging of stats

This is way less than what I want to do, but these are all essentially bugs.

There is also a change to lib/boost.php to provide better debug logging when testing.
 2021-12-10 10:58:45 -05:00
TheWitness ceb98d4a17 Fixing #4445 - Adding ldap timeouts 
LDAP API lacks timeout options leading to bad login experiences.  Domains will use the global setting for now.
 2021-10-26 08:34:04 -04:00
TheWitness 4265c54491 Fixing Issue #4299 - Multiple LDAP servers 
Allow Cacti to use multiple possible LDAP servers
 2021-10-18 20:48:41 -04:00
TheWitness 5a1de9efdf Fixing Issue #4409 - Test Data Sources Optional 
* When creating a Graph, make testing the Data Sources optional by Template
* Release preparation steps
 2021-09-25 14:13:40 -04:00
netniV 283c2ab76f Fixes for #4324, #4325, #4326 
issue#4324: Date/Time format of replacement fild on graph cannot be changed
issue#4325: Make identifying rows when editing graph items easier
issue#4326: When using large lists, selection is visible in dropdown menus
 2021-06-27 20:43:13 +00:00
TheWitness 12affbca13 Fixing Issue #4279 - Device Threads setting off by one 
Default Setting "Device Threads" will not be saved correctly
 2021-06-25 15:55:11 -04:00
netniV 1c3c4bf142 If a page contains multiple tables, a larger table can cause small ones to lose columns (#4295) 
Closes #4295
 2021-06-09 02:58:11 +00:00
TheWitness 514cbe3086 Increase number of boost processes 2021-04-14 08:46:34 -04:00
TheWitness 3e9a876d10 Do not show the auto-logout if session cookies are enabled and in use 2021-04-08 09:16:16 -04:00
TheWitness 6047c36c3a Fixing Issue #4199 - Stop Realtime from Gapping Graphs 
Allow Cacti administrator to define a min refresh interval to prevent graph gaps
 2021-03-26 21:43:24 -04:00
Datatech UK LtdandTheWitness 72430ad14e Add ability to set how long a user can stay logged in before being au… (#4113) 
* Add ability to set how long a user can stay logged in before being automatically logged out

* Update CHANGELOG

* Changed the option in the drop-down to Default rather than Never to avoid confusion

* The auto logout time can not be greater than gc_maxlifetime

* Setting maximum value as 4 Weeks as this is the maximum that session.gc_maxlifetime will allow

* Fixed login loop if no value set on Auto Log Out Time

* Removing debate on the argument.

* Update global_settings.php

* Wrong Realm

* Secondary check

* Update global_settings.php

Co-authored-by: TheWitness <thewitness@cacti.net>
 2021-03-25 07:52:57 -04:00
TheWitness 07b95c6cbc Fixing Issue #4184 - Error logging in cmd.php 
- cmd.php error response logging is not properly following the detailed/summary logging setting
- This is basically a rewrite of the cmd.php that makes it much easier to read, and actually makes it 2x faster than previous versions.
- Change the 'tics' behavior to not loop so hard watching for signals.
- Makes the snmp session data passing more reasonable
- Like spine, if a host times out when attempting to fetch and OID, the remainder of the host will be skipped, resulting in a more reliable performance as well.
 2021-03-20 11:15:30 -04:00
TheWitness 020165669a Fixing Issue #4086 - Large System Performance 
- Large system performance negatively impacted due to $spikekill_templates behavior
 2021-01-23 10:41:42 -05:00
TheWitness c4ba292b49 Fixing Issue #4075 
- LDAP Settings lead to confusion when setting up LDAP authentication
- This is a fairly large consolidation of code blocks.
 2021-01-21 18:59:25 -05:00
TheWitness c53e406c7d Revert "Add ability to set how long a user can stay logged in before being au… (#4064)" 
This reverts commit 8bc3c2b13d.
 2021-01-21 07:38:28 -05:00
Datatech UK LtdandTheWitness 8bc3c2b13d Add ability to set how long a user can stay logged in before being au… (#4064) 
* Add ability to set how long a user can stay logged in before being automatically logged out

* Update CHANGELOG

* Update global_session.php

Co-authored-by: TheWitness <thewitness@cacti.net>
 2021-01-20 18:13:33 -05:00
TheWitness f2df734dc6 Update one poller setting 
This is so that the setting is consistent with the documentation and the purpose of the setting.
 2021-01-10 10:58:05 -05:00
TheWitness 30245180d8 Align Settings page with Doco 
- Minor settings reorganization to align with doco
- Also change indentation to follow standard
- Some whitespace conversion to tabs
 2021-01-09 13:39:06 -05:00
TheWitness bc632bc30d Fixing Issues #3945 and #4031 
* Graph CSV export NaN with wrong date range if browser timezone is different with web server
* Data Collectors and Data Profiles Filter Sub-Panel Go buttons not working as expected
 2021-01-04 20:25:14 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00