Some of the lighthouse audit results are invalid. The main console has a score of 95 now, and other pages 82, but when reviewing the results, there is only one failing test, which there is no real good solution for at the moment.
We can almost collapse all headers into a single call now. There is a
currently a problem with the Dark and Modern themes the first time you
switch to preview. On the first page. This was a bit of a hack since
the cactiContent object was not being parsed correctly by jQuery.
* issue #1292: Fix issues with browser caching of javascript and css files
* Removing unnecessary variable set.
* Minor changes to format and syntax
Use return and not echo, minor spacing changes.
Issues with mobile graph viewing. This introduces a small amount of
Javascript based responsiveness to the filters, and to menu navigation.
Tables will be next.
There are still three steps to go in this overall. The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized. Note, at this point the
develop branch should be thought of as slightly unstable
this is part three of project to remove the use of $_GET, $_REQUEST, and
$_POST in the code. Parts one and two have already been completed.
Part one was to remove the use of $_GET throughout the code, part two
was the incorporation of wrapper functions to handle specific
validation, verification and sanitization cases. This third part will
remove the use of the get_request_var_request() from the code. Part
four, and beyond will include the removal of both $_REQUEST and $_POST
super globals from the code.
Mark Brugnoli-Vinten