909 Commits
Author SHA1 Message Date
TheWitness e83805604d QA: Fixing #5469 bad use of trim
Trimming a null string is deprecated
2023-08-25 06:45:57 -04:00
TheWitness 5285686592 Fixing #5467 - Cacti Log issues in certain circumstances
Cacti logging throws error when attempting to generate a log message from empty log string in PHP 8.x
2023-08-24 08:15:12 -04:00
Petr Macek 28b8db5a36 user settings - column name extension (#5444) 2023-08-11 05:50:38 -07:00
Petr Macek a518cdd563 settings - column name extension (#5442) 2023-08-11 05:34:37 -07:00
Jing Chen 35d76a87d1 Fixed: create a new function cacti_unserialize to cover all raw unserialize function compatible usage (#5438) 2023-08-09 04:42:11 -04:00
TheWitness f259dcce69 Fixing #5417 - BCC contents in Cacti.log
Cacti mailer log message misses 'bcc' addresses in log notification
2023-07-23 13:20:42 -04:00
TheWitness 5c1b8aff83 Fixing #5403 - Regular Expression Negation
Cacti Log regular expression filters can not calculate 'does not match' properly
2023-07-15 12:34:55 -04:00
TheWitness 23abb0e0a9 QA: Minor rework to #5324 - XSS Issues
Missed a few untranslated strings in addition, ensured bot the log insert and the query_debug_timer functions were covered.
2023-06-17 18:01:26 -04:00
netniV f5ecdb0e32 Plugin missing functions warning should be debounced (#5360) 2023-06-08 23:27:15 +00:00
TheWitness f66ed84ee2 Fixing #5324 - Over Escaping Debug log
This is an issue between releases due to escaping log entries in the wrong location in the security fix.  This change resolves that issue.

Reindex device from GUI - debug info broken due to over escaping
2023-06-04 12:28:26 -04:00
TheWitness f073496d21 Partial fix for #5336 RRDtool updates
RRDtool update failures when Data Template data sources don't match Graph Template data sources in use
2023-06-03 15:52:29 -04:00
Mark Brugnoli-Vinten 6bfd783bf1 Minor fixes trying to see what's up with GitHub checks 2023-06-02 11:13:30 +01:00
Mark Brugnoli-Vinten a0bd1deeec Remove typing from 1.2.x 2023-06-01 20:20:04 +01:00
Mark Brugnoli-Vinten dabfeb4f0e Fix PHP 5.4 issue with coalsce operator 2023-06-01 20:17:00 +01:00
Petr Macek cd2f5d009e fix rekey, returning back kill_session_var changes (#5345) 2023-06-01 20:07:44 +01:00
Mark Brugnoli-Vinten 1be623b3ea Some minor QA fixes to make VSC happy 2023-05-29 11:13:21 +01:00
TheWitness 976f44dd8d Fixing #5317 - Data Source Info Issues
Data Source Info Mode produces invalid recommendations
2023-04-29 14:44:05 -04:00
Jing Chen cf1033670a Fix unserialize usage for PHP pre-7.0 (#5304) 2023-04-15 10:42:44 -04:00
TheWitness 39b006864e QA: Minor typo discovered while porting 2023-04-01 11:37:03 -04:00
TheWitness 7e27e032b8 Fixing #5283 - Warning in Cacti log
Trying to access array offset on value of type null in file lib/functions.php on line: 2276
2023-03-30 17:42:05 -04:00
TheWitness c6507a4c07 Fixing #5263 - Warning in Cacti log
Warnings in Cacti log when re-indexing devices
2023-03-08 18:32:08 -05:00
TheWitness 8c6cd77001 QA: Add additional security to the unserialize function (#5245)
Fixing #5238 - SQL Issues due to non-visible chars
Fixing #5232 Poller Stacking
Fixing #5236 - Edit Graph Template
Fixing #5243 - Export columns missing
Fixing Issue #5239 - Automation SNMP Bulk Size
Fixing #5241 - Polling distribution not working
Fixing #5247 and QA on #5241 - Polling Issues
2023-02-24 03:45:11 +00:00
TheWitness f9816fed45 Fixing #5238 - SQL Issues due to non-visible chars (#5240)
Fixing #5238 - SQL Issues due to non-visible chars
Fixing #5232 Poller Stacking
Fixing #5236 - Edit Graph Template
Fixing #5243 - Export columns missing
2023-02-20 00:40:44 +00:00
netniV bf5f5d9c95 Force proxy headers to be set, or assume none 2023-02-15 11:00:54 +00:00
TheWitness cdd6902973 Fixing #5200 Tab Images Warnings
Cacti function throws errors when attempting to render classic images in PHP8
2023-01-27 17:05:17 -05:00
TheWitness 22d96d092c Fixing #5199 - fgets errors
Failures to call fgets generate errors in the Cacti.log
2023-01-27 15:47:51 -05:00
TheWitness 5671dcd9f1 QA: Fixing #5186 - Fatal array_intersect error
1.2.24 - QA: Fatal exception when processing proxy headers
2023-01-22 10:33:27 -05:00
TheWitness c3eee4f3e6 More corrections for #5169 - Fail date logic
Host table status_fail_date and status_rec_date can appear wrong
2023-01-16 10:40:23 -05:00
TheWitness 206e79d078 Fixing #5169 - Recovery date wrong
Host table status_fail_date and status_rec_date can appear wrong
2023-01-16 10:35:19 -05:00
TheWitness f8399c8aaa QA: Attempt to fix #5147 - Debian install 2023-01-07 13:12:19 -05:00
Mark Brugnoli-Vinten d2a94dc3b3 Update copyright year for 2023 2023-01-03 22:46:09 +00:00
TheWitness a8b3d12565 Fixing #5089 - Validation backtrace issues
When numeric regex validation fails, not backtrace message is logged in the Cacti log
2022-12-18 14:45:18 -05:00
Jing Chen d3675f9f3d Fixed two files (#5077) 2022-12-12 11:53:37 +00:00
Mark Brugnoli-Vinten 651f332d88 QA: web installer not working (#5070) 2022-12-10 03:11:24 +00:00
TheWitness b4de55643a Light QA on #5041
Wrong log class
2022-12-08 06:58:13 -05:00
TheWitness 052a840403 Fixing #5041 - File exists warnings
md5_file error in custom theme after updating to 1.2.23
2022-12-08 06:52:20 -05:00
netniV a8d59e8fa5 Correct issue with PHP 5.4 2022-12-05 08:50:36 +00:00
Mark Brugnoli-VintenandTheWitness 7f0e16312d Merge pull request from GHSA-6p93-p743-35gf
* Resolving  CVE-2022-46169

* QA: Provide a restrictive option

* QA: Further restrict allowed headers to those defined in config only

Co-authored-by: TheWitness <thewitness@cacti.net>
2022-12-05 08:41:01 +00:00
TheWitness b669459a89 Fixing #5033 Deprecation Warnings
Installer shows deprecated messages on PHP 8.1.2
2022-12-04 12:48:22 -05:00
TheWitness ec77ebc46e QA: Provide a stricter get_client_addr() function 2022-12-03 14:16:08 -05:00
TheWitness cacb96662a QA: Take a different approach for device status cache 2022-12-01 18:43:58 -05:00
Mark Brugnoli-Vinten 98716723f5 Update check_all_pages to allow options to adjust checks 2022-11-30 13:53:08 +00:00
TheWitness 27a36d48e1 QA: Add missing function for packaging 2022-11-27 18:57:51 -05:00
TheWitness 9bbb3e39b7 Fixing #5018 - Unexpected auto-logout
It is possible in some rare cases to have 'remember me' enabled and still be logged out after a browser timeout
2022-11-24 13:09:24 -05:00
TheWitness 0ae35422cc QA: #4926 - One missed change
This missed change will reconcile any issues with client timezone support.
2022-11-23 18:58:46 -05:00
TheWitness ef85619a37 QA on #4989
Add device caching options for changing state
2022-11-20 13:28:40 -05:00
TheWitness 17495a4d09 Add additional ignore handler
For for MikroTik fsockopen() calls
2022-11-20 13:22:15 -05:00
TheWitness a28d4e45d5 QA: In "clean_up_*" functions 2022-11-20 13:16:55 -05:00
Jing ChenandTheWitness 546d002c7b Fixed three error for PHP 8 when execute cli/upgrade_database.php (#5012)
* Fixed: get_rrdtool_version report str_replace error if rrdtool_version does not exist
Fixed: move global static $phperrors before other error-able function call
Fixed: file_exists report error if path_spine is not configured

* Fix PHP5.4 Error

Co-authored-by: TheWitness <thewitness@cacti.net>
2022-11-20 13:10:17 -05:00
TheWitness 757fa895c5 Fixing #4926 - Client TimeZone support
Allow the user to override Cacti auto-client time zone detection
2022-11-12 11:33:16 -05:00