Commit Graph
270 Commits
Author SHA1 Message Date
cigamit f7f025e6ae Finish resolution of Issue #756
Translation Issues
2017-06-03 20:15:52 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
Patrick c01aec3836 Translations:
- Fixed some translation issues
- Updated dutch translations
2017-05-09 19:15:22 +02:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
Patrick b154c3e89e Optimisations for tree view
lib/auth.php:
- is_device_allowed()
  - removed unused parameter $user
- get_allowed_tree_level()
  - removed unused parameter $user
- get_allowed_tree_content()
  - removed unused paramters $sql_where, $order_by, $limit, $total_rows and $user
  - refactored the code to apply for these unused parameters
- get_allowed_tree_header_graphs()
  - removed unused parameters $order_by, $limit, $total_rows and $user
  - refactored the code to apply for these unused parameters
- get_allowed_trees()
  - removed unused parameters $edit, $sql_where, $limit, $total_rows and $user
  - refactored the code to apply for these unused parameters

lib/functions.php:
- removed get_graph_tree_array() because it's unused after refactor

lib/html_tree.php
- draw_dhtml_tree_level():
  - removed unused parameter $graphing
  - removed unused global $config
- create_dhtml_tree()
  - removed unused global $config
  - refactored get_graph_tree_array() to alias: get_allowed_trees()

auth_profile.php:
  - refactored get_graph_tree_array(true) to alias: get_allowed_trees(true)
2017-04-28 18:16:46 +02:00
Patrick 048436387b Small optimisations for threeview
html_tree.php
- get_formatted_data_query_indexes() only needs to be called if $data_query['id'] > 0
2017-04-26 21:37:43 +02:00
Patrick e27a1b65da Small optimisations for threeview
- fixed several alignment issues

api_tree.php
- api_tree_rename_node() Removed 3 unused methodcalls
- api_tree_item_save() removed unused query
- api_tree_get_branch_ordering() defined fields in query

auth.php:
- defined tablenames for fields

html_tree.php
- draw_dhtml_tree_level_graphing()
  - removed unused parameter
  - moved get_allowed_graphs() call out of the foreach()

graph_view.php
- simplified the $matched queries
- typo in "update_timepsan" => "update_timespan"
2017-04-26 21:19:26 +02:00
cigamit 49e83d7fa1 Resolving Issued #580, #606, #608, #609
- Data collection warnings when using cmd.php
- Replace <path_php_binary> in data input methods
- Spaces adjacent to double quotes are eliminated durate data input
method import
- Horor the column setting in graph tree view mode
2017-04-24 20:40:05 -05:00
patrick cc1cc7eab2 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
2017-04-15 18:00:13 +02:00
cigamit 68336cd72a Resolving Issue #541
Issues with mobile graph viewing.  This introduces a small amount of
Javascript based responsiveness to the filters, and to menu navigation.
Tables will be next.
2017-04-09 15:21:44 -05:00
cigamit 75d0d21fca Tabs and not spaces 2017-04-05 22:25:44 -05:00
patrick d3012868fe More optimisations:
auth.php:
- get_auth_realms() small refactor
- is_graph_allowed() unused variable $graph and unnecessary if-statement
- auth_check_perms() one count of $objects instead of multiple
- is_device_allowed()unused variable $host and unnecessary if-statement
- is_graph_template_allowed()unused variable $template and unnecessary if-statement
- is_view_allowed() unnecessary if-statement

html_tree.php:
- 2x query refactor for use of index reference instead use of function
- deleted unused select statement

html_utility.php:
- isset_request_var() unnecessary if-statement
2017-04-03 20:57:36 +02:00
cigamit 4b456c15ae Resolve 3 Issues in Zoom
- Selector not functioning
- Use localStorage over Cookie
- Zoom into the Future not functional
- Minor cose cleanup
2017-03-24 22:45:09 -05:00
cigamit 01da9b11d6 Resolving Issue #436
Restricted user does not see graphs in tree view.  Also caught some
issues in the Tree Permissions section of both user and User Group's,
and additional Tree permissions when reproducing the users environment.
2017-03-19 13:18:48 -05:00
cigamit 6d94ede57c Resolving four issues
- Aggregate and non-Device Graphs in list view had no Device or Title
- Re-engineer back button design to accomodate ajax and native
navigation
- Widen the jquery.multiselect text box for Graph Template selection
- Resolve some visual issues in Classic theme
2017-03-19 11:43:44 -05:00
cigamit 7e5cc02bd2 Resolve JavaScript errors on initial opening of graph tree page 2017-03-18 22:41:54 -05:00
Alex 369a4fa47a Place on tree dashes / ordering #354
Patch for issue @354
2017-03-01 23:57:25 +02:00
cigamit ec7e766d4c Resolving Issue #311 2017-02-23 18:38:02 -06:00
cigamit 5c0d720704 Resolving Issue #303
The rename activity still shows the ampersand which appears to be a
jstree issue.  Also, it looks like jstree will not accept titles with
things like '<>'
2017-02-18 11:54:23 -06:00
cigamit 4ecc98e1f2 Address developer debug warning 2017-02-07 19:27:57 -06:00
cigamit f9d811b24c Correct navigation issues with Expand Devices enabled 2017-02-03 07:40:38 -06:00
cigamit 51d2268fad No need to change page to 1 when changing the number of columns 2017-02-03 07:02:05 -06:00
cigamit 1cde692db5 When changing leaves, reset the page counter 2017-02-03 07:01:09 -06:00
cigamit 1de9c78eba Resolving Issue #241 2017-02-01 12:52:30 -06:00
cigamit ce1dd6ae46 Resolve issue when using expand devices
When going from the Device branch to either Graph Template or Data Query
branch and then back to Device branch, last Graph Template or Data Query
branch was forced.
2017-01-29 10:21:42 -06:00
cigamit ff33edfe0e Resolving Issue #229 2017-01-23 17:41:15 -06:00
cigamit 1c5d5d6f86 Resolve issue with loosing state 2017-01-20 20:12:09 -06:00
cigamit b6572ab4c5 Removing unfinished deep linking of graph tree and debug logic 2017-01-09 17:19:03 -06:00
cigamit d0e8816747 Insure graph_template_id has a default value 2017-01-07 15:21:32 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit 13358888de Incorrect variable and unchecked variable. 2016-12-30 14:42:26 -06:00
cigamit f9eb5f26ac Use less session variables
The jstree state plugin will reload the state.  This is one of two
commits to allow deep linking of URL again in Cacti.  Right now deep
linking on the tree is not functioning.  Change root tree icon to tree
icon.
2016-11-22 18:46:21 -06:00
cigamit 998adafc6c correcting issues with invalid offsets 2016-09-21 12:20:13 -05:00
cigamit 860f3825ce resolving https://github.com/Cacti/cacti/issues/61 2016-09-02 13:21:18 -05:00
cigamit d4746fa218 resolving bug#2749 2016-08-28 19:41:26 -05:00
cigamit b523f1dea5 remove addslashes, prepared statements, wc3 validation, double to single quote
this is required for preparation of magic_quotes_gpc.
2016-08-28 15:27:48 -05:00
cigamit d739e90793 resolving bug#2135 2016-08-26 08:27:01 -05:00
cigamit 36126aae54 adjust focus on multiselect automatically 2016-08-26 07:26:54 -05:00
cigamit 3b3a4663f0 use promise object and other techniques to hide multiselect display issues 2016-08-25 17:02:20 -05:00
cigamit 4b7bb48af4 add graph template multi-select to graph viewing 2016-08-25 14:20:41 -05:00
cigamit 85bc20f9c3 minor change affecting expand devices 2016-07-12 23:06:25 -05:00
cigamit 54d97035a2 large commit, separate table pager from tables
this change impacts all plugins and css.  css changes are included in
this commit.  plugin changes will be forthcoming.
2016-07-09 12:44:37 -05:00
cigamit 3b67af6c65 resolving Bug#0002486: API hook into the html_tree.php for JQuery/Javascript support in Plugins 2016-06-12 14:53:28 -05:00
cigamit eb0a1601c1 i18n on lib directory, double to single quotes 2016-05-30 19:49:54 -05:00
cigamit 4a4b2b8640 finish spikekill merge 2016-05-14 12:21:38 -05:00
cigamit 1cf29d1760 developer debug warning 2016-05-13 13:13:59 -05:00
cigamit c7ceb6b56f handle tooltips a bit differently 2016-04-22 21:52:51 -05:00
cigamit 12d5de1068 when changing a tree insure page re-renders correctly 2016-04-08 16:46:15 -05:00
Micke2k c836b5032d minor fix for notice error message in log
PHP Warning:  Illegal string offset 'id' in lib/html_tree.php on line 397, referer: http:///cacti/graph_view.php
2016-04-06 20:32:13 +04:00
cigamit b0607bbd92 fix thumbnail saving for graph viewing 2016-04-02 00:42:07 -05:00