Commit Graph
86 Commits
Author SHA1 Message Date
TheWitness 76508f74c1 Issue #412 - More Import - Not Complete
This is the next commit that prototypes Network and SNMP Option Import.  Next three to complete: Device Rules, Graph Rules, Tree Rules.
2023-05-02 21:13:32 -04:00
TheWitness d2141d17c5 Issue #412 - Export now working. 2023-04-30 16:50:56 -04:00
TheWitness 295f594fe0 Phase 2 of #412 - Allow Export of Automation Rules 2023-04-22 13:44:33 -04:00
TheWitness 19a71ccb96 Phase 1 of #412 - Adding hashes
To support Export, we need to first create hashes for tables.
2023-04-22 13:21:14 -04:00
Mark Brugnoli-Vinten 32ba2f19f4 Update copyright year for 2023 2023-01-03 20:34:26 +00:00
Mark Brugnoli-Vinten 8b29d12cc9 Define cacti system paths as constants for better code checking (#5120)
This also provides a full run of src-fixer against all files to
ensure all code is now in alignment.

Closes #5120
2023-01-01 01:03:15 +00:00
netniV 371f8b5253 Fix issues with backtracing and input validation (#3559, #3560)
- When a developer uses backtracing, HTML output can be seen from command line bug confirmed
- When using `input_validate_xxx`, calls to `die_html_input_error()` do not pass variable name bug confirmed

Closes #3559
Closes #3560
2022-11-26 18:28:29 +00:00
netniV fd44f394a0 Remove the need for header=false
Update loadPage calls to be loadUrl
Update loadPageNoHeader calls to be loadUrl calls

Also includes changes to make logout adhere to new html_auth_xxx functions
2022-11-26 13:58:49 +00:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
cigamit 4cbb045e03 Resolving Issue #3191
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit b87747c38b Resolving Issue #2839
Non regular expression search filters don't support international characters
2019-07-24 18:05:17 -05:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit efc061578c More "No XXX Found" format issues 2019-01-12 10:26:25 -06:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit cc602b2c79 Resolving Issue #2139
[1.2.0 Beta2] Error on automation: creation of a new tree rule
2018-11-05 20:53:33 -06:00
cigamit 44190227f4 Resolving Issue #1926
This is easy enough.  Not a major change actually.
Some line ending fixes as well
2018-09-24 20:52:19 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
Mark Brugnoli-Vinten 8ea17f0093 Resolving Issue #1350 (#1753)
* Ensure previously selected field isn't wiped when ediing automation rule item

* Resolving Issue#1350

As per #1350, when switching an Automation Tree Rule's leaf type, remove invalid Automation Rule Items (Object Selection and Tree Creation criteria)
2018-07-26 08:36:21 -04:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
2017-11-18 09:44:33 -05:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 3a8d4f7ff9 Use html_escape() over htmlspecialchars() for consistency and security 2017-09-04 21:26:27 -05:00
cigamit 30bbf226f5 More changes for issue #861
Filters not working properly for i18n
2017-07-20 18:55:33 -05:00
cigamit 20923f43c8 Resolving Issue #862 and Sunshine Theme issue
Automation - When editing Graph Rules, unable to Change Data Query
Links now showing in Automation Graph and Tree rules on Sunshine Theme
2017-07-19 21:35:36 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit 248e56e621 Leverage use of __esc() function over __() for automation functions and title and value attributes.
Required to support broader adoption of i18n
2017-07-15 09:23:04 -05:00
cigamit f850e57629 Freshed core filter html
In preparation for responsive filters phase II
2017-07-05 17:13:10 -05:00
cigamit 1ab240ccfc Resolving Issue #756
Multiple Tranlsation Issues.  Additionally trimming whitespace and
removing line breaks from form descriptions.
2017-05-30 06:46:22 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit a00c967b2c wc3 Validation fixes
This is ajust about everything.  Deprecated removed.  There are still
some warnings that are unresolved due to the movement to div based
forms, but they are soft warnings.
2017-04-30 21:01:10 -05:00
cigamit ff125d01cb Update all pages to include div based forms
This requires a CSS change which is going to be committed next and
separately to call out the changes required there.
2017-04-30 13:15:58 -05:00
cigamit b28f44a9d9 Add escaping to filter values prior to request.
Handles the sepecial case of a pound sign causing issues.
2017-04-23 07:35:01 -05:00
patrick d2185c98b1 PHP7.2 changes:
- Replaced deprecated each() for foreach()
2017-04-21 22:12:55 +02:00
cigamit f22c9694e4 Add multiple column sort and glyph API's
Convert all core pages to use multiple column sort.  There may still be
some pages around automation that are required to be migrated.  However,
they will continue to operate as is.
2017-03-17 17:19:03 -05:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit 1aa80816f2 standardize not found messaging 2016-08-31 16:23:20 -05:00
cigamit b523f1dea5 remove addslashes, prepared statements, wc3 validation, double to single quote
this is required for preparation of magic_quotes_gpc.
2016-08-28 15:27:48 -05:00
cigamit ce4f00acc9 rolling out new filter_value() function to all pages
additionally fixed several minor filtering bugs in many pages
2016-08-22 13:31:06 -05:00
cigamit 54d97035a2 large commit, separate table pager from tables
this change impacts all plugins and css.  css changes are included in
this commit.  plugin changes will be forthcoming.
2016-07-09 12:44:37 -05:00
cigamit 6e90fe2427 minor syntax fixes 2016-06-23 17:59:45 -05:00
cigamit 4f208503b2 minor syntax updates 2016-06-23 17:33:05 -05:00