admin/cacti
1
0 Fork 0
mirror of https://github.com/Cacti/cacti.git synced 2026-11-09 22:13:05 +09:00
Code Issues Packages Projects Releases Wiki Activity
13,630 Commits 84 Branches 85 Tags
0237adea961b50d38f531fcd7cd2294de40fbbeb
Commit Graph
261 Commits
Author SHA1 Message Date
Matthew Mathur bef85436c1 Merge pull request from GHSA-77rf-774j-6h3p 
* Use sanitized unserialize function in managers.php

* Add validation of string contents prior to unserialization
 2023-06-06 00:52:58 +01:00
Mark Brugnoli-Vinten 32ba2f19f4 Update copyright year for 2023 2023-01-03 20:34:26 +00:00
Mark Brugnoli-Vinten 8b29d12cc9 Define cacti system paths as constants for better code checking (#5120) 
This also provides a full run of src-fixer against all files to
ensure all code is now in alignment.

Closes #5120
 2023-01-01 01:03:15 +00:00
Mark Brugnoli-Vinten fa592c249c QA adding a graph template to a host fails (#5080) 
Closes #5080
 2022-12-12 23:15:03 +00:00
netniV 371f8b5253 Fix issues with backtracing and input validation (#3559, #3560) 
- When a developer uses backtracing, HTML output can be seen from command line bug confirmed
- When using `input_validate_xxx`, calls to `die_html_input_error()` do not pass variable name bug confirmed

Closes #3559
Closes #3560
 2022-11-26 18:28:29 +00:00
netniV fd44f394a0 Remove the need for header=false 
Update loadPage calls to be loadUrl
Update loadPageNoHeader calls to be loadUrl calls

Also includes changes to make logout adhere to new html_auth_xxx functions
 2022-11-26 13:58:49 +00:00
TheWitness dadf61fccc QA: Improve 'Create' placement 2022-11-06 13:38:47 -05:00
TheWitness b51ebcc3ad Fixing #4967 - Adding Templates Ease 
Make adding Associated Graph Templates and Data Queries easier to use
 2022-11-05 16:46:53 -04:00
TheWitness 68bc8da89a Fixing Issue #4865 - XML Parse Error 
This fix provides additional clarity on the errors being encountered in this bug.
 2022-07-19 09:39:23 -04:00
TheWitness ccb8b62de0 Fixing issue #4834 - XSS 
XSS Issue in graphs_new.php
 2022-06-18 20:47:02 -04:00
TheWitness f3a846ada4 Fixing Issue #4632 - Form Validation 
Input Field Checking is not enforced upon creation of Data Source
 2022-03-17 20:37:37 -04:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness 80948a9834 Fixing Issue #4522 - New Graphs Header Issues 
* When Creating New Graphs some visible 'Custom Input' values lack a table header
* Also did some cleanup on the custom input functions for consistency.
 2022-01-03 12:53:37 -05:00
TheWitness 3e08169be6 Messaging change for issue #4516 
This message will prevent a users from attempting to create a Graph for a Data Query that has not been finished, or is broken.
 2022-01-03 10:13:51 -05:00
TheWitness 8391eefadf More debugging for #4516 
This will trigger an error message when a problem with the XML files is seen.
 2021-12-30 09:47:06 -05:00
TheWitness 7d32901ae2 Update message related to #4516 
Give users some clue as to the source of the issue.
 2021-12-29 11:28:55 -05:00
TheWitness a9391bdd0b Fixing Issue #4516 - XML Array empty 
Unable to create Graphs due to one of the following Data Query Issues: permissions, incorrectly formatted, or missing XML file
 2021-12-29 11:24:54 -05:00
TheWitness 71d62dcb68 Minor cleanups/audit 
* Use prepared statements
* No natural joins
* Formatting
 2021-10-02 11:54:46 -04:00
TheWitness 8dead7a220 Missing include in graphs_new.php related to #4182 
Automatic Graph Creation - Data Templates with Overriden Values
 2021-04-04 12:34:26 -04:00
TheWitness c47e0e65e1 Fixing Issue #4170 
- Mouse Hover - New Graph Information
- Removing some line feeds as well.
 2021-03-18 20:18:26 -04:00
TheWitness bf292d5d57 Additional update on #4035 
This is based upon recommendations. to pre-sanitize the referer always and we don't want to double sanitize.
 2021-01-06 12:15:22 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 6a4a1efdc2 Fixing Issue #3711 
Graphs New interface not validating page variables
 2020-09-06 20:30:49 -04:00
TheWitness 72baf7b63b Fixing More issues with #3549 
Addressing remaining cases.
 2020-05-30 17:29:59 -04:00
TheWitness dc35a79b15 More fixing for issue #3549 
Several XSS Vulnerabilities
 2020-05-20 22:46:36 -04:00
cigamit 4cbb045e03 Resolving Issue #3191 
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
 2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 572a3654c7 Resolving Issue #2913 
Selection "Graph type" not saved and restored after going to page two
 2019-08-29 07:05:00 -05:00
cigamit b87747c38b Resolving Issue #2839 
Non regular expression search filters don't support international characters
 2019-07-24 18:05:17 -05:00
cigamit af945e0706 Resolved two corners cases related to #2690 
Thse two issues were discovered by user new to Cacti.
 2019-05-19 07:49:06 -05:00
cigamit eb28ca9784 Resolving Issue #2565 
Table checkbox and row selection performance poor on large pages
 2019-03-24 14:57:22 -05:00
cigamit 951159d6b9 Resolving Issue #2457 
Not seeing confirmation when creating a new graph
 2019-02-27 20:34:29 -06:00
cigamit 6621ba06df Resolving Issue #2367 
Undefined offset host_template_id when is not found.  Additional
optimizations for readability and i18n
 2019-02-02 07:32:56 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit f18860f3cd Alphabetize includes add missing lib/poller.php where applicable 
This is required for properly having data follow devices, graphs, and
data sources on change.
 2018-10-13 13:03:22 -05:00
cigamit fbdbcaef29 Resolving Issue #2042 and #1981 
This should fix the issues.  Consolidated logic here as well as the
graph and data source suggested names were using different code paths
 2018-10-10 03:32:59 -05:00
Mark Brugnoli-Vinten 07150a3643 Resolving issue #1927 (#1929) 2018-09-15 08:47:00 -04:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922) 
* Resolving issue #1920

* Minor QA issue
 2018-09-14 20:59:52 -05:00
cigamit a78afb3a84 Move values into the correct location 2018-08-26 10:45:48 -05:00
cigamit b6a9188ccf Correct one warning when creating graphs 
This is due to the API conversion of graphs_new.php
 2018-08-21 20:41:52 -05:00
cigamit 9cdd347e58 Moving some functions into api calls 
This will help resolve and issue that was raised during the resolution
of issue #948.
 2018-08-20 19:06:06 -05:00
cigamit 93c54da1a0 Missed whitelist validation check and case change on error message 2018-06-10 10:56:53 -05:00
cigamit e2532c8b8a Issue: Save Default was not working 2018-06-02 13:31:45 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit 96f62fe610 Resolve Issue #1527 
Update Fontawesome from 4.7 to 5.0.10
 2018-04-22 09:24:27 -05:00
cigamit fa39e853fe Resolving Issue #1510 
New Graphs Undefined Variable $graph_template_name
 2018-03-30 11:06:33 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x 
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
 2018-03-25 11:08:00 -05:00
cigamit 3a76892c17 Minor reformatting and one issue related to #1457 
- There was one possible XSS point in the display
- Minor code simplification and query removal
 2018-03-21 19:21:51 -05:00
cigamit 3ba47881c5 Additional Sanitization for Issue #1457 2018-03-17 08:29:13 -05:00
cigamit a36eaf7e3b Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x 
# Conflicts:
#	docs/CHANGELOG
 2018-03-04 14:24:35 -06:00