Commit Graph
536 Commits
Author SHA1 Message Date
Mark Brugnoli-Vinten bc865667b6 Fix various QA issues (#5422)
Closes #5422
2023-07-25 01:38:15 +01:00
Mark Brugnoli-Vinten db08eb09d5 User Profile Settings are not working correctly (#5412)
Closes #5412
2023-07-22 17:48:09 +01:00
TheWitness 79147cbbbe Fixing #5318 - Additional XSS in Cacti 2023-06-20 20:40:04 -04:00
TheWitness a55abadba6 Fixing #5342 and #5368 - Keyup delay on tree search
Increase keyup delay when searching the tree

For 1.3.x, also adds a setting and switches all keyup events that
make ajax calls to use delayKeyup instead of manually defining
each timer.

Closes #5368
2023-06-12 03:54:55 +01:00
TheWitness 93a3d21678 Fixing #3332 - Combine remove graph_templates_*.php and graphs_items.php
Combining for these two classes of files.  Still have some Aggregate and Color Template files to prune under a separate ticket.
2023-04-16 15:03:39 -04:00
TheWitness bc09d07fc2 QA #5296 - Snmp Port and Timeout missing from v3 devices
1.3.0 - QA SNMP Port and Timeout not Visible when Editing SNMPv3 Device
2023-04-07 11:48:22 -04:00
TheWitness def58636e5 QA: Missing one file on #5171 - Return To 2023-04-02 14:13:00 -04:00
TheWitness ca7a352286 QA: Porting 1.2.24 Changes back to the Develop Branch (#5246) 2023-02-24 03:48:31 +00:00
Mark Brugnoli-Vinten 5a24569532 Some message QA 2023-01-08 19:25:59 +00:00
TheWitness 91e8eabed3 QA: Memory leaks and others
* Fix Memory Leak in layout.js
* Fix Ping Visibility settings
* Move Create Data to lower in form
2023-01-08 13:15:21 -05:00
Mark Brugnoli-Vinten 777a9b38e0 Hidden by the mist 2023-01-08 16:24:53 +00:00
netniV b5efb50653 Minor QA - Don't remove UI elements 2023-01-08 14:52:49 +00:00
Mark Brugnoli-Vinten febbbf6252 QA fix some minor messaging issues 2023-01-08 14:22:47 +00:00
Mark Brugnoli-Vinten 681e0960ce Some minor QA on message handling 2023-01-08 11:45:04 +00:00
TheWitness c9d6dd28c5 Move make callback to applySkin
This is required for the last commit
2023-01-07 22:03:11 -05:00
netniV 7e87231711 Some minor QA on host edit form 2023-01-08 02:45:46 +00:00
netniV 95c9489cc1 Minor QA fix 2023-01-08 02:10:41 +00:00
Mark Brugnoli-Vinten 6ad0512b45 Some light function documentation and src alignment 2023-01-08 00:59:25 +00:00
netniV 276a7ab38c QA Bug fixes and features (#5146, #5148, #5149)
This corrects issues with the host edit form's availabity settings

Feature: enable/disable menu options

This introduces a new feature of disabling and/or enabling of
menu options with an option function to run a value check after
options have been updated.

Feature #5148: theme-based includes with master location

This introduces a new feature of specifying a path, theme and
file to be included.  This allows multiple locations to be
checked for the existence of a file, including the original path
or a subfolder of a theme location (see get_theme_paths).

Feature #5149: Async CSS loading

This introduces a new feature of allowing CSS files to be
loaded async by the browser.  By specifying the CSS files are
for print media only, the browser will delay loading them
speeding up initial load.  Using the javascript 'onload'
event, we then switch them back to being for all media

Closes #5148, #5149
2023-01-08 00:03:25 +00:00
TheWitness 24de8ffca0 Porting #5140, #5142, #5143 from 1.2.x
* #5140: Cacti PHP 8.2 SNMP Errors with php-snmp Installed
* #5142: Correct issues with permission model including display of authorization UI elements and warnings
* #5143: When a Device has zero Graphs or Data Sources, it does not display the correct value
2023-01-07 08:46:12 -05:00
TheWitness 91d035f5d6 QA: Fixing #5128 - Classic issues
1.3.0 - theme classic - cannot submit form (enable/disable user or host, maybe more actions)
2023-01-05 10:38:14 -05:00
Mark Brugnoli-Vinten 32ba2f19f4 Update copyright year for 2023 2023-01-03 20:34:26 +00:00
TheWitness 2e1cde7d72 Fixing #5125 and #5124 JavaScript
Remove use of Eval and make form_callback() logic easier to follow.  More like a jQuery plugin.
2023-01-01 18:05:44 -05:00
TheWitness f1e5ca0c2e QA: On issue #5123
Graph View is a special pageName case
2023-01-01 14:20:48 -05:00
TheWitness 37e69fe6ae Fixing Issue #5123 - Navigation visibility
1.3.0 - QA Going to the CLog tab and pressing the tab a second time opens the console menu
2023-01-01 14:11:48 -05:00
TheWitness 3754c68fa7 QA: Allow anchors to have tooltips 2022-12-25 09:37:26 -05:00
TheWitness 64b48e1dcb Fixing #5103 from 1.2.x branch
When Remote Data Collector changes status a full page refresh or logout should occur
2022-12-18 15:42:49 -05:00
TheWitness d4cdc77ce6 Fixing #5085 - Constant redirects 2022-12-15 11:44:57 -05:00
Jing Chen 993fb9b83b Fixed two files (#5077) 2022-12-12 12:23:57 +00:00
Mark Brugnoli-Vinten 7111414117 QA: Reduce code duplication 2022-12-11 04:24:46 +00:00
Mark Brugnoli-Vinten 06512fa933 LDAP configuration should only use 'user_domains_ldap' (#2166)
Closes #2166
2022-12-11 01:50:54 +00:00
Mark Brugnoli-Vinten 526c7ac18c QA clicking save on Graph view's filter yields a white page (#5065)
This was actually caused by a blank response string.  For now lets
assume that a blank response means don't update the page.
2022-12-10 22:51:35 +00:00
Mark Brugnoli-Vinten f00ceb330c Correct multiple QA issues (#5074, #5605)
Rejig `graph.php` into functions rather than within case statement
and replace multiple print commands with raw HTML output instead as
well as fixed up some HTML formatting and errors

Also fix issues with layout.js and bottom_footer.php to remove extra
footer info that shouldn't be output during ajax calls.
2022-12-10 22:39:15 +00:00
netniV 1013a1bb52 Partial fix to #5064 2022-12-07 14:51:58 +00:00
Mark Brugnoli-Vinten e602bf733f QA: stripHeaderSuppression is undefined (#5058)
Closes #5058
2022-12-06 09:32:16 +00:00
Mark Brugnoli-Vinten c7b530c449 Check if the form exists in formRules (#5055)
Closes #5055
2022-12-06 09:27:16 +00:00
Mark Brugnoli-Vinten f5042fa627 Fix issue with remote db check 2022-12-05 20:46:46 +00:00
Mark Brugnoli-Vinten c434cef644 Correct issues with password validation 2022-12-05 00:14:19 +00:00
Mark Brugnoli-Vinten 49ab4aeb3f Correct issues with form posting 2022-12-04 23:22:36 +00:00
Mark Brugnoli-Vinten 05b8b469de Correct issues with AuthProfile 2022-11-30 09:13:37 +00:00
Mark Brugnoli-Vinten 5002fb7ad7 Move JS function from form_callback to layout.js 2022-11-30 00:33:23 +00:00
Mark Brugnoli-Vinten e15911f1e9 Correct some postUrl/loadUrl usage 2022-11-29 13:11:22 +00:00
netniV 882975d43a Updates for header=false still being set 2022-11-29 09:57:04 +00:00
netniV 4ddebb6921 Add validation to GUI inputs (#1442)
This is an initial start at input validation on the client side.
Currently, this only applies to email address fields but will be
enhanced by future commits.
2022-11-29 03:14:23 +00:00
TheWitness 010a7c63ba QA: Correct typo 2022-11-28 08:21:12 -05:00
TheWitness 16d0a99a8f QA: Fix Page Sorting 2022-11-28 08:17:00 -05:00
TheWitness b5a889f387 QA: Make help pages render properly 2022-11-27 19:28:14 -05:00
TheWitness 2cdc680f40 QA: Top Graph tab handling and JS Errors
* Top tab was unable to show/hide
* tabElement and not tabElemcntId
2022-11-27 18:28:49 -05:00
TheWitness ce15cf56f5 QA: Fix loadTopTab behavior 2022-11-27 16:48:51 -05:00
TheWitness 860ab7b219 QA: Re-tabify layout.js 2022-11-27 15:26:30 -05:00