Commit Graph
4891 Commits
Author SHA1 Message Date
TheWitness c152801d18 Fixing #5420 - a few more cases of invalid trim use
PHP8.1.x, PHP-SNMP and snmp->get() errors due to improper use of trim() function
2023-07-24 09:04:47 -04:00
TheWitness 1512f6a9b7 Fixing #5420 - snmp->get() method failures due to trim
PHP8.1.x, PHP-SNMP and snmp->get() errors due to improper use of trim() function
2023-07-24 08:44:40 -04:00
TheWitness ea7763c890 Fixing #5417 - BCC contents in Cacti.log
Cacti mailer log message misses 'bcc' addresses in log notification
2023-07-23 13:20:57 -04:00
TheWitness b707fd0e99 Fixing Issue #5414 - Plugin control of change device settings
Plugins are unable to modify fields in the setting 'Change Device Settings'
2023-07-23 09:57:51 -04:00
TheWitness d20cfda625 New hook for device template change for thold
This hook helps address and outstanding thold feature request.
2023-07-22 15:58:49 -04:00
Mark Brugnoli-Vinten 4703805708 Fix validation issues (#5411)
Closes #5411
2023-07-22 14:38:26 +01:00
TheWitness b95e8d7927 Two minor fixes #5406 and #5407
-feature#5406: Cacti connection handling should forcibly close connections to work around PDO uncertainty
-feature#5407: Add last_updated column to the boost table to increase diagnostics in Cacti
2023-07-21 09:33:06 -04:00
TheWitness 6687eef2d3 Fixing #5403 - Regular Expression Negation
Cacti Log regular expression filters can not calculate 'does not match' properly
2023-07-15 12:42:18 -04:00
TheWitness 8f6c385273 Fixing #5392 - Template Import Issues
Template import should not end with php error
2023-07-01 12:04:04 -04:00
Petr MacekandTheWitness b2a1c19e42 do not process disabled hosts (#5386)
* do not process disabled hosts

* update

* Update rrdcheck.php

Switch to a left join.

* Update rrdcheck.php

Another left join.

---------

Co-authored-by: TheWitness <thewitness@cacti.net>
2023-06-24 13:02:21 -04:00
TheWitness bb65e1f47c QA: Fixing #5385 - Undefined variable
Realtime Graph Issue
2023-06-24 13:01:09 -04:00
TheWitness bad4d3142d Additional fix to #5371 - Reindexing issues
If a device did not re-index properly and things were marked orphan, unmark them and restore poller items if those items were removed.
2023-06-24 13:00:14 -04:00
TheWitness ab9dd5435f Fixing #5384 - Untemplated Data Source Issue
* Untemplated Data Sources can fail to update due to lack of an assigned Graph
* Related to #5336.  We missed the case of the untemplated data source when we fixed this, and another issue in release 1.2.24.

This will allow objects such as RTM's ELIM Templates to properly create RRDfiles and operate as it does today.
2023-06-20 20:39:35 -04:00
TheWitness b629b3d8a3 QA: Refixing #5364 - Database reconnect warnings 2023-06-19 18:47:25 -04:00
TheWitness 30d68ed22c Fixing #5371 and #5381 - Orphans issues
* Orphaned Data Source Link not Working
* Once a Data Source is orphaned there are cases where it will not become un-orphaned upon reindex
2023-06-19 14:02:59 -04:00
TheWitness 8ff31b63cd Porting changes from #5336 - Poller Issues
Issues with certain cases of Data Input to Data Template to Graph Template Item mappings.
2023-06-19 10:18:49 -04:00
TheWitness 4a8a33d794 Fixing #5316 - Searching from Settings Page
First try at searching from the settings page
2023-06-17 18:26:32 -04:00
TheWitness f47b6b3f93 Porting #5324 - Multiple XSS issues in Cacti
This is resolved just a bit differently than the original #5324 post.
2023-06-17 17:49:17 -04:00
TheWitness 58c69011e5 Fixing #5318 - Multiple minor stored XSS vulnerabilities
SECURITY: Multiple minor stored XSS vulnerabilities in Cacti 1.2.24
2023-06-17 17:21:41 -04:00
TheWitness 76ed6bc9d4 Fixing #5319 - Data Debug logging
Data Source Debug 'Run All' generates too many log messages
2023-06-17 17:09:50 -04:00
TheWitness a46b3e09a2 Fixing #5317 - Data Source Info Issues
Data Source Info Mode produces invalid recommendations
2023-06-17 17:07:43 -04:00
Mark Brugnoli-Vinten 69280f303c Auth errors with user lockout (#5376) 2023-06-17 16:55:59 -04:00
netniV 5d7c01e489 PHP configuration file may not have expected settings (#5372)
CLoses #5372
2023-06-12 16:20:27 +00:00
TheWitness 8f37d50f39 QA: Fix Syntax Error 2023-06-12 08:19:42 -04:00
TheWitness f0e840efa4 Fixing #5333 - MariaDB stopped supporting GET_LOCK in cluster
MariaDB stopped supporting GET_LOCK in cluster
2023-06-12 04:15:21 +01:00
TheWitness a55abadba6 Fixing #5342 and #5368 - Keyup delay on tree search
Increase keyup delay when searching the tree

For 1.3.x, also adds a setting and switches all keyup events that
make ajax calls to use delayKeyup instead of manually defining
each timer.

Closes #5368
2023-06-12 03:54:55 +01:00
TheWitness 4beb66dbe2 Fixing #5348 - Issues with Regular Expression searches in Cacti
Unchecked Regular expressions can lead to privilege escalation and data leakage
2023-06-12 03:14:48 +01:00
TheWitness 7eb34917b8 Fixing #5329 - Form errors persist after display
Upon displaying a form with errors, the session error fields variable isn't cleared.
2023-06-12 03:11:33 +01:00
netniV 0b06b0a49b Plugin missing functions warning should be debounced (#5360) 2023-06-12 03:02:50 +01:00
netniV cd02a4c2e3 Improve downed Device detection (#5356) 2023-06-12 02:57:19 +01:00
TheWitness fb0ed4cb2f Fixing #5366 - RRDcheck logging
RRDcheck does not log using proper case
2023-06-12 02:53:27 +01:00
TheWitness e76ff3bde1 More corrections for #5169 - Fail date logic
Host table status_fail_date and status_rec_date can appear wrong
2023-06-12 02:36:48 +01:00
TheWitness 79a1941a0d Fixing #5169 - Recovery date wrong
Host table status_fail_date and status_rec_date can appear wrong
2023-06-12 02:36:45 +01:00
Mark Brugnoli-Vinten 70137eb9e2 Remove duplicated path loop in lib/installer.php 2023-06-12 02:22:16 +01:00
netniV 9a184a7701 Automation library references "ghost" table (#5315)
Closes #5315
2023-06-11 16:10:45 +00:00
netniV e4961c71dd QA on theme paths 2023-06-06 17:48:20 +00:00
netniV 1fafdb1b66 Sites can now disable hosts, host list should show this (#5351)
Closes #5351
2023-06-06 17:08:08 +00:00
Matthew Mathur bef85436c1 Merge pull request from GHSA-77rf-774j-6h3p
* Use sanitized unserialize function in managers.php

* Add validation of string contents prior to unserialization
2023-06-06 00:52:58 +01:00
TheWitness 35e1e9c8ed Minor Automation QA 2023-06-03 13:29:47 -04:00
Mark Brugnoli-Vinten f49bed3b5b Fix issue with array_rekey 2023-06-01 00:41:26 +01:00
Petr Macek 14a0eeb72c fix sql query - incorrect column name (#5341) 2023-05-31 10:12:59 -04:00
Petr Macek d44e0a7cf2 function read_config_option returns null sometimes (#5339) 2023-05-31 08:22:30 +01:00
Mark Brugnoli-Vinten 8f4b5e737a [QA 1.3.X] Unable to add users due to is_template_account() (#5337)
Closes #5337
2023-05-29 11:48:04 +01:00
Mark Brugnoli-Vinten 972d46d0d0 Some minor QA fixes to make VSC happy 2023-05-29 11:33:48 +01:00
netniV 2d550fb592 CSRF override can prevent installer from continuing (#5330)
Closes #5330
2023-05-14 13:15:32 +00:00
Browniebraun 1e17d5e08f make usage of HTML thead tag to support scrollable tables with fixed table headers. (tbody tag is out of scope as it will be implied by current browsers automatically) 2023-05-07 18:47:38 +02:00
Mark Brugnoli-Vinten 7776b5af8f QA: Fix up error during validation death 2023-05-03 13:40:43 +01:00
TheWitness 76508f74c1 Issue #412 - More Import - Not Complete
This is the next commit that prototypes Network and SNMP Option Import.  Next three to complete: Device Rules, Graph Rules, Tree Rules.
2023-05-02 21:13:32 -04:00
TheWitness a54e3c77a1 QA: #412 - Unset unused items on export 2023-04-30 21:34:38 -04:00
TheWitness d2141d17c5 Issue #412 - Export now working. 2023-04-30 16:50:56 -04:00