admin/cacti
1
0 Fork 0
mirror of https://github.com/Cacti/cacti.git synced 2026-11-06 20:13:29 +09:00
Code Issues Packages Projects Releases Wiki Activity
13,630 Commits 72 Branches 85 Tags
0237adea961b50d38f531fcd7cd2294de40fbbeb
Commit Graph
105 Commits
Author SHA1 Message Date
Matthew Mathur bef85436c1 Merge pull request from GHSA-77rf-774j-6h3p 
* Use sanitized unserialize function in managers.php

* Add validation of string contents prior to unserialization
 2023-06-06 00:52:58 +01:00
Mark Brugnoli-Vinten 32ba2f19f4 Update copyright year for 2023 2023-01-03 20:34:26 +00:00
Mark Brugnoli-Vinten 8b29d12cc9 Define cacti system paths as constants for better code checking (#5120) 
This also provides a full run of src-fixer against all files to
ensure all code is now in alignment.

Closes #5120
 2023-01-01 01:03:15 +00:00
netniV 371f8b5253 Fix issues with backtracing and input validation (#3559, #3560) 
- When a developer uses backtracing, HTML output can be seen from command line bug confirmed
- When using `input_validate_xxx`, calls to `die_html_input_error()` do not pass variable name bug confirmed

Closes #3559
Closes #3560
 2022-11-26 18:28:29 +00:00
netniV fd44f394a0 Remove the need for header=false 
Update loadPage calls to be loadUrl
Update loadPageNoHeader calls to be loadUrl calls

Also includes changes to make logout adhere to new html_auth_xxx functions
 2022-11-26 13:58:49 +00:00
netniV 5d90b8b720 QA: Fix AND operators 2022-02-19 23:02:30 +00:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
Jing Chen e9343b0da5 Fixed several typo in php file header (#4483) 2021-11-28 10:50:18 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness ef10fe1c34 Fixing Issue #4019 
* In a recent audit of core Cacti code, there were a few stored XSS issues that can be exposed
* Also removed a few spurious title_trims, that should no longer be a problem.
 2020-12-23 16:33:27 -05:00
cigamit 4cbb045e03 Resolving Issue #3191 
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
 2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit b87747c38b Resolving Issue #2839 
Non regular expression search filters don't support international characters
 2019-07-24 18:05:17 -05:00
cigamit 8a6d100dd9 Resolved Issue #2741 
Resolve a number of QA issues in various files
One additional fix for data debug as to default debug state
 2019-06-22 09:23:29 -05:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional 
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
 2018-12-16 09:54:11 -06:00
cigamit 35b184c1f0 Minor wording and format issues 2018-12-08 14:53:37 -06:00
cigamit 44190227f4 Resolving Issue #1926 
This is easy enough.  Not a major change actually.
Some line ending fixes as well
 2018-09-24 20:52:19 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922) 
* Resolving issue #1920

* Minor QA issue
 2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882 
Bypass output validation in select cases
 2018-08-30 19:29:27 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit 1756711f4d Make the snmpagent more consistent 
The snmpagent plugin labeled snmp_password as snmp_auth_password and
snmp_priv_passphrase as snmp_priv_password.  This change aligns the
column names in the database between features.

Additionally, for most of Cacti, with the inclusion of noAuthNoPriv, the
snmp_auth_protocol needed to be expanded to 6 characters from 5.
 2018-01-14 18:00:08 -06:00
cigamit 9274f014ca Updates after final QA of SNMP security_level feature 2018-01-14 16:29:02 -06:00
cigamit 1f1f05408d Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x 
# Conflicts:
#	host.php
#	managers.php
#	settings.php
 2018-01-14 15:46:15 -06:00
cigamit 75eb754235 Move SNMP functions into core 
This will reduce the liklihood of bugs from duplicated code.
 2018-01-14 15:40:39 -06:00
cigamit a00e9bf8f8 Correct jQuery Syntax Issue 2018-01-14 11:10:22 -06:00
cigamit 4c41cdf821 Correct jQuery Syntax Issue 2018-01-14 11:08:37 -06:00
cigamit 6469e879c1 Calculate the default security level for legacy 
Without this, legacy behavior might break.
 2018-01-14 11:05:57 -06:00
cigamit 82061ec5fd Calculate the default security level for legacy 
Without this, legacy behavior might break.
 2018-01-14 11:05:34 -06:00
cigamit 5d38d596e7 Minor Tweaks to SNMP v3 Security Levels 
Handle jQueryUI selectmenu refresh and reorder the settings form to flow
the same as host and manager edit.
 2018-01-14 10:53:29 -06:00
cigamit 56f07bc77b Minor Tweaks to SNMP v3 Security Levels 
Handle jQueryUI selectmenu refresh and reorder the settings form to flow
the same as host and manager edit.
 2018-01-14 10:53:07 -06:00
cigamit 1edbf5b667 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x 
# Conflicts:
#	host.php
#	include/global_settings.php
#	managers.php
#	settings.php
 2018-01-14 10:41:31 -06:00
cigamit 97583420f2 Tweak visibility and default 
Debugging and for backward compatibility.
 2018-01-14 10:38:21 -06:00
cigamit 998f7ebcfb More snmpv3 security level work 
This change adds the security level to the forms, but not the database
as it generates the least amount of effort.
 2018-01-14 10:24:12 -06:00
cigamit 7dcc0160cd More snmpv3 security level work 
This change adds the security level to the forms, but not the database
as it generates the least amount of effort.
 2018-01-14 10:23:39 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x 
# Conflicts:
#	docs/CHANGELOG
 2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x 
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
 2017-11-18 09:44:33 -05:00
Patrick 4bc2f4c0bc Various updates (#1073) 
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
 2017-11-11 05:45:12 -06:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x 
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
 2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038) 
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
 2017-10-16 11:32:05 -04:00
cigamit 3a8d4f7ff9 Use html_escape() over htmlspecialchars() for consistency and security 2017-09-04 21:26:27 -05:00
Browniebraun 052bed7ae1 2nd Missing argument 
undefined variable html_header due to missing argument in list
 2017-08-10 11:35:52 +02:00
cigamit 30bbf226f5 More changes for issue #861 
Filters not working properly for i18n
 2017-07-20 18:55:33 -05:00
cigamit 0673e3c725 Resolving Issue #861 
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
 2017-07-19 20:16:27 -05:00
cigamit f850e57629 Freshed core filter html 
In preparation for responsive filters phase II
 2017-07-05 17:13:10 -05:00
cigamit b09ddfb760 Resolving Issue #696 
Multiple issues with snmpagent notification UI
 2017-05-19 21:59:54 -05:00
Jimmy Conner aea8ddc7bd Merge pull request #702 from reboot1983/strlen 
Cool stuff
 2017-05-17 22:13:11 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
cigamit 4279023225 Resolving Issue #672 
Can not enable snmp notification receivers
 2017-05-14 21:42:44 -05:00