Commit Graph
110 Commits
Author SHA1 Message Date
TheWitness 900a66a0cc Fixing Issue #3048 - Different log levels for pollers
Allow different log settings for remote pollers
2023-04-17 06:59:03 -04:00
TheWitness c7d6c958e1 QA #5171 Fixing auth_profile.php
* 1.3.0 - QA Unable to return from edit profile
* This also finishes the design intent of the form_save_buttons() function
2023-04-02 14:11:53 -04:00
Mark Brugnoli-Vinten 32ba2f19f4 Update copyright year for 2023 2023-01-03 20:34:26 +00:00
Mark Brugnoli-Vinten 8b29d12cc9 Define cacti system paths as constants for better code checking (#5120)
This also provides a full run of src-fixer against all files to
ensure all code is now in alignment.

Closes #5120
2023-01-01 01:03:15 +00:00
Mark Brugnoli-Vinten c8157e3cbb Switch to constants for common session/cookie options 2022-12-21 10:53:53 +00:00
Mark Brugnoli-Vinten 7111414117 QA: Reduce code duplication 2022-12-11 04:24:46 +00:00
Mark Brugnoli-Vinten f5042fa627 Fix issue with remote db check 2022-12-05 20:46:46 +00:00
Mark Brugnoli-Vinten c637118220 Correct issue with Delete title not being available 2022-12-05 20:16:27 +00:00
netniV c27f0aa983 QA on previous commit - Actually remove the delete button 2022-11-26 20:01:36 +00:00
netniV 18b5221da3 Relocate the delete button for collectors (#3677)
This commit moves the delete button for collectors from the listing page
to the edit page for safety.  It also prevents accident deletion of
multiple collectors at the same time.

Closes #3677
2022-11-26 19:52:30 +00:00
netniV e8cd262bb7 Making posting work (for the most part) 2022-11-26 19:32:26 +00:00
netniV 371f8b5253 Fix issues with backtracing and input validation (#3559, #3560)
- When a developer uses backtracing, HTML output can be seen from command line bug confirmed
- When using `input_validate_xxx`, calls to `die_html_input_error()` do not pass variable name bug confirmed

Closes #3559
Closes #3560
2022-11-26 18:28:29 +00:00
netniV fd44f394a0 Remove the need for header=false
Update loadPage calls to be loadUrl
Update loadPageNoHeader calls to be loadUrl calls

Also includes changes to make logout adhere to new html_auth_xxx functions
2022-11-26 13:58:49 +00:00
TheWitness 2027fc9a23 Fixing Issue #4940 - Sorting by hostname issues
Error display Data Collectors when sorting by hostname
2022-10-04 22:06:28 -04:00
Jing ChenandTheWitness 328e2d9bc1 Fix two syntax error for PHP 5.4 (#4688)
* Fix two syntax error for PHP 5.4

* Update CHANGELOG for PR#4688, and remove a duplicate item

* Update CHANGELOG

Co-authored-by: TheWitness <thewitness@cacti.net>
2022-04-09 14:39:14 -04:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
netniV 5c99d547d5 Further fixes for #4475 2021-12-06 23:37:25 +00:00
Chris RowatandChris Rowat 75feba3b28 Proposed fix for issue 4455 (#4456)
Co-authored-by: Chris Rowat <chris.rowat@terago.ca>
2021-11-07 01:30:00 +00:00
TheWitness 1384054f39 Another update related to #4442 2021-10-25 19:52:51 -04:00
TheWitness 2a1d1f90b0 Fixing Issue #4442 - Retries Undefined
When testing remote poller connectivity Errors occur
2021-10-25 19:37:33 -04:00
TheWitness 1c041f7ee1 Fixing Issue #4443 - Renaming poller generates SQL Error
When renaming poller errors occour.  Corrrected this by simplifying the logic slightly and removing both injection vectors and uncaught exceptions.
2021-10-25 19:32:43 -04:00
TheWitness 9747c229a9 Additional QA on #4423
You need to be able to save the value ;)
2021-10-16 12:58:45 -04:00
TheWitness 4640f53fe7 Fixing Issue #4423 - Inconsistent db_connect_real() usage
Parameter list for lib/database.php:db_connect_real() is not correct in 3 places
2021-10-16 12:45:32 -04:00
TheWitness 652c137782 Fixing Issue #4272 - dns_get_record() wrarnings
dns_get_record(): A temporary server error occurred
2021-05-18 21:43:01 -04:00
TheWitness bc632bc30d Fixing Issues #3945 and #4031
* Graph CSV export NaN with wrong date range if browser timezone is different with web server
* Data Collectors and Data Profiles Filter Sub-Panel Go buttons not working as expected
2021-01-04 20:25:14 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 2b35d17361 Resolving Issue #4013
Remote Poller - reset avg/max polling time
2020-12-19 09:33:16 -05:00
TheWitness 52bb6ffda7 Remove all remaining instances to "sizeof(" or "count(" in code
* Some insances in the vendor directory have not been handled to maintain pedigree.
2020-10-21 08:27:42 -04:00
TheWitness 4e062fb6aa Use Cacti functions for session handling where possible. 2020-05-19 12:29:54 -04:00
TheWitness 2305809401 Fixing Issue #3474
The SSL option to set the SSL_CA should be optional for Client Connections
2020-04-18 09:24:14 -04:00
TheWitness 41a0cad887 Fixing Issue #3467
Security: required more fixing like #3191((CVE-2020-7106))
2020-04-16 19:24:01 -04:00
TheWitness d65f40d2bf Abstract Cacti session handler 2020-03-29 19:08:29 -04:00
TheWitness 5cf8d8656f Fixing Issue #2110
Add Refresh Interval to Data Collectors display
2020-03-21 20:42:55 -04:00
TheWitness 68831cd01e Fixing #1566
Need to change to $config due to old PHP5.
2020-03-21 14:53:17 -04:00
ddb4githubandJing Chen 6d4bf16032 Fixed: SQL Error when edit/save "Main Poller" (#3364)
Co-authored-by: Jing Chen <three_chenjing@sohu.com>
2020-03-20 18:20:56 -04:00
TheWitness e4b179bd35 Fixing Issues #2937 and #3209
* Devices still show in cacti despite being deleted
* PHP Error when Creating New Graphs through Automatically Added Devices using Sync Device Template
2020-01-22 19:08:59 -05:00
cigamit 4cbb045e03 Resolving Issue #3191
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 75156ac291 Additional testing for issue #3055 2019-11-29 11:13:48 -06:00
cigamit d76dbcadd7 Resolving Issue #3085
It is possible to have the same IP address for the remote and main pollers causing synchronization issues
2019-11-28 12:05:45 -06:00
netniV 2b9d00f183 Correct usage of affect vs effect in strings
Closes #2909
2019-08-22 14:58:59 +00:00
netniV ffcf28221f SSL column for multiple pollers can be incorrectly set causing SQL errors
Closes #2907
2019-08-21 20:52:05 +00:00
cigamit b87747c38b Resolving Issue #2839
Non regular expression search filters don't support international characters
2019-07-24 18:05:17 -05:00
cigamit 0a4ae024b7 Revert "Resolving Issue #2781"
This reverts commit 684e881bcf.
2019-06-30 10:24:01 -05:00
cigamit 684e881bcf Resolving Issue #2781
Unable to update remote data collector remote database hostname
2019-06-30 09:57:25 -05:00
Matthew Horan 983d9f29aa Make the local poller timezone configurable (#2517)
Some cloud SQL providers do not make the textual default_time_zone
configurable. While a manual offset value (e.g. -04:00) can be
configured for this value, that's not too convenient in places that
observe DST.

By exposing the poller timezone configuration for all pollers, it's
possible to override this default with a textual zone name if desired.
2019-03-16 18:03:34 -05:00
cigamit 1f74fc650a Resolving Issue #2327
Poller Replicate Memory Issue
2019-01-26 08:54:30 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit 870c0a70d5 Hide threads when poller type is cmd.php 2019-01-13 10:28:08 -06:00
cigamit e1dad073ba Properly display "No XXX Found" rows 2019-01-12 09:48:29 -06:00