Commit Graph
84 Commits
Author SHA1 Message Date
Mark Brugnoli-Vinten 32ba2f19f4 Update copyright year for 2023 2023-01-03 20:34:26 +00:00
Mark Brugnoli-Vinten 8b29d12cc9 Define cacti system paths as constants for better code checking (#5120)
This also provides a full run of src-fixer against all files to
ensure all code is now in alignment.

Closes #5120
2023-01-01 01:03:15 +00:00
Mark Brugnoli-Vinten 06d0fb8c9b QA: Missed a spot for toggleFields() 2022-12-12 11:31:59 +00:00
Mark Brugnoli-Vinten 7111414117 QA: Reduce code duplication 2022-12-11 04:24:46 +00:00
Mark Brugnoli-Vinten 06512fa933 LDAP configuration should only use 'user_domains_ldap' (#2166)
Closes #2166
2022-12-11 01:50:54 +00:00
netniV 371f8b5253 Fix issues with backtracing and input validation (#3559, #3560)
- When a developer uses backtracing, HTML output can be seen from command line bug confirmed
- When using `input_validate_xxx`, calls to `die_html_input_error()` do not pass variable name bug confirmed

Closes #3559
Closes #3560
2022-11-26 18:28:29 +00:00
netniV fd44f394a0 Remove the need for header=false
Update loadPage calls to be loadUrl
Update loadPageNoHeader calls to be loadUrl calls

Also includes changes to make logout adhere to new html_auth_xxx functions
2022-11-26 13:58:49 +00:00
TheWitness 259887cdb4 QA: Fixing Issue with #4703 Commit 2022-04-13 21:27:59 -04:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness 4265c54491 Fixing Issue #4299 - Multiple LDAP servers
Allow Cacti to use multiple possible LDAP servers
2021-10-18 20:48:41 -04:00
TheWitness e5f7e5a483 Fixing Issue #4121
Too short search filter for Ldap - Cacti 1.2.2
2021-02-11 19:25:47 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness ef332c4d9f Fixing some minor format errors 2020-03-12 18:54:52 -04:00
cigamit 4cbb045e03 Resolving Issue #3191
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit b87747c38b Resolving Issue #2839
Non regular expression search filters don't support international characters
2019-07-24 18:05:17 -05:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit f18860f3cd Alphabetize includes add missing lib/poller.php where applicable
This is required for properly having data follow devices, graphs, and
data sources on change.
2018-10-13 13:03:22 -05:00
cigamit 44190227f4 Resolving Issue #1926
This is easy enough.  Not a major change actually.
Some line ending fixes as well
2018-09-24 20:52:19 -05:00
Mark Brugnoli-Vinten 39efc75c49 Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939 (#1937)
* Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939

* Update import.php
2018-09-16 13:22:32 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 5d7bb410e0 Some pages missing colspan's for no rows found
Issue with message text wrapping when no rows found on some pages
2018-02-24 17:43:48 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 2c00d59b35 Resolving Issue #1097
Template user issues including:
- All template users should be disabled by default
- When a user is copied, enable that user by default
2017-11-23 12:30:56 -06:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
2017-11-18 09:44:33 -05:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 4680aa3a7e Correct remaining whitespace issues
Do a little cleanup of SQL queryies to use less horizontal space
2017-09-16 16:26:30 -05:00
Arno Streuli cedc671eaa Feature/1.2.x (#979)
* Update cacti.sql

Added 2 entry for cn_full_name and cn_email

* Update cacti.sql

Change the size to 50

* Create 1_2_0.php

Added the change on table user_domains_ldap, to provide info for full_name and email

* Update global_settings.php

Added the 2 new entry as new section for LDAP settings:
ldap_cn_fullname
ldap_cn_email

* Update auth.php

Added the email address on user_copy function

* Update ldap.php

Added the ldap_search_cn to search 2 specific CN on LDAP server

* Update auth_login.php

Added the Get user CN part for new LDAP users

* Update ldap.php

little error on ldap_search inside Getcn function

* Update user_domains.php

Add option to manage Full name and email taken from LDAP server

* Update auth_login.php

Change for multidomain authentication

* Update global_settings.php

change the name ldap_cn_xxx to just cn_xxx

* Update ldap.php

Correction to the error number and message when the CN is not find

* Update settings.php

Added the visibility of CN fields only for LDAP authentication mode

* Update ldap.php

correct on line 729 missing $ before this->cn

* Update cacti.sql

column definitions consistent with the definitions under install/upgrades/1_2_0.php

* Update auth_login.php

correct tab, as space, and add {} in if else statment

* Update ldap.php

correction on cacti_log with $output['error_text'], correction on all error_num 99 as '99'
and made some correction int tab/space

* Update auth_login.php

add missing {} on else function
2017-09-16 15:51:56 -05:00
cigamit 3a8d4f7ff9 Use html_escape() over htmlspecialchars() for consistency and security 2017-09-04 21:26:27 -05:00
cigamit 30bbf226f5 More changes for issue #861
Filters not working properly for i18n
2017-07-20 18:55:33 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit f850e57629 Freshed core filter html
In preparation for responsive filters phase II
2017-07-05 17:13:10 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit ff125d01cb Update all pages to include div based forms
This requires a CSS change which is going to be committed next and
separately to call out the changes required there.
2017-04-30 13:15:58 -05:00
cigamit b28f44a9d9 Add escaping to filter values prior to request.
Handles the sepecial case of a pound sign causing issues.
2017-04-23 07:35:01 -05:00
patrick d2185c98b1 PHP7.2 changes:
- Replaced deprecated each() for foreach()
2017-04-21 22:12:55 +02:00
cigamit 5a35089f8b Resolving minor jQuery issues 2017-03-25 15:04:38 -05:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
cigamit 3c9d5f7a93 Minor language change 2017-01-08 20:25:31 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit 1aa80816f2 standardize not found messaging 2016-08-31 16:23:20 -05:00
cigamit b523f1dea5 remove addslashes, prepared statements, wc3 validation, double to single quote
this is required for preparation of magic_quotes_gpc.
2016-08-28 15:27:48 -05:00
cigamit ce4f00acc9 rolling out new filter_value() function to all pages
additionally fixed several minor filtering bugs in many pages
2016-08-22 13:31:06 -05:00