Commit Graph
1347 Commits
Author SHA1 Message Date
cigamit 083c59cd74 Resolving Issue #1085
Call to undefined function html_log_input_error in debug mode
2017-11-17 07:43:18 -06:00
cigamit 7a5d171711 Resolving Issue #1079
- Undefined index in lib/snmpagent.php
- Remove trailing whitespace from file
- Reformat some sql statements.
2017-11-16 06:26:11 -06:00
DavidLiedke 8b7ba2f063 Update phpseclib to 2.0.7 (#1080) 2017-11-16 06:14:39 -06:00
Tony Roman 4a0d2dc5fd Update Change log for release 1.1.28 2017-11-13 09:00:16 -05:00
cigamit b3cd84782b Mark issue #1072 resolved
CVE-2017-16785 in global_session.php Reflection XSS issue
2017-11-12 11:04:00 -06:00
Patrick 928ae7de82 Various updates (#1075)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations

* fixed parameter typo in query_debug_timer_stop()

* fixed typo $_SESSION

* MibCache->install() uses MibParser->oids, but MibCache->oids has protected access instead of public

* Updated of PHPMailer to version 5.2.26
- Minor security backport from 6.0 - set Debugoutput in constructor according to SAPI in use, avoiding potential XSS in default debug output. Thanks to Bankde Eakasit for spotting it.

* Remove old autoLoad method
2017-11-12 09:39:55 -06:00
cigamit 79a06805a1 Minor performance increase in boost proces
Also reformat poller_boost.php to be consistent with other CLI
functions.
2017-11-12 08:46:57 -06:00
cigamit a179e8092d Resolving Issue #1066
Resolve second half of Issue #1066 which is CVE-2017-16661.
2017-11-11 07:39:13 -06:00
cigamit 4e74f46fe2 Resolving one half of Issue #1066 for CVE-2017-16660
- This issue will stop the injection point in the call
- Also adding a timeout to the polldata function to prevent long running
scripts from blocking the web server.
2017-11-11 06:16:40 -06:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
cigamit 532684e7a9 Resolving Issue #1064
- When a Device Template is removed, Automation Templates for that
Device Template remain.
- Spurious introduction of html_escape()

Note that it does not make sense to remove the Automation Templates as
the user may intend to use them for some other purpose.
2017-11-10 18:07:17 -06:00
DavidLiedke f92879d5c5 Add CVE to Changelog for #1057 (#1067) 2017-11-08 08:35:12 +01:00
cigamit bea58d8fce Resolving Issue #958
User Group Tree permissions not resolved fully.
2017-11-04 20:19:07 -05:00
cigamit 223780bcec Resolving Issue #1012
Issue where disabled devices do not appear on the tree edit page.
2017-11-04 19:51:57 -05:00
cigamit 52a9e1fe8c Resolving Issue #1058
ICMP Ping to and IPv6 address fails to gather data for Ping Latency /
CentOS 7.4
2017-11-04 15:42:34 -05:00
cigamit fbbcedd378 Resolving Issue #1053
- Remote Data Collector issues with https and self signed certificates.
- Some spurious backport of html_escape() calls
2017-11-04 15:36:24 -05:00
cigamit e8088bb659 Resolving Issue #1057
- Potential vulnerability in RRDtool functions
- Adding validation to both dirpath and filepath, also verification of
executable status to files in RRDtool function.
- Spurious htmlspecialchars() to html_escape() calls
- Minor SQL formatting for readability
2017-11-04 14:52:09 -05:00
cigamit 295d390dc1 Resolving Isuse #1059
Aggregate item filter should use regular expressions to avoid SQL errors
due to flawed filter logic.
Backporting more html_escape() calls.
2017-11-04 14:01:21 -05:00
cigamit b7a4808d34 Resolving Issue #1055
Errors in data source statistics inserts when invalid output is
encountered.
2017-11-04 12:59:58 -05:00
cigamit 7ab455ad00 Resolving Issue #1044
Handle invalid exclusion regex properly when view the Cacti Log
2017-10-29 11:09:47 -05:00
cigamit 692c437e03 Resolving Issue #992
Resolving RRDfile naming issues that result from random sorting upon
export in prior versions of Cacti
2017-10-29 09:41:53 -05:00
cigamit 51932c6835 Resolving Issue #959
- Resolving issues viewing email reports due to email client decoder
issues.
- Also, make some format changes for readability of code
2017-10-29 09:27:16 -05:00
cigamit e961202f70 Resolving Issue #1048
Unable to import vdef's from templatesl
2017-10-27 06:52:44 -05:00
cigamit 7020f4ffbb Resolving Issue #1045
Issues with confirmation dialogs.
Also adding spurious html_escape() function over the use of
htmlspecialchars()
2017-10-26 21:52:53 -05:00
cigamit 7454361f2b Resolving Issue #1040
Resolving compatibility issue with PHP7.2
2017-10-18 11:28:14 -05:00
cigamit 054aa82de0 Resolving Issue #1039
Use strip_tags() over html_escape due to double escaping not working as
expected.
2017-10-17 23:45:25 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 0d94d798b5 Resolving Isuse #1033
Insert issue into dsstats table.
2017-10-16 06:28:05 -05:00
cigamit 86f719b923 Resolving Issue #989
- Spaces lost on re-import of data input method.
- Possible injection point in templates_export.php
- Minor format changes to db calls

Note that this will not 100% resolve the importation of old templates.
However, all new templates will base64_encode all input strings prior to
XML encoding, which resolves this issue ongoing.
2017-10-15 09:54:07 -05:00
cigamit 8e2a5fd806 Resolving Issue #986
Resolving minor visual issue with Modern theme
2017-10-15 08:29:49 -05:00
cigamit a409c4f3e9 Resolving Issue #1027
Confirm that the PHP date.timezone settings are set during install
2017-10-11 21:17:42 -05:00
cigamit e94651aed1 Resolving Issue #1009
Resolving minor issue with cmd_realtime.php and a changing hostname
2017-10-11 19:22:42 -05:00
cigamit c44f082af0 Resolving Issue #1008
Remove developer debug warning about thumbnail validation
2017-10-11 19:16:19 -05:00
cigamit b26884cad0 Resolving issues #841 and #1000
Resolving multiple issues with add_graphs.php cli script
2017-10-11 18:45:09 -05:00
cigamit 9a9eb3c941 Resolving Issue #1003
Redirecting standard output and error to the console causes poller
slowdowns.
2017-10-11 18:11:37 -05:00
Patrick 5669472765 Various updates (#1019)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations
2017-10-11 17:59:30 -05:00
Tony Roman a68942a804 Fixed database session handling for PHP 7.1
- Updated function names to avoid potential function naming overlap
 - Added comments
2017-10-10 22:00:35 -04:00
DavidLiedke b4854caf97 Add CVE-2017-15194 to Changelog (#1023) 2017-10-10 15:15:11 -04:00
Patrick a158d86e97 Updated changelog (#1018) 2017-10-07 15:35:02 -04:00
Patrick 4617c60a02 Various updates (#1016)
* Updated Dutch translations
- 1007 translations remaining (70% translated)
- Typo fixes

* Fix for #1005

* Schema changes
- Examined queries without key usage and added/changed some keys

* Fixed some missing i18n
2017-10-07 13:05:12 -04:00
Tony Roman e496cd92f7 Preping for 1.1.26 2017-10-07 12:13:55 -04:00
Tony Roman af10cda1f2 Preping for 1.1.25 release 2017-09-27 10:39:05 -04:00
Patrick 61ae57c5d2 Updated Dutch translations (#999)
- 1007 translations remaining (70% translated)
- English typo fixes
2017-09-23 16:27:28 -05:00
cigamit 121be36ed7 Changing filters on the log and clog pages not correct
When changing some filters, we chould always change the page number back
to 1, with others, we should leave the page number the same.  This audit
uncovered a few cases that were incorrect.
2017-09-23 08:40:48 -05:00
cigamit cc242b8aa8 Resolving Issue #966
- SMTP Security set to None, but TLS still being used
- Backport more html_escape() changes for convenience
- Backport charset check for convenience
2017-09-23 07:04:34 -05:00
cigamit bfb10e2e60 Resolving Issue #995
Redirecting stnadard output to /dev/null causing issues with Report
sending
2017-09-23 06:45:52 -05:00
cigamit 305f04332b Resolving Issue #998
- Unable to remove Data Template with an External Data Source Profile
- Prevent their future creation
- Backport some html_escape() calls for convenience
2017-09-23 06:36:36 -05:00
cigamit b033b60dff Update CHANGELOG and One issue
- Update CHANGELOG from removespikes.php fix
- Allow manual creation of external data sources again
2017-09-23 06:04:51 -05:00
Javier e4cee8db29 Update Spanish Translation + 2 Spelling fixes (#991)
* Update automation_networks.php

Spelling mistake. "!" is enough to end the sentense

* Update automation_networks.php

* Add files via upload

Updating Spanish translation. Somehow at 98%

* Add files via upload

Updating Spanish translation. Somehow at 98%

* Update CHANGELOG
2017-09-21 07:07:08 -05:00
cigamit 6061e3ed96 Resolve Issue #982
- Data Source Profile size information not showing properly
- Missing some i18n on page
- Missing message when not Data Source Priofiles found
- Wrong format prefix on one i18n string
2017-09-17 20:04:08 -05:00