1) Sequencing was broken on non-templated Aggregates causing totals not
to function
2) Skip/Total Selectors for Aggregates not functional when creating
Non-Templated Aggregates
- Replaced deprecated each() for foreach()
- Removed unnecessary reset() calls used for resetting pointers of an array before iterating by a foreach() loop
Convert all core pages to use multiple column sort. There may still be
some pages around automation that are required to be migrated. However,
they will continue to operate as is.
Both form_end and form_save_button adds javascript to save the form.
This results in a race condition that one save can be deleting rows
while the other is saving.
If you are running in development, you have to issue these two commands
rename table settings_graphs to settings_user;
rename table settings_graphs_group to settings_user_group
There are still three steps to go in this overall. The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized. Note, at this point the
develop branch should be thought of as slightly unstable
This commit includes the conversion of one Cacti page to the new
validation paradigm. It includes the use of the following functions:
set_default_action() - set's the default page action if one is not set
isset_request_var() - check if a request var is set
isempty_request_var() - checks to see if a request var is set and empty
get_request_var_post() - get a post variable, but don't sanitize
get_sanitize_request_var() - get the request var and optionally
validate/sanitize it. Store result into Cacti global array.
validate_store_request_vars() - validate/sanitize a group of request
variables based upon an input array. Store all the validated/sanitized
variables into a Cacti global array.
The last function collapses quite a bit of Cacti validation code into a
single call which should simplify page creation without having to
implement templates.