Commit Graph
100 Commits
Author SHA1 Message Date
cigamit 492b3f8919 Resolving Issue #2744
Undefined index: password_change in auth_changepassword.php
2019-06-23 10:17:13 -05:00
cigamit acd2cdc4b3 Some missing i18n in User Login History
Also include missing status.
2019-03-02 13:14:49 -06:00
netniV f1082922c9 Resolving issue #2384
If current authentication method is set to None, change to Builtin.

To achieve this, the code will look for a valid administration user that will be used to reset the password.  This is achieved by searching for the Primary Admin, and then any admin with console access.  Once an admin has been found, the must_change_password and change_password flags are set, the password is cleared and the user is automatically logged in before being forced to change the empty password.

If no admin can be located, the script will die to prevent issues and allow manual fixing of the problem.  The simpliest way to do this would be to utilise the INSERT statement that is used for the 'admin' user in the cacti.sql's user_auth table, plus the INSERT for user_id 1 into the user_auth_realm table.
2019-02-14 14:41:54 +00:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit 9ac304d02b Two minor issues in change password
This change prevents wrapping of icon and browsers automatically
including a default user and password into the current password screen.
2018-10-20 09:27:42 -05:00
cigamit 499b7aeee2 Resolving Issue #2086
[1.2.0 Beta 1]Password change during install
2018-10-19 18:28:43 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
cigamit 15b90d52d8 Revert "Fixes issue 1717 and others (#1775)"
This reverts commit ca23733949.
2018-08-16 20:19:19 -05:00
Mark Brugnoli-Vinten ca23733949 Fixes issue 1717 and others (#1775)
* First round of changes for #1717

* Various QA fixes

* Further round of QA

* Add Content-Type to headers

* Another round of QA

* Allow full screen changepassword

* Redirect to permission denied page instead of displaying local message
2018-08-16 18:42:49 -05:00
Mark Brugnoli-Vinten 29bed92dc3 Resolving Issue #1824 (#1825)
* Resolving issue #1824

* Fix more fixes for REMOTE_ADDR
2018-08-11 11:08:27 -05:00
cigamit 2de208331f Resolving multiple issues with guest and template accounts 2018-08-07 18:22:31 -05:00
Mark Brugnoli-Vinten ed57331dfd Fixes for Issue 1729 and 1730 (#1747)
* Fixes QA issues with upgrades from older versions

* Redirect install/index.php to install/install.php

* Further QA fixes

* Ensure upgrade matches new password field length

* Add 'Installation In Progress' message

* Fix QA issues
2018-07-25 08:45:41 -04:00
Mark Brugnoli-Vinten 6bb5b36b64 PR for Issue #1716 and #1718 (#1720)
* Fixes for issues #1716 and #1718

* Add changelog details

* issue#1721 - Console Side Bar not correct on first login
2018-07-19 06:54:33 -04:00
cigamit 5aead0c8fe Resolving Issue #1665
Must change password not working for local users when main realm is not
local
2018-07-14 15:26:22 -05:00
cigamit dcb83a830f Provide visual notification that the password has been changed 2018-05-14 19:03:40 -05:00
cigamit 1a405ff2c1 Minor QA issue with password changing 2018-05-09 21:32:16 -05:00
cigamit a946b126b8 Change password page provides visible confirmation of password rules 2018-05-09 20:56:21 -05:00
cigamit a02f223f4e Additional sanitization for XSS for Issue #1457
- Also additional formatting and cleanup of some code
2018-03-17 08:20:29 -05:00
cigamit 671fa2f736 Regression and QA on Issue #1305
Missing some files and settings.  We should really just have a common
header function to reduce the chances of variation.
2018-02-04 14:09:56 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit dfc60cb4b7 Resolve four QA issues found while testing
-issue: basename function undefined during upgrade to 1.0.x
-issue: Storage API and translations required for Change password
function
-issue: ALTER IGNORE still throws an error when attempting to drop the
primary key
-issue: Data Source profile form API generates error when system is half
upgraded
2017-12-29 10:21:11 -06:00
netniV 979373fea4 Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled (#1129)
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled

Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.

Changes made are:

auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions

auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set

user_admin.php
* Use new compat_password_xxx functions

lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions

* Update CHANGELOG

* Fixup for Issue #1122, corrects some minor issues

* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122

Update log message to be warning notj ust a normal message

* Fix issue of local auth bypas

* Update CHANGELOG

Fix up CHANGELOG issues

* Update auth.php

Fix up formatting issues
2017-12-23 12:58:03 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
cigamit 1a14cbb440 Introduce new get_cacti_version function to reduce database calls on pages 2017-05-14 12:29:30 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit e2243f62d2 feature: Make Cacti more tolerant of empty PHP_SELF on some web servers 2017-04-22 08:22:01 -05:00
cigamit e5793b284b Adding more mobile features
Preparing for fullScreenMode support and more responsive fixes.
2017-04-12 17:34:51 -05:00
patrick 4d5bb9facb get_selected_theme()
- result of get_selected_theme() stored in vars
2017-04-06 18:00:38 +02:00
cigamit cea503a4d2 Resolving Issue #434
password_verify not compatible with php5.4-
2017-03-15 17:29:49 -05:00
Otis Lin 390f0f9045 Use password_verify instead of password_hash @ php5.5+ 2017-03-07 15:13:33 +08:00
cigamit 3c7ef42902 Resolving Issue #329
Also first step in resolving issue #186
2017-02-23 17:40:19 -06:00
Browniebraun 80d283762e Referring to an issue mentioned at the bottom of #320
Invalid wildcard set.
2017-02-23 13:15:40 +01:00
cigamit 75c6359894 Resolving Issue #329 2017-02-22 20:03:17 -06:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
cigamit e1b40143b5 Resolving Issue #182 2017-01-09 17:11:25 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit d70f9718dc resolve login redirect loops
Corner case where you have forced a password change, but have not
granted that permission to the user.  We are also now blocking the save
when the user tries to make this setting.

We need better interactions with the login screen under certain failure
modes.  But for now this is good enough.
2016-12-19 18:18:05 -06:00
cigamit 93007bc347 add jquery-migrate to work around issues 2016-09-20 20:04:27 -05:00
cigamit 81f39d4dc1 use html5 doctype 2016-09-05 13:38:14 -05:00
Browniebraun 769a02ece2 Force edge mode for IE
fix broken layout in IE11
2016-09-05 14:53:06 +02:00
cigamit 80b483b559 more prepared statements
preparing for turning off magic quotes
2016-08-27 17:26:53 -05:00
cigamit 63f80ec9d6 formatting 2016-05-22 10:16:08 -05:00
cigamit 37dfdb2edc change password redirection not working 2016-05-09 19:36:18 -05:00
Browniebraun 61d9812fbb i18n updates 2016-04-26 21:59:46 +02:00
Micke2k 9cf968a76c Fix for addparser error in auth_changepassword 2016-03-23 22:24:09 +04:00
cigamit 4451d8fb2a support strong password when changing passwords
correct a few spacing issues as well
2016-03-20 14:19:57 -05:00
Micke2k 0fe822a949 Added tooltip to changepassword
Fixed "ok" message when changing passwords.

Somethings that still needs to be looked at

1. can i read the friendly_name of the array with read_config_option? I want to read it from the array instead of typing it:

                    "Require Mix Case: " .read_config_option('secpass_reqmixcase') . "<br>" .

2. Because this function it still forces you to use a new password even to secpass_history default is set to 0. Change secpass_history default to 1 and remove it?

    if ($user['password'] == md5(get_nfilter_request_var('password'))) {
        $bad_password = true;
        $errorMessage = "<span color='#FF0000'>Your new password can not be the same as the old password.  Please try again.</span>";
    }

3. I had to add font-awesome since it wasn't referenced anywhere in themes. Better way to do it?

Any input is welcome!
2016-03-19 20:23:52 +04:00