Commit Graph
1834 Commits
Author SHA1 Message Date
Mark Brugnoli-Vinten 2b61c1bba3 Further fix for Issue 1723 (#1728)
* Issue #1723 - die() messages should include \n for better logging

This corrects issue #1723 where die() messages appear in log files without a new line character causing logs to appear corrupted.

* Replace \n with PHP_EOF to be platform independant.
2018-07-21 15:17:14 -04:00
cigamit 377dfb708f Resolving Issue #1726
Poor page performance editing a Graphs Graph Items
2018-07-21 13:51:59 -05:00
Mark Brugnoli-Vinten dd24dce799 Feature #1670: Improve Graph Management to show type of source for a graph (#1725)
* Feature#1670: Improve Graph Management to show type of source for a graph

This commit adds functionality as requested in #1670 by adding an extra column to the graph management page to display the source type of a graph ('None', 'Data Query', 'Template')

* Minor update to make column sortable
2018-07-21 14:37:57 -04:00
Mark Brugnoli-Vinten da8b5169b7 Feature #1588: Check that PHP can run a test file (#1722)
* Feature #1588: Check that PHP can run a test file

* Feature #1628 - Allow the User to define a initial Network Discovery during Setup

* Fix QA issue with PHP 5.4

* Replace \n with PHP_EOL

* Minor changes to tabs vs. space and PHP_EOL

Will have to update packages based upon this too.

* Another minor pull where PHP_EOL was removed
2018-07-21 12:12:25 -04:00
Mark Brugnoli-Vinten ef7a318ef1 Feature #1692 - Separate option for logging Input Validation issues (#1696)
* Feature #1692 - Separate option for logging Input Validation issues

This commit adds a separate option for feature #1692 to enable logging Input Validation issues even when developer mode is turned off

* Finalise renaming of developer_mode to log_validation for cleaner understanding

* Remove log_validation from legacy location
2018-07-21 11:44:06 -04:00
Mark Brugnoli-Vinten fde08a533f Issue #1723 - die() messages should include \n for better logging (#1724)
This corrects issue #1723 where die() messages appear in log files without a new line character causing logs to appear corrupted.
2018-07-21 08:31:57 -04:00
Mark Brugnoli-Vinten 6bb5b36b64 PR for Issue #1716 and #1718 (#1720)
* Fixes for issues #1716 and #1718

* Add changelog details

* issue#1721 - Console Side Bar not correct on first login
2018-07-19 06:54:33 -04:00
cigamit fbd1804930 Resolving Issue #1669
Console log header grammar issue
2018-07-14 15:31:42 -05:00
cigamit 5aead0c8fe Resolving Issue #1665
Must change password not working for local users when main realm is not
local
2018-07-14 15:26:22 -05:00
cigamit 43a45e63a2 Resolving Issue #1682
Slow Select Statement lib/api_automation.php
2018-07-14 15:10:29 -05:00
cigamit 179cd07b73 Resolving Issue #1711
Support specifying MySQL SSL file paths in the database API
2018-07-14 14:53:46 -05:00
cigamit d76b97f9a0 Resolving Issue #1710
RRDtool create command causes first update to fail
2018-07-14 14:28:04 -05:00
cigamit 06dd17ef56 Resolving Issue #1709
Dont warn when attempting to make updates in the past
2018-07-14 13:43:16 -05:00
Mark Brugnoli-Vinten 94240ac390 Fixes for issues #1589 and #1690 (#1706)
* Fixes for issues #1589 and 1690

This commit applies fixes for #1589 (Checking temporary folder is writable) and #1690 (Report a warning if collation is not utf8mb4_unicode_ci)

* Remove debug code
2018-07-14 11:23:23 -05:00
Mark Brugnoli-Vinten cab3863f2b PR for issues #1282 and #1700 (#1701)
* PR for issues Â#1282 and #1700

This pull request adds additional functionality for #1282 allowing network discovery to email upon completion and also corrects issues found during #1700 with unauthenticated mail causing errors to appear.

* Fix settings QA issue
2018-07-14 10:49:15 -05:00
Mark Brugnoli-Vinten 59c6896145 Feature #1703 - Add i18n to Graph Context Menu (#1705)
This commit adds i18n language facilities to the context menu displayed on graphs as per #1703.  It also adds a submenu icon to make it clearer that an entry has a submenu.
2018-07-14 10:47:26 -05:00
Mark Brugnoli-Vinten a89d8f816f Feature #1676 - Allow duplicate sysnames during network discovery (#1694)
* Feature #1676 - Allow duplicate sysnames during network discovery

This commit adds functionality to enable duplicate sysnames to be added to the system on multiple hosts.  An option will be visible in the settings of the Network being discovered to enable this functionality which is disabled by default to maintain the current level of functionality

* Fix QA issue with DB fieldname

* Locate field after add_to_cacti field

* Make Travis Happy

* Fix minor QA issue
2018-07-11 04:55:09 -05:00
Mark Brugnoli-Vinten e3f129076e Feature #1691 - Add a 'Copy graph' option to context menu of graphs (#1695)
* Feature #1691 - Add a 'Copy graph' option to context menu of graphs

This commit adds a 'Copy graph' option for feature #1691 to the context menu of graph images.

* Minor QA fix

* Minor QA fix
2018-07-11 04:46:30 -05:00
Mark Brugnoli-Vinten d3ee9512bf Fix for issue #1298 (#1702)
* Fix for issue #1298

* Minor QA fix
2018-07-11 04:39:09 -05:00
Petr Macek 7e557d4d97 resolving issue #1567 (#1685)
* resolving issue #1567

* Minor update.
2018-07-04 11:17:16 -05:00
Mark Brugnoli-Vinten c4442ff4de Issue #1674 - Threads and Processes values not migrated to Poller table during upgrade (#1679)
When upgrading to v1.2.0 a new set of fields are added to the Poller table to allow customisation of the number of processes/threads per poller.  That helps to vary the amount used if any given poller has more or less power than another.

However, the system-wide defaults should be migrated against each poller present in the poller table during the upgrade, otherwise both values default back to 1 which seriously increases the time to poll (especially if you have a super high timeout value).
2018-07-04 11:12:35 -05:00
Mark Brugnoli-Vinten 0259c84f48 Feature #1677 - Default Tree node sorting to be inherited (#1678)
* Feature #1677 - Default Tree node sorting to be inherited

This feature changes the default sorting option to be 'Inherited' when creating new nodes (including root ones) whilst editing a tree. This does not update existing ones to be inherited.

Note: if a DB has already been updated to 1.2, either downgrade and upgrade again or modify the sort_children_type default on the graph_tree_items table to be 0 rather than 1.  Failure to do so will result in manual sorting still being applied do to SQL/PHP assuming that a zero means no value!

* Minor change to update script.
2018-07-04 11:11:47 -05:00
cigamit efb3101cfd Resolving Issue #1658
Devices drop down should be filtered by Site
2018-06-17 13:40:21 -05:00
cigamit ac86cfe3b2 Resolving Issue #1660
Reports based upon Tree don't maintain graph order
Also some i18n misses
2018-06-17 09:15:55 -05:00
cigamit 3c62c19ccb Feature: Allow the SNMP Agent to be disabled
This feature is for larger sites who do not wish to run the SNMP Agent
in cacti.
2018-06-06 17:56:47 -05:00
DavidLiedke 52a60da5ae Update jquery.tablesorter.js to 2.30.5 (#1659)
... from 2.30.3
Thanks David!
2018-06-06 17:21:59 -05:00
cigamit 9a6dfec301 Resolving Issue #1601
Aggregate Graphs can not include some classes of COMMENT
2018-06-02 16:11:40 -05:00
cigamit 32f1538a4a Resolving Issue #1634
* Default snmp quick print setting resulting in false poller ASSERTS on
some php releases
* Also enhance the cacti snmp functions to require only 3 or 4
parameters.
* Minor format change to the vendor file classSNMP.php.  No functional
change.
2018-06-02 12:16:13 -05:00
cigamit 2f7b1b6737 Resolving Issue #1655
Correct Cacti to handle new MySQL 8.0 reserved word `system`
2018-06-02 08:45:47 -05:00
cigamit f04fa930a5 Update ChangeLog for Issue #289
Allow external nologin access for Realtime Graphs.  This was implemented
when we re-introduced the graph_realtime.php file.
2018-05-13 14:02:52 -05:00
Mark Brugnoli-Vinten ff9e10ca15 Issue #983: Import Template Preview is misleading (#1636) 2018-05-12 19:12:24 -05:00
cigamit cdc07937bc Resolving Issue #1621
Realtime Popup can cause automatic logout.  Plus some additional
enhancements to the popup realtime.
2018-05-12 19:10:46 -05:00
cigamit 866fc9340c Resolving Issue #1610
Script STDERR logging
2018-05-12 09:56:49 -05:00
cigamit 9fae81a959 Graphs: Add more information to error image 2018-05-11 19:08:00 -05:00
DavidLiedke c41bf0c4e1 Update c3.js to 0.5.4 (#1631) 2018-05-11 18:36:55 -05:00
DavidLiedke 3151cf62dc Update jquery.tablesorter.js to 2.30.3 (#1632) 2018-05-11 18:35:25 -05:00
cigamit 2a1b980271 Resolving Issue #1428
Graphs: Add more information to error image
2018-05-11 18:31:20 -05:00
cigamit d805be03d3 Resolving Issue #1521
Force boost to be enabled when there are Remote Data Collectors
2018-05-11 18:09:25 -05:00
cigamit 67163f6303 Resolving Issue #1437
Plugin install hover message sometimes shows line breaks rather than
formatted text
2018-05-11 17:48:07 -05:00
cigamit 37bcdd0c31 Resolving Issue #1383
CSRF Timeout does not obey session timeout
2018-05-10 20:39:17 -05:00
cigamit d14c50285b Resolving Issue #1590
User Admin generates SQL error if user is not part of any groups
2018-05-10 19:10:19 -05:00
cigamit a914c7f782 Resolving Issue #1607
Boost next run time occurs in the past
2018-05-10 18:49:20 -05:00
cigamit 27c8f958ba Resolving Issue #1606
Boost debug log not functional
2018-05-10 18:10:26 -05:00
cigamit 8d19c5a06b Allow ASCII filepath paths to not be found on settings save
This was reported in 1.1.x and now is solved by distinguishing betwen
binary, which must exist, and ascii, which can be empty as they may be
created later.
2018-05-10 17:57:34 -05:00
cigamit a18f6618e2 Resolving Issue #1626
httpd-error.log have message about Fontconfig
2018-05-10 17:14:42 -05:00
cigamit ea4e83cc07 Resolving Issue #1608
Possible boost race conditions
2018-05-10 07:41:01 -05:00
cigamit a946b126b8 Change password page provides visible confirmation of password rules 2018-05-09 20:56:21 -05:00
Mark Brugnoli-Vinten 184007a907 Feature #1597: Ensure synchronised files have same attributes as originals (#1599) 2018-05-08 17:14:00 -05:00
Mark Brugnoli-Vinten 95dc7d1d92 Issue #1617: Editing a data query results in missing $header variable (#1618) 2018-05-08 17:13:43 -05:00
cigamit 80ee8be81d Resolving Issue #1609
Remote pollers update 'stats_poller' on main poller
2018-05-06 13:38:52 -05:00