Commit Graph
55 Commits
Author SHA1 Message Date
netniV 4cecb19f6b PHP Fatal error: Uncaught Error: Cannot pass parameter 5 by reference in graph_json.php:158
Closes #3104
2019-11-27 23:09:59 +00:00
ddb4github d5f98679a0 Fixed #3049(due to #2964) to add missed argv for most rrdtool_function_graph caller (#3087)
* Fixed: #2964 to add missed argv for all rrd_function_graph caller

* Fixed #2964: Apply security solution to aggregate graph preview and graph impage page
2019-11-17 14:15:41 -06:00
cigamit 9a1d2ec46d Resolving Issue #2964
Missing security user pass in graph_realtime.php for "Security issue allows to view all graphs"
2019-11-09 12:24:11 -06:00
cigamit 3449887359 Resolving #3012
* Some graph routines are not properly validating incoming variables
* There is a second part to this.
2019-10-12 14:25:28 -05:00
netniV 553665944a Some graph routines are not properly validating incoming variables
Closes #3012
2019-10-07 16:06:54 +00:00
cigamit 681b7f8c1b Correct visibility issue in Paper-plane 2019-09-28 21:29:39 -05:00
cigamit 65c85b0760 Resolving Issue #2892
* Realtime log non ordinary message
* This is new in develop.  Therefore, no CHANGELOG
* Also, don't log to standard output when updating single data source in boost.  It breaks REALTIME.
2019-09-28 15:48:44 -05:00
cigamit 184cd55ba2 Resolving Issue #2966
Realtime does not always track size and other settings well
2019-09-22 18:19:49 -05:00
netniV a0950bf10e Revert "Honor php.ini when php is used in exec() and shell_exec() calls (#2652)"
This reverts commit 33641a9abb.
2019-04-29 12:45:02 +00:00
netniV 1c6139f667 Revert "Correct a few misqueues on #2652"
This reverts commit 3e3ba86f23.
2019-04-29 12:44:53 +00:00
netniV a2d3fd8776 Revert "WIP: php argument composition (#2653)"
This reverts commit 8a23ca33e3.
2019-04-29 12:43:03 +00:00
David Runge 8a23ca33e3 WIP: php argument composition (#2653)
* Moving all argument composition for backgrounded calls of php to 'assemble_php_args()' in /lib/functions.php.

* lib/functions.php: Explicitely prepending all assembled arguments.

* lib/functions.php: Removing an accidental appending of the initial args in assemble_php_args().
2019-04-29 13:38:17 +01:00
cigamit 3e3ba86f23 Correct a few misqueues on #2652 2019-04-27 11:48:57 -05:00
David Runge 33641a9abb Honor php.ini when php is used in exec() and shell_exec() calls (#2652)
* Introducing the prepending of the current php.ini file, if any, to the extra arguments of backgrounded php calls (used with exec_background).
This enables the backgrounded process to stay in the same environment as the main one and not default back to a system wide default configuration file (which might or might not have configurations setup properly).

* Prepending the current php.ini in use (if any) to any exec() or shell_exec() call, that is doing a backgrounded call of the php executable.

* graph_realtime.php: Fixing missing whitespace between executable and first argument.
2019-04-27 21:32:32 +06:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit ebf1c6c5ac Resolving Issue #2270 Realtime Graphs Taking Large Memory
Resolving this and a few other minor memory leaks.  Everything should
and have been validated to be working properly now.  There were a few
additional issues I found in performing a full regression.
2019-01-04 17:35:18 -06:00
cigamit cef4bd8671 -issue: align attribute is deprecated, use class instead 2018-11-10 11:35:55 -06:00
cigamit d25bf4878b Resolvng Issues #2084 and #2079
Non numeric value in graph_realtime.php and warnings about unvalidated
requrest variables.
2018-10-18 05:38:58 -05:00
cigamit 3ffd38a784 Minor update related to issue #2054
This catches one corner case related to realtime.
2018-10-11 17:38:33 -05:00
cigamit a45f33ce5f Resolving Issue #2052
[1.2.0 Beta 1] Issue with Realtime on new login
2018-10-11 06:51:26 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit cdc07937bc Resolving Issue #1621
Realtime Popup can cause automatic logout.  Plus some additional
enhancements to the popup realtime.
2018-05-12 19:10:46 -05:00
cigamit 96f62fe610 Resolve Issue #1527
Update Fontawesome from 4.7 to 5.0.10
2018-04-22 09:24:27 -05:00
cigamit cc831495bc Add better formating to the realtime popup 2018-03-18 12:11:14 -05:00
cigamit 8e7b84963d Resolving Issue #1305
Realtime not working for the main data collector.
2018-02-07 17:04:52 -06:00
cigamit d3536ed321 Consolidation for Issue #1305
Code reduction by making all the header into a function.
2018-02-04 22:01:16 -06:00
cigamit 671fa2f736 Regression and QA on Issue #1305
Missing some files and settings.  We should really just have a common
header function to reduce the chances of variation.
2018-02-04 14:09:56 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Tony Roman 1a47a23b04 fixed issue with realtime cache cleanup removing all files 2017-07-10 00:12:55 -04:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit e5793b284b Adding more mobile features
Preparing for fullScreenMode support and more responsive fixes.
2017-04-12 17:34:51 -05:00
patrick 4d5bb9facb get_selected_theme()
- result of get_selected_theme() stored in vars
2017-04-06 18:00:38 +02:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit 93007bc347 add jquery-migrate to work around issues 2016-09-20 20:04:27 -05:00
cigamit 7b5e199bfd i18n on graph_realtime.php 2016-05-22 10:12:48 -05:00
cigamit 1b5cadfa43 make legacy realtime work in mrtg view 2016-04-02 16:25:18 -05:00
Micke2k a89c8df192 fixing chrome looping issue on mrtg realtime
also fixed some dependencies.

realtime graphs still not working though.

Are we deprecating this feature ? Its not as nice as the other one, but i like the popup feature.
2016-04-01 18:41:40 +04:00
cigamit f003bc7020 save the correct realtime window
important to remember that window between page refreshes
2016-03-19 15:32:41 -05:00
cigamit 5b79aafde5 fixin legend display on realtime 2016-03-19 14:21:12 -05:00
cigamit 406aafb9f9 fixin issues with many realtime graphs active 2016-03-19 12:16:13 -05:00
Browniebraun e467431d07 - add option to force Cacti using local storage only for a dedicated operation. (avoids that Realtime sends its data to the RRDproxy) 2016-03-11 22:42:25 +01:00
cigamit 9f79d702f3 rename settings_graphs to settings_user, rename settings_graphs_group to settings_user_group
If you are running in development, you have to issue these two commands
rename table settings_graphs to settings_user;
rename table settings_graphs_group to settings_user_group
2016-02-14 14:26:48 -06:00
cigamit f2edfcbe53 update theme to a user setting 2016-02-14 10:48:34 -06:00
cigamit 14ce142b3c resolve some issues with realtime and get_filter_request_var() function 2016-02-14 09:34:41 -06:00
cigamit 2387bd4a08 removing many $_GET, $_REQUEST, and $_POST variable usage
There are still three steps to go in this overall.  The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized.  Note, at this point the
develop branch should be thought of as slightly unstable
2016-02-07 12:51:49 -06:00
cigamit da34108e21 remove use of deprecated function get_request_var_request(). replace it with get_request_var()
this is part three of project to remove the use of $_GET, $_REQUEST, and
$_POST in the code.  Parts one and two have already been completed.
Part one was to remove the use of $_GET throughout the code, part two
was the incorporation of wrapper functions to handle specific
validation, verification and sanitization cases.  This third part will
remove the use of the get_request_var_request() from the code.  Part
four, and beyond will include the removal of both $_REQUEST and $_POST
super globals from the code.
2016-01-30 15:53:08 -06:00
Micke2k d188f1631d Change Copyright year 2015 -> 2016 2016-01-29 21:46:02 +04:00
cigamit f029f83083 resolve multiple issues with realtime
fixin some minor formatting too.
2015-11-22 14:49:25 -06:00