Commit Graph
141 Commits
Author SHA1 Message Date
Rob Woodward a7ab675e26 Fix for issue #3073: autom8 network range treats start and end… (#3075) 2019-11-09 03:38:44 +00:00
netniV 0b1014b786 Automation network range with spaces fails validation
Closes #3017
2019-10-11 09:33:02 +00:00
netniV 97d8a27aef Automation does not calculate network information correctly for single hosts
Closes #2862
2019-08-16 13:05:12 +00:00
cigamit b87747c38b Resolving Issue #2839
Non regular expression search filters don't support international characters
2019-07-24 18:05:17 -05:00
cigamit 62815816ef Resolving Issue #2661
* Automation - Wrong network/netmask calculation
* This should get a more comprehensive redesign at some point.
2019-06-23 11:51:41 -05:00
Petr Macek 63cde6396c Record rule used during automation and provide link when viewed via clog (#2726)
* modify log message - add rule name

* Change log message - insert ID instead of Name

* add regex for rule name

* Updating Changelog for issue #2726
2019-06-09 21:50:19 +01:00
cigamit 99c060bf62 Resolving Issue #2685
Cacti AUTOM8 creates same multiple graphs
2019-05-18 15:55:39 -05:00
cigamit 29f00f8c46 Resolving Issue #2672
Cacti Install on Windows Fails
2019-05-07 22:30:41 -05:00
cigamit 8b2b87b37b Resolving Issue #2649
Automation not creating graphs when there are custom items
2019-04-27 20:46:24 -05:00
cigamit ecfded4734 Resolving Issue #2469
Assumed things were working.  Did not test enough.
2019-02-28 07:50:35 -06:00
cigamit 97ec8ca244 Resolving Issue #2469
Automation - Graph rules - matching object filter - unexpected redirect
2019-02-28 07:27:14 -06:00
cigamit 8d6c74a9e0 Resolving Issue #2393
Graph Automation creates duplicate graphs every time reindex the host
2019-02-23 11:15:11 -06:00
cigamit e673dd9882 Resolving Issue #2373
Automation SQL errors
2019-02-05 08:05:09 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit 44ef68fe7f Additional loose ends on issue #2219
More cases.  There may be more, but expect that they have minor or no
impact.
2018-12-20 17:15:09 -06:00
cigamit 42b02421cc Correct additional vectors, missing i18n, and light reformatting 2018-12-16 11:20:43 -06:00
cigamit 59681ce586 Resolving Issue #2173
This commit resolves sub issues 1) and 2) in issue #2173.  Sub issue 3)
is still being worked.  This change also widens multi-selects for
readability.
2018-11-20 21:16:53 -06:00
cigamit 87eac6e782 Add secondary protection against automation running on remotes 2018-10-13 14:28:19 -05:00
Mark Brugnoli-Vinten 07150a3643 Resolving issue #1927 (#1929) 2018-09-15 08:47:00 -04:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 0e609ce7fe Minor log format change 2018-09-02 11:09:42 -05:00
cigamit 0ccf7cd1e4 Adding instrumentation for debugin #1536
This will help in troubleshooting
2018-08-19 18:52:19 -05:00
cigamit 1450eb9814 Remove additional automation issues
Due to the movement of include to require
2018-08-11 12:46:44 -05:00
Mark Brugnoli-Vinten 8ea17f0093 Resolving Issue #1350 (#1753)
* Ensure previously selected field isn't wiped when ediing automation rule item

* Resolving Issue#1350

As per #1350, when switching an Automation Tree Rule's leaf type, remove invalid Automation Rule Items (Object Selection and Tree Creation criteria)
2018-07-26 08:36:21 -04:00
cigamit 43a45e63a2 Resolving Issue #1682
Slow Select Statement lib/api_automation.php
2018-07-14 15:10:29 -05:00
cigamit a34dd3538d Minor change due to audit 2018-06-09 11:14:56 -05:00
cigamit fc32222f2e Minor logging changes per standard logging interpretation 2018-05-12 09:37:23 -05:00
cigamit 4cddb42494 Formatting changes to automation api 2018-05-10 19:26:18 -05:00
cigamit 35d9d3df75 More uQueryUI classes and form QA 2018-05-09 21:59:08 -05:00
cigamit 96f62fe610 Resolve Issue #1527
Update Fontawesome from 4.7 to 5.0.10
2018-04-22 09:24:27 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
netniV 5bc95d0f76 issue #1459: Automation filter not applied correctly (#1460) 2018-03-09 07:07:40 -06:00
netniV cda6a03e56 1.2.x - issue #1347 - Update automation logging to work better (#1410)
* issue #1347 - Update automation logging to work better

* Remove debug code from lib/clog_webapi.php

* Further automation updates to include PID for diagnoses/filtering

* Ensure we have rows before attempting to loop through them

* Fix CI error

* update chines po file (#1403)

Signed-off-by: snsupersharp <snsupersharp@163.com>

* Typo in layout.js
2018-02-26 21:21:09 -06:00
cigamit ed939f07ef Make Travis Happy 2018-02-03 13:42:05 -06:00
cigamit 7b60a000a8 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	lib/api_automation.php
2018-02-03 13:36:09 -06:00
cigamit 1a79fe7d9b Resolving Issue #1300
- Automation discovery : New devices added by automation discovery have
empty SNMP community field.
- Correct two missing i18n issues
- Convert htmlspecialchars() use to html_escape() instead
2018-02-03 10:14:29 -06:00
netniV 27e858e089 issue#1040: Correct sizeof() issues with get_data_query_array() and get_graph_group() results (#1299) 2018-02-03 06:59:20 -07:00
cigamit 9826eb12c2 Make some variable naming more consistent 2018-01-21 11:26:44 -06:00
cigamit 7dd77278fc Make snmp variables more consisten
This change includes:
1) Using common setSNMP() global function
2) Rename snmp_readstring to snmp_community
3) One i18n Issue in automation_snmp.php
4) Reorder SNMP Form to be consistent with remainder of Cacti
5) Add SNMP security_level to the form

There remains some additional QA to do including inclusion of the SNMP
Engine ID which is not consisten accross all interfaces as well as an
issue in settings related to the pages JavaScript.
2018-01-14 18:00:08 -06:00
cigamit bdf047c182 Make snmp variables more consisten
This change includes:
1) Using common setSNMP() global function
2) Rename snmp_readstring to snmp_community
3) One i18n Issue in automation_snmp.php
4) Reorder SNMP Form to be consistent with remainder of Cacti
5) Add SNMP security_level to the form

There remains some additional QA to do including inclusion of the SNMP
Engine ID which is not consisten accross all interfaces as well as an
issue in settings related to the pages JavaScript.
2018-01-14 17:49:40 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 8ee60a9168 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	include/global_arrays.php
2017-12-24 08:54:22 -06:00
cigamit 8a42ab3aa7 Some pagination not translated into foreign languages 2017-12-24 08:11:25 -06:00
Tony Roman 6732e2ddd8 Fix up data input whitelist for realz 2017-11-22 12:22:42 -05:00
cigamit 966e38a866 Make Item numbering i18n consistent 2017-11-19 15:02:18 -06:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
2017-11-18 09:44:33 -05:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00