Commit Graph
448 Commits
Author SHA1 Message Date
ddb4github 473e452730 Fixed: Support percent sign(%) in graph gprint item like legend area. (#3098)
* Fixed: Support percent sign(%) in graph gprint item like legend area.

* Fixed: Keep single percent sign(%) in non-gprint item

* Update rrd.php
2019-11-26 10:46:54 -05:00
cigamit cfb0733597 Fixing Issue #2964 Differently
* CVE-2019-16723 Security issue allows to view all graphs
* Thischange restores the check inside of lib/rrr.php and updates all but on calling of the graph function to include the user.
2019-10-19 08:01:39 -05:00
cigamit 51a96258d3 Minor fix for issue #2975
This is a hack since i18n changes may not work by setting localization on Windows.
2019-09-26 07:40:18 -05:00
cigamit 5b4d2b51a3 Resolving Issue #2975
RRD items erroneously marked as false in Data Source Info and Troubleshooter
2019-09-25 19:07:29 -05:00
cigamit ed397e563a Resolving Issue #2962
This should correct the boost and dsstat's issues.  There were a few hands on this one and it had not undergone a full regression in a while.

This update should speed things up pretty signifcantly.

First, don't check the last_update time if rrdtool is >= 1.5
Second, we can accurately assume that the filemtime() is the last update time.  This speeds things up dramatically.
2019-09-22 10:29:13 -05:00
browniebraun 061f74cb54 Support newest version of RRDproxy
Support new string format of RRDproxy v1.2.7.
2019-09-19 21:53:44 +02:00
cigamit 9edb9ef886 More testing on issue #2930
The function was actually not working.  So, using a function that searches from the end, and passing by reference to for an additional speedup.
2019-09-15 10:48:32 -05:00
cigamit 1c746cf7e0 Minor modification to trim function around #2930
This will speed up the function.
2019-09-11 06:10:53 -05:00
cigamit a2c01f8c2b Resolving Issue #2930
* When working in pipe mode RRDtool appends stderr to stdout causing SVG graphing to break
* Removing GIF87 as it's no longer supported
* Adding new Trim function
2019-09-10 21:02:35 -05:00
cigamit 75ecd5e0f1 Revert "Resolving Issue #2930"
This reverts commit e3514b8885.
2019-09-10 21:00:51 -05:00
cigamit e3514b8885 Resolving Issue #2930
* When working in pipe mode RRDtool appends stderr to stdout causing SVG graphing to break
* Remove GIF87 as it's no longer supported
2019-09-10 21:00:20 -05:00
cigamit 2b061e0729 Another tweak on issue #2925
Just some variable changes and an audit of the code just to ensure everything is correct.
2019-09-10 21:00:20 -05:00
cigamit 027d701f1b Resolving Issue #2925
Problem with consolidation function after upgade to 1.2.6
2019-09-04 23:44:56 -05:00
jav4 04f6dc9044 Use pipes to allow long command lines in rrdtool for aggregate graphs (#2896)
* Update rrd.php

* Update CHANGELOG

* Update CHANGELOG
2019-08-15 22:15:38 -05:00
cigamit 4369c7b0e8 Resolving Issue #2848
Aggregate graphs get clipped due to incorrect date range
2019-08-12 06:55:29 -05:00
cigamit 2773b94443 Resolving Issue #2833
Undefined index in lib/rrd.php under certain circumstances
2019-07-18 20:09:25 -05:00
cigamit 9b95f93d47 Resolving Issue #2656
This has finally fixed the issue.  Was specific to Aggregate Graphs.
2019-06-23 20:48:04 -05:00
cigamit 9b0fbfb15d Resolving Issue #2656
Wront host_id was being passed
2019-06-23 19:19:35 -05:00
cigamit 09b4f6f660 Resolving Issue #2656
GPRINT text_format does not replace Data Query and Host Fields
2019-06-23 19:03:23 -05:00
cigamit 756b0779c6 Resolving Issue #2721
Undefined index 'local_data_id' in lib/rrd.php when replacing '|input_xxxx|' strings
2019-06-08 10:47:36 -05:00
Matt Corallo 0dcf1532ba Fix percentile calculation (#2720)
The percentile calculation sorting ends up using incorrect step length due to incorrect sorting. I'm not actually 100% sure what the intended behavior here is, so I left it as sorting by step first, and steps second, though on my graphs steps seems to work just fine.
2019-06-07 13:34:10 +01:00
cigamit d0c3ab0daf Resolving Issue #2662
* HRULE objects broken in some cases
* Also two missed escapeshell* change
2019-05-12 06:48:22 -05:00
cigamit 88aafbd43c Resolving Issue #2547
Trailing spaces: Complaining about Max values in RRD without reason
2019-03-23 19:41:31 -05:00
NotAProfessionalDeveloper c3195c1be2 Remove grocer's apostrophes (#2546)
https://blog.oxforddictionaries.com/2011/02/04/random-apostrophization/
2019-03-22 15:58:43 +00:00
cigamit 0964412f19 Resolving Issue #2502
Unable to have a min or max value for RRDfile at zero '0'
2019-03-10 10:17:21 -05:00
cigamit cc3412405e Remove debugging 2019-03-10 07:13:12 -05:00
cigamit 92721ddb95 Resolving Issue #2500
Allow Data Source repairs from the Data Source Debug and Data Source Info pages
2019-03-09 15:15:00 -06:00
netniV fd5efad6cd Minor relayout of code to make clearer 2019-03-09 16:14:00 +00:00
cigamit a94e658807 Resolve info mode problems
The max value of 'U' was not properly recognized.
2019-03-08 18:18:40 -06:00
cigamit 47eb42f901 Resolving Issue #2497
Graph URL's missing either graph_start or graph_end but not both result in both taking defaults
2019-03-08 06:41:59 -06:00
netniV 44c16d9cb7 Resolving issue #2491 and 2493
issue#2491: Data Source Info suggests commands RRDTool can't honor
issue#2493: Data Source Info is not separated properly
2019-03-07 23:30:03 +00:00
cigamit bfafec057a Correct misspelling of variable 2019-02-25 18:10:01 -06:00
cigamit e81fbf4a8f Change for Issue #2283
This changes makes a slight mdification to the HRULE replacement logic
in hope to address #2283
2019-02-25 18:10:00 -06:00
cigamit 4d0f86ba0e Enable cdefs to include ifSpeed and ifHighSpeed 2019-02-19 21:26:18 -06:00
netniV 95f37c75bc Resolving issue #2342
Undefined variable: graph_start and Undefined variable: graph_end in lib/rrd.php
2019-02-19 14:05:34 +00:00
cigamit 76379db464 Remove tracing from rrd.php version of this function 2019-02-18 19:23:40 -06:00
cigamit 4ad7ef22d3 Add Tracing for #2364 2019-02-10 02:33:16 -06:00
cigamit 586e1b3773 Resolving Issue #2362
No way to default an interface speed when ifSpeed and ifHighSpeed come
back as zero
2019-02-03 08:58:48 -06:00
cigamit cd14f260dd Resolving Issues #599 and #2365
This is a major bug fix to Aggregate.  Also found a bug in rrdtool that
we will have to work around.
The upside of the bug fix for #2365 is that it appears to have fixed
#599 and also an issue with legend alignment.  Legends should always
align nicely now.
2019-02-01 18:22:28 -06:00
cigamit a6af484044 Simplify string padding logic for readability, remove duplicated code as well 2019-01-31 07:16:16 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit cbdd3a0f66 Resolving Issue #2321
Date separator not being used properly for graphs
2019-01-18 07:57:57 -06:00
netniV 89f0a06216 Resolving issue #2304 and #2311
This commit corrects a previous unseen issue where the PHP environment at command line level is being populated with environment variables normally only seen when called from a web server.

issue#2304: Installation progress stays at 0%
issue#2311: Unable to update PHP location during installation due to incorrect CLI environment

The new check uses the php_sapi_name() function to verify that we are indeed at 'cli' level.  All other values returned by php_sapi_name are considered non-cli including 'cli-server' which is for client/server scenarios.

Most checks have now been replaced by a single defintion ('CACTI_CLI') to define whether in CLI mode.  If a script is only to be called from CLI it must either defined 'CACTI_CLI_ONLY' or include include/cli_check.php instead of include/global.php.
2019-01-15 13:57:50 +00:00
cigamit 6200df6c7c Restore data debug functionality 2018-12-17 15:08:30 -06:00
netniV 882664eac8 Resolving issue #2049 2018-10-11 10:14:56 +00:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
Mark Brugnoli-Vinten 51ee26ce1a Resolving issue #1689 (#1779)
* Resolving issue #1689

As noted in issue #1689 (Technical Support's RRDTool version should show
detected RRD version) the version of the RRDTool is never actually displayed.
The code has now been updated to properly handle versioning and displays both
the configured and installed versions.

The setting for rrdtool_version has been updated to a proper minimum version
number so that the cacti_version_compare() function may be effectively used.
This means that the constant values of RRDTOOL_VERSION_1_3 through
RRDTOOL_VERSION_7 have now been removed from the system.

* Some QA updates

* Further QA fixes
2018-08-02 18:01:25 -05:00
Mark Brugnoli-Vinten 33aa71448e Feature 1734 - Visual enhancements to RRD error message when file not found (#1755)
* Remove unnecessary issues

* Feature #1734 - Visual enhancements to RRD error message when file not found

This commit adds a visual enhancement to the RRDTool's file not found error.

* Further improvements
2018-07-26 21:32:54 -04:00
cigamit d76b97f9a0 Resolving Issue #1710
RRDtool create command causes first update to fail
2018-07-14 14:28:04 -05:00
cigamit 06dd17ef56 Resolving Issue #1709
Dont warn when attempting to make updates in the past
2018-07-14 13:43:16 -05:00