Commit Graph
54 Commits
Author SHA1 Message Date
netniV 6108e8759d Further resolve #2513 2019-03-13 16:35:57 +00:00
netniV 086b5c78df Resolving issue #2513
When a plugin INFO file is malformed or missing elements, plugin_load_info_file() should fill missing elements with defaults which are now defined as:

'name'      => directory holding info file
'requires'  => blank
'longname'  => directory holding info file (first letter is uppercased)
'status'    => 0
'version'   => 0.0
'author'    => 'Unknown'
'homepage'  => If webpage is set, use that otherwise 'Not Stated'
'directory' => directory holding info file

This will ensure consistency and that any attempts to use a key such as requires will be present.
2019-03-13 13:17:15 +00:00
netniV c996d8faea Add severity to log for missing receivers, only record low priority first time 2019-02-15 15:10:20 +00:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
Hans e653a70a7b line 318, typo (#2291)
snmpagent_cache_unistall(); should be 		snmpagent_cache_uninstall();
2019-01-08 18:28:31 +00:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 632cdf7115 Resolving Issue #1849
SNMPAgent not sending traps
2018-08-19 13:40:01 -05:00
Mark Brugnoli-Vinten 51ee26ce1a Resolving issue #1689 (#1779)
* Resolving issue #1689

As noted in issue #1689 (Technical Support's RRDTool version should show
detected RRD version) the version of the RRDTool is never actually displayed.
The code has now been updated to properly handle versioning and displays both
the configured and installed versions.

The setting for rrdtool_version has been updated to a proper minimum version
number so that the cacti_version_compare() function may be effectively used.
This means that the constant values of RRDTOOL_VERSION_1_3 through
RRDTOOL_VERSION_7 have now been removed from the system.

* Some QA updates

* Further QA fixes
2018-08-02 18:01:25 -05:00
cigamit 3c62c19ccb Feature: Allow the SNMP Agent to be disabled
This feature is for larger sites who do not wish to run the SNMP Agent
in cacti.
2018-06-06 17:56:47 -05:00
cigamit 33486bb8ca One more minor change for #1389
Make sure the status is 0 for not installed plugins.
2018-02-22 06:02:16 -06:00
cigamit 90ba5f9ad6 Resolving Issue #1389
Poller is including plugins that are not installed
2018-02-22 05:58:11 -06:00
cigamit 8bb423b606 snmpagent generates a Fatal error when plugin directories duplicated 2018-02-17 14:21:55 -06:00
cigamit e413c6a54a Make the snmpagent more consistent
The snmpagent plugin labeled snmp_password as snmp_auth_password and
snmp_priv_passphrase as snmp_priv_password.  This change aligns the
column names in the database between features.

Additionally, for most of Cacti, with the inclusion of noAuthNoPriv, the
snmp_auth_protocol needed to be expanded to 6 characters from 5.
2018-01-14 17:10:13 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 7a5d171711 Resolving Issue #1079
- Undefined index in lib/snmpagent.php
- Remove trailing whitespace from file
- Reformat some sql statements.
2017-11-16 06:26:11 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Tony Roman af5b4a8e19 Fix issue in SNMPagent cache causing extraneous log entries 2017-07-09 21:52:34 -04:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit dbcf514fb2 Resolving Issue #612
Uncaught Error: Call to a member function row() on a string.
2017-04-24 20:56:56 -05:00
cigamit b5e236e6ed Resolving Issue #506
Undefined index: cactiStatsDeviceFailedPolls showing in cacti.log
2017-04-01 12:16:22 -05:00
cigamit 68e4e115eb One last time on Issue #466 2017-03-22 20:21:53 -05:00
cigamit f26dcc7934 Second attempt to resolve issue #466 2017-03-22 20:04:21 -05:00
cigamit b7bacd18d1 Double check the math for an empty device entry. 2017-03-22 19:50:43 -05:00
Browniebraun 7f3cfa0d93 Addressing issue #263 2017-02-03 15:02:24 +01:00
cigamit 4c9d94792d Resolving Issue #201 2017-01-11 17:13:02 -06:00
cigamit 968afec9d6 Resolve another snmpagent install issue 2017-01-09 17:19:26 -06:00
cigamit ecf3bcc2d1 Correct addiitonal undefined table instances
This happens on install for Windows machines.
2017-01-07 13:42:35 -06:00
cigamit 68b5f36cb4 Resolving Issue #152 2017-01-07 09:39:52 -06:00
cigamit 7894c5fa8d Resolving Issue #156
Plus some code formatting for readability.
2017-01-07 09:32:13 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit cc8feb3f51 Remove deprecated call 2016-12-31 12:47:55 -06:00
Browniebraun 817265dc56 support usage of device specific SNMP Engine IDs for SNMPv3 notifications being sent to v3 receivers. 2016-12-29 23:31:54 +01:00
cigamit e1b06a5c9a partial resolution of bug#1042
this change will allow logging by file.  it's not quite by device and
plugin, but it is a start.
2016-09-16 22:03:36 -05:00
cigamit 06fb04f948 don't log snmpagent warnings 2016-08-30 18:20:44 -05:00
cigamit b523f1dea5 remove addslashes, prepared statements, wc3 validation, double to single quote
this is required for preparation of magic_quotes_gpc.
2016-08-28 15:27:48 -05:00
cigamit 44635148c9 Fix PHP error when changing settings on multiple devices at once
selected_ids is passed as an array not as a string (was unserialized in
host.php already)
2016-08-23 00:02:52 -05:00
cigamit bdcdde06ac resolving bug:2719
one issue remains, but it is related to setup.
2016-08-22 07:40:38 -05:00
cigamit fab1bc9f54 Stop old integrated plugins from breaking poller_bottom
If a user forgets to remove an old plugin that we integrated into Core,
the snmpagent plugin detection can cause the poller_bottom hook to not
function by trying to include files with duplicate function names
2016-06-26 22:44:07 -05:00
cigamit 19821f9c42 correct two issues with plugin integration 2016-05-17 16:45:09 -05:00
Browniebraun 4f8ba8d091 update core version of SNMPagent from 0.2.2 to 0.2.3 2016-05-08 22:56:37 +02:00
Browniebraun dfba135dbd SNMPagent did not take care of uninstalled plugins. 2016-03-24 17:42:37 +01:00
Micke2k f3d8f5a44e Attempt to remove ucd-snmp
Throws error during install:

[Wed Mar 02 17:34:19.867348 2016] [:error] [pid 51152] [client :25624] PHP Notice:  Undefined index:  in /lib/snmpagent.php on line 482, referer: http://cacti/install/index.php
2016-03-20 19:21:08 +04:00
Browniebraun f4df00aaad replace Boost server by RRDproxy 2016-03-10 21:43:10 +01:00
cigamit 56a39dd903 correct issue with undefined constants 2016-01-29 22:07:29 -06:00
Micke2k d188f1631d Change Copyright year 2015 -> 2016 2016-01-29 21:46:02 +04:00
cigamit 4e4dd6784a improve the processing of selected_items
improve the processing of selected_items to guard against sql injections
2015-06-17 07:05:53 -05:00
Andreas Braun 72e80c6b7e extend SNMPAgent's function ...global_settings_update to write some information about Boost into the cache.
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7698 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-14 06:30:42 +00:00
Jimmy Conner 0be7542b68 SNMPAgent should only be looking at installed plugins. Otherwise it can be blindly loading setup files for already integrated plugins which can break the poller (duplicate functions).
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7696 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-13 06:58:05 +00:00
Andreas Braun 79f6397789 - invalid table name
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7685 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-12 21:27:12 +00:00
Andreas Braun 73a61dfc55 add base frame of a new MIB for BOOST
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7682 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-12 20:43:32 +00:00