Commit Graph
173 Commits
Author SHA1 Message Date
cigamit 2c00d59b35 Resolving Issue #1097
Template user issues including:
- All template users should be disabled by default
- When a user is copied, enable that user by default
2017-11-23 12:30:56 -06:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
2017-11-18 09:44:33 -05:00
cigamit a179e8092d Resolving Issue #1066
Resolve second half of Issue #1066 which is CVE-2017-16661.
2017-11-11 07:39:13 -06:00
cigamit e8088bb659 Resolving Issue #1057
- Potential vulnerability in RRDtool functions
- Adding validation to both dirpath and filepath, also verification of
executable status to files in RRDtool function.
- Spurious htmlspecialchars() to html_escape() calls
- Minor SQL formatting for readability
2017-11-04 14:52:09 -05:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Arno Streuli cedc671eaa Feature/1.2.x (#979)
* Update cacti.sql

Added 2 entry for cn_full_name and cn_email

* Update cacti.sql

Change the size to 50

* Create 1_2_0.php

Added the change on table user_domains_ldap, to provide info for full_name and email

* Update global_settings.php

Added the 2 new entry as new section for LDAP settings:
ldap_cn_fullname
ldap_cn_email

* Update auth.php

Added the email address on user_copy function

* Update ldap.php

Added the ldap_search_cn to search 2 specific CN on LDAP server

* Update auth_login.php

Added the Get user CN part for new LDAP users

* Update ldap.php

little error on ldap_search inside Getcn function

* Update user_domains.php

Add option to manage Full name and email taken from LDAP server

* Update auth_login.php

Change for multidomain authentication

* Update global_settings.php

change the name ldap_cn_xxx to just cn_xxx

* Update ldap.php

Correction to the error number and message when the CN is not find

* Update settings.php

Added the visibility of CN fields only for LDAP authentication mode

* Update ldap.php

correct on line 729 missing $ before this->cn

* Update cacti.sql

column definitions consistent with the definitions under install/upgrades/1_2_0.php

* Update auth_login.php

correct tab, as space, and add {} in if else statment

* Update ldap.php

correction on cacti_log with $output['error_text'], correction on all error_num 99 as '99'
and made some correction int tab/space

* Update auth_login.php

add missing {} on else function
2017-09-16 15:51:56 -05:00
cigamit 3a8d4f7ff9 Use html_escape() over htmlspecialchars() for consistency and security 2017-09-04 21:26:27 -05:00
cigamit 111dbe1400 Change multiselect default hight. Make a bit larger 2017-07-29 12:23:00 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit 0de5c781f2 Resolving Issue #818
Unable to unselect all SpikeKill templates under settings
2017-06-27 19:57:51 -05:00
cigamit 37a5a7791a Resolving Issue #779
- Resolve randome apache segfault due to recursion.
- Also, remove additional references to export user
- Change the way the guest_account id is gathered.
- Change elseif format
- Remove trailing white-spaces
2017-06-08 07:42:22 -05:00
cigamit f7f025e6ae Finish resolution of Issue #756
Translation Issues
2017-06-03 20:15:52 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit bbcab5832e Resolving Issue #646
When a plugin is disabled in the middle of a page load by others, errors
can fill the log
2017-05-01 20:49:53 -05:00
cigamit ff125d01cb Update all pages to include div based forms
This requires a CSS change which is going to be committed next and
separately to call out the changes required there.
2017-04-30 13:15:58 -05:00
patrick cc1cc7eab2 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
2017-04-15 18:00:13 +02:00
cigamit 677fcfd776 Resolving part of Issue #214 2017-01-16 17:32:41 -06:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit 0b67a10ebf resolving bug#2361 2016-09-18 17:38:48 -05:00
cigamit 0040f5f69c another minor change related to bug#1042 2016-09-17 19:55:56 -05:00
cigamit 75a5442010 minor issues related to resolution of bug#1042 2016-09-17 19:30:52 -05:00
cigamit 496afaf34e resolving bug#1042 for plugin
still have device id's to complete.
2016-09-17 06:49:18 -05:00
cigamit e1b06a5c9a partial resolution of bug#1042
this change will allow logging by file.  it's not quite by device and
plugin, but it is a start.
2016-09-16 22:03:36 -05:00
cigamit a2925fc1a4 resolving bug#2348 2016-08-18 19:08:04 -05:00
cigamit ac9fbda633 adding some aria labels for accessibility 2016-05-23 09:22:58 -05:00
cigamit b1ae12a42d formatting on settings 2016-05-21 12:15:09 -05:00
cigamit 4aed4ddbd5 fix drop_multi to use settings 2016-05-13 14:50:38 -05:00
cigamit ba1cb2c120 merging spikekill
note it's not fully functional right now.
2016-05-13 13:07:37 -05:00
Browniebraun e08071f4ac i18n updates 2016-04-24 22:41:14 +02:00
Browniebraun f4df00aaad replace Boost server by RRDproxy 2016-03-10 21:43:10 +01:00
cigamit 847b737c81 remove developer debug logging 2016-02-14 13:09:16 -06:00
cigamit f2edfcbe53 update theme to a user setting 2016-02-14 10:48:34 -06:00
cigamit d27c2e9c23 two minor changes for header variable 2016-02-13 09:47:45 -06:00
cigamit 26053b7527 replace deprecated get_request_var_post() with get_nfilter_request_var()
replace the deprecated calls and also start developer mode injection
checking
2016-02-11 16:46:14 -06:00
cigamit 2387bd4a08 removing many $_GET, $_REQUEST, and $_POST variable usage
There are still three steps to go in this overall.  The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized.  Note, at this point the
develop branch should be thought of as slightly unstable
2016-02-07 12:51:49 -06:00
Linegod dabfabf219 replace ['action'] with set_default_action 2016-02-06 09:57:05 -06:00
cigamit da34108e21 remove use of deprecated function get_request_var_request(). replace it with get_request_var()
this is part three of project to remove the use of $_GET, $_REQUEST, and
$_POST in the code.  Parts one and two have already been completed.
Part one was to remove the use of $_GET throughout the code, part two
was the incorporation of wrapper functions to handle specific
validation, verification and sanitization cases.  This third part will
remove the use of the get_request_var_request() from the code.  Part
four, and beyond will include the removal of both $_REQUEST and $_POST
super globals from the code.
2016-01-30 15:53:08 -06:00
Micke2k d188f1631d Change Copyright year 2015 -> 2016 2016-01-29 21:46:02 +04:00
cigamit 4fc14f929d Remove deprecated tags and remove inline styles
Removing <strong> in many areas
Moving inline styles to classes
2015-08-09 19:55:44 -05:00
cigamit cffe729586 Fix settings initialization logic, workaround Firefox password caching
Insure ready function triggers all form dynamic logic.
Clear passwords in form display to prevent save errors.
Right align 'Send a Test Email'.
Minor correction to LDAP visibility logic.
2015-08-09 12:32:47 -05:00
cigamit e33f692d2c new form functions for ajax
add two new form functions to support ajax
move some double to single quotes
2015-06-15 00:14:43 -05:00
cigamit 017ca55c4e Major confirmation form standardization and QA phase 1
Major confirmation form standardization and QA Phase 1
New loadPageNoHeader function
Convert subTabs to use Ajax Load
Remove more inline styles
2015-05-30 12:03:05 -05:00
cigamit 7b629f8109 VN: JVN#78187936 / TN:JPCERT#98968540
correct JVN#78187936
2015-05-17 20:00:18 -05:00
cigamit f49357c71b HTML5 Support
changes to support html5
2015-05-15 22:29:42 -05:00
cigamit abdc1e3d55 Merging 0.8.8d Updates with GitHub
Changes include:
- Convert some <br> to </li>
- Update ChangeLog per 0.8.8d release
- Fix Max Values on UCD/SNMP Memory Template
- Change Cacti Group Format to Modern Theme
- Fix Locking on Graphs
- Force Image format to PNG for Legacy Graph Image
- Correct form Logic on Settings to Fix Reverse Proxy's
- Shorten Uptime Display on Device Edit
- Force a Locale Setting for i18n on Graphs
- Fix Resizable Columns to resize only the current column
- Add DropIcon selectmenu Widget to modern theme
- Fix Issue where delete data source multi leaves orphan records
- Correct performance bug in Boost engine
- Optimize array_to_sql_or performance
- Correct and issue where pushing out data query objects to host cache
could leave orphan elements
- Add OID_REWRITE_PATTERN Feature on input
- Add VALUE/REGEXP Feature on output
- Optimize strip_quotes function to be more intellegent
- Escape shell arguments on Script Data Input types
- Allow Special Characters for LDAP passwords
- Correct LDAP class defect for anonymous binding
- Bypass php-snmp for now
- Correct rrdcleaner bytes units
- Fix loadavg_multi.pl to respect i18n
- Remove legacy row counters from snmpagent pages
2015-03-23 17:02:45 -05:00
Jimmy Conner 455d855894 1) Convert double quotes to single quotes
2) Remove references to $_GET replace with $_REQUEST
3) Remove some inline styles

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7706 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-17 16:53:24 +00:00
Tony Roman 902ac97c7d Fixed and added:
1) Realtime integration complete
2) Added option to update sys OID's in spine and cmd.php
3) Updated poller as well
4) Made cmd.php argument processing sane
5) Remove one more 'rrdtool_graph' variant (aka Realtime)
6) Moved Realtime settings under Visual
7) Added some core Javascript utility functions
8) Added minimum width to dropdowns to make more appealing
9) Cleanup some redundant syntax in headers
10) Typos in format files


git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7678 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-12 18:04:03 +00:00
Jimmy Conner 262097062d 1) Correct visibility issues with Authentication methods
2) Insure that all form spacers can be collapsible, even with visibility 
events tied to them
3) Set initial visibility of the general header to none
4) Fix auth_profile.php to behave as expected, (save,return)
5) Minor tweak to graph_settings.php
6) New button function
7) Add some core jQuery functions

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7666 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-04 18:03:36 +00:00