Commit Graph
69 Commits
Author SHA1 Message Date
cigamit b87747c38b Resolving Issue #2839
Non regular expression search filters don't support international characters
2019-07-24 18:05:17 -05:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit f18860f3cd Alphabetize includes add missing lib/poller.php where applicable
This is required for properly having data follow devices, graphs, and
data sources on change.
2018-10-13 13:03:22 -05:00
cigamit 44190227f4 Resolving Issue #1926
This is easy enough.  Not a major change actually.
Some line ending fixes as well
2018-09-24 20:52:19 -05:00
Mark Brugnoli-Vinten 39efc75c49 Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939 (#1937)
* Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939

* Update import.php
2018-09-16 13:22:32 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 5d7bb410e0 Some pages missing colspan's for no rows found
Issue with message text wrapping when no rows found on some pages
2018-02-24 17:43:48 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 2c00d59b35 Resolving Issue #1097
Template user issues including:
- All template users should be disabled by default
- When a user is copied, enable that user by default
2017-11-23 12:30:56 -06:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
2017-11-18 09:44:33 -05:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 4680aa3a7e Correct remaining whitespace issues
Do a little cleanup of SQL queryies to use less horizontal space
2017-09-16 16:26:30 -05:00
Arno Streuli cedc671eaa Feature/1.2.x (#979)
* Update cacti.sql

Added 2 entry for cn_full_name and cn_email

* Update cacti.sql

Change the size to 50

* Create 1_2_0.php

Added the change on table user_domains_ldap, to provide info for full_name and email

* Update global_settings.php

Added the 2 new entry as new section for LDAP settings:
ldap_cn_fullname
ldap_cn_email

* Update auth.php

Added the email address on user_copy function

* Update ldap.php

Added the ldap_search_cn to search 2 specific CN on LDAP server

* Update auth_login.php

Added the Get user CN part for new LDAP users

* Update ldap.php

little error on ldap_search inside Getcn function

* Update user_domains.php

Add option to manage Full name and email taken from LDAP server

* Update auth_login.php

Change for multidomain authentication

* Update global_settings.php

change the name ldap_cn_xxx to just cn_xxx

* Update ldap.php

Correction to the error number and message when the CN is not find

* Update settings.php

Added the visibility of CN fields only for LDAP authentication mode

* Update ldap.php

correct on line 729 missing $ before this->cn

* Update cacti.sql

column definitions consistent with the definitions under install/upgrades/1_2_0.php

* Update auth_login.php

correct tab, as space, and add {} in if else statment

* Update ldap.php

correction on cacti_log with $output['error_text'], correction on all error_num 99 as '99'
and made some correction int tab/space

* Update auth_login.php

add missing {} on else function
2017-09-16 15:51:56 -05:00
cigamit 3a8d4f7ff9 Use html_escape() over htmlspecialchars() for consistency and security 2017-09-04 21:26:27 -05:00
cigamit 30bbf226f5 More changes for issue #861
Filters not working properly for i18n
2017-07-20 18:55:33 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit f850e57629 Freshed core filter html
In preparation for responsive filters phase II
2017-07-05 17:13:10 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit ff125d01cb Update all pages to include div based forms
This requires a CSS change which is going to be committed next and
separately to call out the changes required there.
2017-04-30 13:15:58 -05:00
cigamit b28f44a9d9 Add escaping to filter values prior to request.
Handles the sepecial case of a pound sign causing issues.
2017-04-23 07:35:01 -05:00
patrick d2185c98b1 PHP7.2 changes:
- Replaced deprecated each() for foreach()
2017-04-21 22:12:55 +02:00
cigamit 5a35089f8b Resolving minor jQuery issues 2017-03-25 15:04:38 -05:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
cigamit 3c9d5f7a93 Minor language change 2017-01-08 20:25:31 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit 1aa80816f2 standardize not found messaging 2016-08-31 16:23:20 -05:00
cigamit b523f1dea5 remove addslashes, prepared statements, wc3 validation, double to single quote
this is required for preparation of magic_quotes_gpc.
2016-08-28 15:27:48 -05:00
cigamit ce4f00acc9 rolling out new filter_value() function to all pages
additionally fixed several minor filtering bugs in many pages
2016-08-22 13:31:06 -05:00
cigamit 54d97035a2 large commit, separate table pager from tables
this change impacts all plugins and css.  css changes are included in
this commit.  plugin changes will be forthcoming.
2016-07-09 12:44:37 -05:00
cigamit 6e90fe2427 minor syntax fixes 2016-06-23 17:59:45 -05:00
cigamit 35993291a9 control the vertical size on a single action page 2016-06-18 15:19:35 -05:00
cigamit 34b5d19ce8 minor filter changes 2016-06-18 12:13:27 -05:00
cigamit c399664082 rows selector consistency 2016-04-27 12:41:02 -05:00
Browniebraun dfdee4e57a make use of i18n wrapper functions 2016-04-12 23:38:42 +02:00
cigamit c8b700abea fixin multiple issues
change includes moving constant definition to global, changing
pagination presentation, correcting  function name in graphs_new.php
2016-02-15 08:04:32 -06:00
cigamit 26053b7527 replace deprecated get_request_var_post() with get_nfilter_request_var()
replace the deprecated calls and also start developer mode injection
checking
2016-02-11 16:46:14 -06:00
Linegod f31c7b6835 first spellcheck pass 2016-02-07 23:12:03 -06:00
cigamit a3875aea8a completion of removal of $_REQUEST, $_GET, $_POST in base directory
the lib directory still must be updated.
2016-02-07 18:20:55 -06:00
cigamit 2387bd4a08 removing many $_GET, $_REQUEST, and $_POST variable usage
There are still three steps to go in this overall.  The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized.  Note, at this point the
develop branch should be thought of as slightly unstable
2016-02-07 12:51:49 -06:00
Linegod aeb6ae7174 correct isset_request_var 2016-02-06 11:24:45 -06:00
Linegod 8dadf2d9a9 first pass of _POST to get_request_var_post 2016-02-06 10:44:05 -06:00
Linegod dabfabf219 replace ['action'] with set_default_action 2016-02-06 09:57:05 -06:00
cigamit da34108e21 remove use of deprecated function get_request_var_request(). replace it with get_request_var()
this is part three of project to remove the use of $_GET, $_REQUEST, and
$_POST in the code.  Parts one and two have already been completed.
Part one was to remove the use of $_GET throughout the code, part two
was the incorporation of wrapper functions to handle specific
validation, verification and sanitization cases.  This third part will
remove the use of the get_request_var_request() from the code.  Part
four, and beyond will include the removal of both $_REQUEST and $_POST
super globals from the code.
2016-01-30 15:53:08 -06:00