Commit Graph
289 Commits
Author SHA1 Message Date
TheWitness ac29fd6f5c Additional fixup to #4816 - Regex Filtering
This change harmonizes the various pages and their use of regular expressions.
2022-06-13 08:40:30 -04:00
TheWitness 9676863d80 Fixing Issue #4818 - Regex widths
Regex widths are too narrow
2022-06-10 22:04:18 -04:00
e09b1bdb95 improve SQL query to search for nodes in tree view (#4813)
* improve SQL query to search for nodes in tree view

Removes one of the joins on the host table: by site_id. Logic behind
that join is unclear, and on first glance would return just the whole of
graph_tree_items. This behaviour may have gone unnoticed because a
default install of cacti comes without any sites defined (not even a
default one) and site_id may contain NULL. On the install where we
observed issue #4806, sites are defined however.

* add changelog entry

* Light correction to SQL

Co-authored-by: rb83 <>
Co-authored-by: TheWitness <thewitness@cacti.net>
2022-06-10 17:32:57 -04:00
TheWitness 1d007b94a9 Fixing #4748 and #4743 (#4750) 2022-05-01 12:57:22 +01:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness 183b334976 Fixing #4293 - Searching for host in site
Tree search does not take hosts belonging to a site into account
2021-07-01 16:47:12 -04:00
TheWitness 5a61793df2 Fixing Issue #4297 - RegEx's
RegEx not working in Graph Filters
2021-06-25 15:24:35 -04:00
TheWitness 36269461cb Additional fixup's to #4080
This change provides additional fixups.  Though the problems is really the regular expression and beyond Cacti's control.
2021-02-07 10:47:33 -05:00
TheWitness 23cad3bd6a Fixing Issue #4080 - Regular Expression Searching
- Cacti regular expression searching does not quote expressions
2021-01-23 10:51:27 -05:00
Datatech UK LtdandTheWitness 234f90cbab Only show sensitive graph information to Template Editors in the List View screen (#4049)
* Update main.css

Make it more obvious that a slider is disabled.

* Update main.css

Make it more obvious that a radio slider is disabled.

* Update cacti.sql

Fixed the default value for the 30 second polling and amended the default values for the 1 minute polling for new installs

* Add ability to Hide the Graph Drilldown icons from the graph_view.php and graph.php pages
The icons are on the right hand side of the graphs and the default behaviour is to display them unless you hide them per user in the permissions tab

* Updated CHANGELOG

* Change the Realm from 2001 to 27 as 100 and above are reserved for plug-ins.

* Formatting change for neatness.

* Update CHANGELOG to reference this ticket number. Changed Drilldown to Drilldowns

* Only show sensitive graph information to Template Editors in the List View screen

* Removed duplicate line from CHANGELOG

* Update CHANGELOG to reference this ticket number.

* Updated cacti.pot as requested

Co-authored-by: TheWitness <thewitness@cacti.net>
2021-01-17 14:11:56 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
58c4909775 Merge 3943 and 3513 from develop to 1.2.x (#3970)
* feature 3965, Add a value check if the input field is textbox in settings

* feature 3965, revert

* merge feature 3943 and 3513 from develop to 1.2.x

* Update CHANGELOG

* Update CHANGELOG

Co-authored-by: yboliu <yboliu@oc8636837557.ibm.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
2020-12-02 07:24:08 -05:00
TheWitness 7e01a98733 Use proper Cacti function for i18n compatible escaping. 2020-06-13 05:36:25 -04:00
netniV de5e60c97b Further XSS fixes for #3549 2020-06-08 07:10:20 +00:00
TheWitness 72baf7b63b Fixing More issues with #3549
Addressing remaining cases.
2020-05-30 17:29:59 -04:00
cigamit 06b606b8d3 Resolving Issue #3142
* Chrome sets graphs tree navigation view to width 0px
* Also correct issues with CSP migration
2020-01-17 18:33:47 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
netniV f1f57204bc Further fix for #3012 2019-10-21 10:00:26 +00:00
cigamit 05ee70d73b Implement graph_view.php change differently.
Relates to this commit: https://github.com/Cacti/cacti/commit/553665944a12aba521956d2ee5a45a41519649c7#diff-190af701aa28435aeae112419ec79c67
2019-10-13 14:23:35 -05:00
netniV 553665944a Some graph routines are not properly validating incoming variables
Closes #3012
2019-10-07 16:06:54 +00:00
cigamit 8eced673cd Resolving Issue #2677
* Second case of validation logic verification.
* This change removes warnings when a developer is looking for potential exploits.
2019-05-12 06:54:41 -05:00
cigamit cff644f4bb Resolving Issue #2537
Tree Mode: Site Title lags 1 refresh behind
2019-03-27 07:36:07 -05:00
netniV 49cb30e5b0 Resolving issue #2532
Ensure Graph ListView table is displayed in line with Management -> Graphs
2019-03-18 14:16:43 +00:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit 8bd52b05cf Resolving Issue #2197
- Normalizing header suppression between JavaScript and PHP
- A few minor formatting changes
2018-12-02 20:18:40 -06:00
cigamit cbf6f818cd Resolving Issue #2173
- Resolving issue 3) of the issues as best as can be done.
-Additionally, making the graph_template_id multiselect common for all
pages and resolving additional QA issues in all areas that were impacted
by multiselect issues.
- Lastly, resolving issues in Reports that cause excessive queries and a
bad user experience.
- There will be likely one more commit on this bug as more QA needs to
be performend on Data Source orphan API introduced.
2018-11-21 13:49:08 -06:00
cigamit 59681ce586 Resolving Issue #2173
This commit resolves sub issues 1) and 2) in issue #2173.  Sub issue 3)
is still being worked.  This change also widens multi-selects for
readability.
2018-11-20 21:16:53 -06:00
cigamit 010f17dbbf Minor JavaScript formatting 2018-10-12 06:27:46 -05:00
Mark Brugnoli-Vinten 1437e304f7 Feature #1969 (#1971)
* Adding Feature #1969

* Update CHANGELOG
2018-09-24 18:07:07 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 4c5b06cc6c Correct issues from list view page 2018-08-26 10:33:47 -05:00
cigamit a520b65a4d QA: Resolve JavaScript Error
When going from tree.php edit page to the Graphs tab, you experienced
and error.
2018-08-19 16:10:49 -05:00
cigamit 15b90d52d8 Revert "Fixes issue 1717 and others (#1775)"
This reverts commit ca23733949.
2018-08-16 20:19:19 -05:00
Mark Brugnoli-Vinten ca23733949 Fixes issue 1717 and others (#1775)
* First round of changes for #1717

* Various QA fixes

* Further round of QA

* Add Content-Type to headers

* Another round of QA

* Allow full screen changepassword

* Redirect to permission denied page instead of displaying local message
2018-08-16 18:42:49 -05:00
cigamit 75189c61f9 Resolving Issue #1761
- Graph management shows bogus template names
- Additionally, allow Multi-selects to have a reasonable width
- For Non-Templated and Template Not Found, properly show those things
as select items in the filter.
2018-07-30 20:43:18 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit eea2a819b8 Resolving Issue #1581
Second commit to mass adding of graphs to reports.
2018-04-30 06:49:43 -05:00
cigamit 7d1dab24fa -issue: Graph List View was not fully responsive 2018-04-08 12:33:24 -05:00
cigamit a8cbe34bcb Resolving Issue #1507
This is a slightly different interpretation of the problem as the Graph
Template ID should not have been in the saved filter setting.
2018-04-04 19:24:23 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
cigamit 88fd10151b Correct a few formatting issues 2018-03-21 17:21:15 -05:00
cigamit e886bc35b6 QA Issues after Issue #1457
Page kept switching back to 1 due to pageset.  Also, switch to numeric
list validation type.
2018-03-18 13:28:42 -05:00
cigamit 35d1018fc9 Ensure message are displayed when viewing graphs on tree 2018-03-18 08:57:34 -05:00
cigamit 1707956caa Additional Sanitization for Issue #1457 2018-03-17 08:36:52 -05:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 7c8201f5a0 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-05 18:04:45 -06:00
cigamit c7c432bb94 Resolving Issue #1161
Graph View regex's are not preserved during automatic page refresh
2018-01-02 19:24:37 -06:00
cigamit fb6723408e Resolving Issue #1141
When viewing graphs from list view, pagination causes list view filter
to be cleared
2017-12-24 12:05:32 -06:00