Commit Graph
2841 Commits
Author SHA1 Message Date
TheWitness 1e7c64ddae Spelling issue associated with #4792 2022-06-17 12:26:30 -04:00
TheWitness 3afa2e0874 Spelling issue associated with #4792 2022-06-17 12:18:39 -04:00
TheWitness 20acad3848 Spelling issue associated with #4792 2022-06-17 12:00:55 -04:00
TheWitness 71adb3830d Spelling issue associated with #4792 2022-06-17 12:00:10 -04:00
TheWitness 5e571467db Prepare for 1.2.22 release. 2022-06-16 08:25:09 -04:00
netniV ea067041c0 When no guest template is set, login cookies are not properly set (#4814)
Closes #4814
2022-06-10 10:48:54 +00:00
netniV 19714d600f Update midwinter to use hashes 2022-05-15 11:26:34 +00:00
TheWitness dbfab60fd3 Release time and testing (#4766) 2022-05-08 21:10:20 +01:00
TheWitness 33555f83c6 Fixing #4726 - SNMP v3 and Fedora 2022-04-24 14:32:47 -04:00
netniV 2edfd55021 Unable to obtain SNMP data (#4726)
Whilst being unable to obtain SNMP data, the $session->info
variable is empty despite appearing to be primed by
classSNMP.php's SNMP class.
2022-04-20 15:01:43 +00:00
TheWitness c99d9365a8 Fixing Issue #4728 - Replacing Suggested Values
- Cacti Template and Package Installs need a way to deal with conflicting Suggested Name Values/Patterns
- Note that this has not been fully tested yet.
2022-04-19 08:04:09 -04:00
Jing ChenandMark Brugnoli-Vinten 762c1407f0 Fixed: 404 error for some files with midwinter theme (#4721)
Co-authored-by: Mark Brugnoli-Vinten <netniv@hotmail.com>
2022-04-18 18:21:42 +01:00
TheWitness 75a6e03db7 QA: Issue exposed in testing 2022-04-15 18:19:41 -04:00
TheWitness fddd136a38 QA: PHP8 Issues and Check Pages Syntax Issue 2022-04-15 18:02:29 -04:00
TheWitness 105a4cb47d Fixing #4705 and #4719 - Remember me and Zone Cookies
- Browsers to begin rejecting CactiTimeZone and CactiDateTime cookies due to SameSite Requirements
- Remember me not working after upgrade to 1.2.20 from 1.2.19
2022-04-14 08:24:26 -04:00
TheWitness 448ebc3d94 Fixing #4707 - Duplicate Graph Template Issue
SQL Save on table 'graph_templates_item': Column 'data_template_id' does not exist
2022-04-13 20:14:21 -04:00
Browniebraun 47e5481ed1 1.2.x (#4709)
* add mark.js

* Update main.css

- fix and force height calculation of cactiHead, breadbrumbar and cactiContent in standard mode
- fix scrollbar border color of console menu for WebKit browser in standard mode

* start splitting CSS

split CSS in 'core' containing all elements Cacti provides, while MidWinter CSS will be maintained separately

* Update jquery.zoom.css

fix borders,

* drop unused media query

1280 definition have not been become active yet.

* add print css

keep print separately, too.

* Update min-width-600.css

skip particles - would have been nice, but MidWinter is already heavy enough.

* split compact mode

more css changes

* more separation

see above

* move css out of main

remove remaining css fragments

* fix kiosk mode

kwt

* start restructuring standard layout

more css

* change compact menu click on

hide menu automatically when menuitem clicked.
2022-04-13 11:53:15 -04:00
netniV 38f3e89bc5 Heartbeat definitions can cause issues under PHP 8 (#4693)
Due to specifying 5.5 minutes, format string must match
a float not a string or decimal under PHP 8.1
2022-04-11 08:59:31 +00:00
Petr Macek 34bd0c82f1 completition issue#4684 - font path FreeBSD (#4692) 2022-04-11 09:51:32 +01:00
TheWitness 58dda2ca03 Fixing Issue #4637 - FontAwesome MultiSelect
Have Cacti's MultiSelect CheckAll and UnCheckAll use Font-Awesome
2022-03-20 15:21:43 -04:00
TheWitness 8f33e4b648 QA: Selective Debug on Plugins not ordering alphabetically 2022-03-20 15:16:32 -04:00
TheWitness d7cc35dd29 Disable the CACTI_LANGUAGE_HANDLER_OSCAROTERO processor in PHP8+ for now 2022-03-19 18:00:02 -04:00
TheWitness 84a9ecfef2 Fixing Issue #4636 Latest jQueryMultiselect
jQueryMulti-select 3.0.1 includes i18n upgrade to it
2022-03-19 16:16:04 -04:00
TheWitness f3a846ada4 Fixing Issue #4632 - Form Validation
Input Field Checking is not enforced upon creation of Data Source
2022-03-17 20:37:37 -04:00
TheWitness 995b169a63 QA On Graph Resizing 2022-03-16 21:05:09 -04:00
TheWitness 73ccf3cc88 One minor issue with last commit 2022-03-16 20:45:17 -04:00
TheWitness fb2a9afac1 Fixing Issue #4631 - More heartbeats
Additional choices for Heartbeat when creating a Data Source Profile
2022-03-16 20:33:05 -04:00
TheWitness e5fdd755e1 Light modification to #4536 row vs. assoc
Wrong DB call.
2022-03-16 18:07:19 -04:00
TheWitness 8cf3cecdc1 Fixing Issue #4621 - RRDtool i18n
RRDtool Graph Internationalization does not work as expected on RRDtool versions above 1.5
2022-03-14 20:13:46 -04:00
Browniebraun 4b375bf32e Update main.js
ensure that menu icons will always be replaced in every case.
2022-03-13 18:21:08 +01:00
Jing Chen 7d48258e1f Use OS provided DejaVu font for RHEL/CentOS/SLES/Ubuntu(PR#4594) (#4594) 2022-03-12 13:16:58 -05:00
TheWitness 13464f2afd Fixing Issue #4609 - Session Issues
In some cases Cacti cacti session renewal lacks the HTTP_USER_AGENT resulting in errors in the Cacti Log
2022-03-11 15:18:05 -05:00
TheWitness 1800c50909 Suggestion on Issue #4605
This might work better.
2022-03-11 12:23:06 -05:00
Browniebraun 149ebc494b Update main.css
a compromise - addressing Firefox's bad implementation of Flexbox. (A bug known since more than 7 years)
2022-03-11 17:57:47 +01:00
TheWitness 522b1e0350 Fixing #4603 - Default Language Handling
Cacti refuses to use the php-gettext module when installed
2022-03-10 08:27:41 -05:00
Jing Chen a11f97d778 Two minor code changed: add a fa class, and use microtime(true) (#4599) 2022-03-09 18:44:41 -05:00
Browniebraun d771b66e21 let compact navigation menu resize automatically
make Larry happy by adding a workaround for not calculating width correctly when using flexbox row wrap.
2022-03-09 17:10:21 +01:00
TheWitness 2f189bd06c QA: Correct a typo 2022-03-03 20:13:06 -05:00
TheWitness 8509970030 QA: Final Fix for #4565
This was the piece that was missing.
2022-03-02 18:55:11 -05:00
TheWitness 06a2d429d2 Fixing Issue #4593 - Auth Tokens don't use realm
Cacti 'remember-me' does not work with identical usernames from different realms
2022-03-02 17:15:55 -05:00
TheWitness 6cf357b830 More changes to address potential JS leaks 2022-03-01 19:59:11 -05:00
TheWitness b241789b82 Fixing some potential memory leaks on Graphs page 2022-03-01 14:35:03 -05:00
TheWitness 49de0bea15 QA: Relocate function, PSR, and fix two memory leaks 2022-03-01 07:58:23 -05:00
TheWitness 9e4bcdd4ab QA on #4587 - Does not need to be forced 2022-02-28 21:43:04 -05:00
TheWitness 29bede5fe5 Fixing issue # 4587 - Settings performance
This change will cause a caching of items to reduce various page times.  That is the expectation
2022-02-28 21:11:19 -05:00
TheWitness 5d1b8e6183 Fixing Multiple Bugs and one Feature #4576, #4579, #4573, #4575, #4577, #4578, #4574
-security#4576: Stored XSS Issue in Cacti Device, Graph, Graph Template, and Graph Items callbacks
-security#4579: Cacti account lockout policies are not properly applied to LDAP and Domain Users
-issue#4573: The Cacti permission system does not scale to very large installations
-issue#4575: When you delete a user, their 'remember me' cookie data is not automatically removed
-issue#4576: Stored XSS Issue in Cacti Device, Graph, Graph Template, and Graph Items callbacks
-issue#4577: Cacti allows you to disable the currently logged in administrator disabling the user
-issue#4578: The Cacti login algorithm is complicated to understand due to too much strait line code
-feature#4574: Cacti needs some additional permission methods for larger installations

This change properly documents the file lib/auth.php using phpDocument format, and performed multiple sanity and readability changes such as the renaming of variables commonly used in multiple functions.

The the restructuring of the three authentication files:

- auth_login.php
- include/auth.php
- lib/auth.php

Makes the code more readable, it's not a complete solution, however, it is much easier to follow now.
2022-02-27 15:26:28 -05:00
TheWitness 18dc527c94 Roleback debugging code 2022-02-24 21:12:56 -05:00
Browniebraun bdd237776d Update main.js
PHPStorm and it's project files :(
2022-02-24 19:43:38 +01:00
Browniebraun 70561d7682 Revert "enhance navigation update"
This reverts commit 3562d988bd.
2022-02-24 19:39:11 +01:00
Browniebraun 3562d988bd enhance navigation update
add a fallback if nothing matches
2022-02-24 19:38:32 +01:00