Commit Graph
768 Commits
Author SHA1 Message Date
Datatech UK LtdandTheWitness 234f90cbab Only show sensitive graph information to Template Editors in the List View screen (#4049)
* Update main.css

Make it more obvious that a slider is disabled.

* Update main.css

Make it more obvious that a radio slider is disabled.

* Update cacti.sql

Fixed the default value for the 30 second polling and amended the default values for the 1 minute polling for new installs

* Add ability to Hide the Graph Drilldown icons from the graph_view.php and graph.php pages
The icons are on the right hand side of the graphs and the default behaviour is to display them unless you hide them per user in the permissions tab

* Updated CHANGELOG

* Change the Realm from 2001 to 27 as 100 and above are reserved for plug-ins.

* Formatting change for neatness.

* Update CHANGELOG to reference this ticket number. Changed Drilldown to Drilldowns

* Only show sensitive graph information to Template Editors in the List View screen

* Removed duplicate line from CHANGELOG

* Update CHANGELOG to reference this ticket number.

* Updated cacti.pot as requested

Co-authored-by: TheWitness <thewitness@cacti.net>
2021-01-17 14:11:56 -05:00
mr_me f92e9860c4 Patch for get_client_addr (#4060)
* Update CHANGELOG

* Updated get_client_addr

When calling get_client_addr REMOTE_ADDR is always returned

* Update CHANGELOG
2021-01-17 12:21:32 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
kim-fitnessandTheWitness 5d24cfee9b Update lib/functions.php and include/global_arrays.php (#4020)
* Update functions.php

* Update global_arrays.php

* Update CHANGELOG

* Update CHANGELOG

Co-authored-by: TheWitness <thewitness@cacti.net>
2020-12-24 05:59:10 -05:00
TheWitness 7b7b713604 Fixing Issue #4008
This is a partial rollback of issue #3808 due to negative impact it has on both GUI and Data Collector performance.
2020-12-15 21:27:36 -05:00
TheWitness 1a58f59deb Fixing Issue #3960
Improve warning you get when attempting to view a log file you don't have access to
2020-11-27 09:53:29 -05:00
TheWitness 68a25e9ae5 Correct three issues with PHP7.4 2020-11-22 22:43:46 -05:00
TheWitness 2b69a59f71 Correct three issues with PHP7.4 2020-11-22 22:36:13 -05:00
TheWitness 7d5f2144b3 Correct three issues with PHP7.4 2020-11-22 21:55:14 -05:00
TheWitness f103cf078b Fixing Issue #3910
Banners are not showing up
2020-11-08 12:35:46 -05:00
TheWitness 52bb6ffda7 Remove all remaining instances to "sizeof(" or "count(" in code
* Some insances in the vendor directory have not been handled to maintain pedigree.
2020-10-21 08:27:42 -04:00
TheWitness bb2e3f6433 Fixing Issue #3815
Issues with Cacti login when session_autostart is configured in php.ini
2020-09-28 21:34:50 -04:00
kim-fitness 129150fbbc Fix issue #3793 (#3803)
* Update CHANGELOG

* Update functions.php
2020-09-15 08:26:54 -04:00
TheWitness 55da4167c3 Fixing Issue #3768
When using the Paw, Paper-plan, and Sunrise themes, there is no way to remind the user who is logged on
2020-08-26 13:04:29 -04:00
netniV 67c8e72e7e LDAP Authentication succeeds, but login fails due to bad session handling (#3576)
Also applying a QA fix on poller maintenances logrotation function

Closes #3576
2020-06-28 19:12:36 +00:00
TheWitness 8870e84cdf Properly handle session closure. 2020-06-27 21:31:24 -04:00
TheWitness 0c9a29cf37 Fixing Issue #3601
When devices down, instate can show wrong time
2020-06-13 12:05:40 -04:00
TheWitness 4e062fb6aa Use Cacti functions for session handling where possible. 2020-05-19 12:29:54 -04:00
TheWitness 9a100d6035 Fixing Issue #3506
"Login as Regular User" always forward to "Automatic Logout....timeout"
2020-04-26 11:11:43 -04:00
TheWitness a360f1a3ef Fixing Iseue #3450
Cacti can not be supported on XAMPP and PHP7.4
2020-04-09 20:32:36 -04:00
TheWitness a8ea533640 Additional changes for #3402
* These changes allow some JavaScript to be loaded Async.  jQuery and jQueryUI as well as layout.js as well as the themes's main.js are critical and can not be loaded async.
* It also adds the meta description tag to increse the SEI scrore
2020-04-04 09:17:27 -04:00
TheWitness d65f40d2bf Abstract Cacti session handler 2020-03-29 19:08:29 -04:00
TheWitness e2a6a034f6 Minor update due to note on issue #3380 2020-03-29 12:30:49 -04:00
TheWitness aac7dcd9b9 Minor changes to attachment handling to cover all cases. 2020-03-29 10:31:22 -04:00
TheWitness a0100843ba Missed update to email attachment handling 2020-03-28 18:39:52 -04:00
TheWitness dd2d455362 Fixing Issue #3380
php error when trigger threshold sendmail
2020-03-27 12:56:11 -04:00
TheWitness 1e8e118f43 Additional changes around #3360 with 'Remember Me' sessions
They were being logged out even though they should not be.
2020-03-25 18:31:54 -04:00
TheWitness 76acc93909 Adding terse documentation 2020-03-24 19:25:16 -04:00
TheWitness 568e9425f0 Related to #3374
When you logout, clear you remember me cookie too.
2020-03-24 19:18:26 -04:00
TheWitness 6a2d781778 Fixing Issue #3374 Cacti Cookie Domain
* Allow Setting of Cookie 'Cacti' domain edition
* This also allows the Cacti administrator to extend the content security policy to include unsafe-eval for scripts.
2020-03-24 19:12:48 -04:00
TheWitness 68831cd01e Fixing #1566
Need to change to $config due to old PHP5.
2020-03-21 14:53:17 -04:00
TheWitness 265ebc27ea Fixing Issue #1566
* Add SameSite support for cookies
* Add some light formatting for readability
2020-03-21 14:40:17 -04:00
TheWitness be9766609e Resolving Issue #3283
Errors on Console > Configuration > Settings > Paths when a path includes valid characters '_', '-', and '.'
2020-02-22 11:28:31 -05:00
netniV 6cf15d3155 Installer shows script owner rather than running user for suggested chown command
Closes #3254
2020-02-21 23:19:21 +00:00
netniV 93af5d1dc4 Another minor QA 2020-02-10 01:11:29 +00:00
netniV 460ce06ca1 Fix minor QA issue 2020-02-10 01:04:48 +00:00
netniV 8d748b1c42 Make get_client_addr() work properly 2020-02-10 01:00:07 +00:00
cigamit b3de24f0a5 Resolving Issue #3226
Adding a few more possible headers.
2020-02-03 22:06:48 -06:00
cigamit b89a142f30 More corrections for #3226
Adding a few additional header matches
2020-02-03 20:27:01 -06:00
TheWitness e4b179bd35 Fixing Issues #2937 and #3209
* Devices still show in cacti despite being deleted
* PHP Error when Creating New Graphs through Automatically Added Devices using Sync Device Template
2020-01-22 19:08:59 -05:00
cigamit 5010719dbd Resolving Issue #3201
Vulnerability Report: Remote Code Execution due to input validation in Performance Boost Debug Log
2020-01-19 09:10:31 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 33ed3079bb Partial resolution to issue #3164
* Array and string offset access syntax with curly braces is deprecated in php 7.4
* As mentioned by @netniv, this will be a 1.3 project, but resolving what was identified in the mean tiem.
* I have verified that multiple plugins are also impacted by this change.
2020-01-08 07:33:36 -06:00
cigamit 1f1c8ff4a3 Resolving Issue #3120
PHP 7.4 Compatibility Issues
2019-11-30 08:22:52 -06:00
cigamit 55c17d4f0e Resolving Issue #3079
Allow for domain names to be stripped from long device descriptions
2019-11-09 18:44:53 -06:00
cigamit 145361434d Resolving Issue #2999
Blank arguments can lead to extra spaces in script arguments
2019-11-09 13:30:04 -06:00
cigamit dfc3109126 Resolving Issue #3032
Graph always shows 'MAX' CF for LINE graph instead of AVERAGE/MIN/LAST
2019-11-09 12:08:00 -06:00
cigamit 05ee70d73b Implement graph_view.php change differently.
Relates to this commit: https://github.com/Cacti/cacti/commit/553665944a12aba521956d2ee5a45a41519649c7#diff-190af701aa28435aeae112419ec79c67
2019-10-13 14:23:35 -05:00
cigamit adf2213443 Resoving Issue #3026
Unsafe deserialization in of selected objects in Cacti
2019-10-12 14:56:43 -05:00
netniV 553665944a Some graph routines are not properly validating incoming variables
Closes #3012
2019-10-07 16:06:54 +00:00