Commit Graph
531 Commits
Author SHA1 Message Date
TheWitness 2c779273f9 Copyright Updates and PHP-CS-Fixer updates 2025-03-09 14:34:19 -04:00
TheWitness 7133f5b25f QA: Restore FontAwesome for Next Table Nav 2025-02-27 18:16:58 -05:00
TheWitness ab5eb84b5e QA: Align Column display with Midwinter 2025-02-23 19:07:23 -05:00
Jimmy ConnerandTheWitness 65ab16f5cf Start converting to newer PHP Syntax and Functions (#6103)
* Add Rector

* Add Rector

* Fix "Cashed" misspelling

Also harmonize the phrase with the one below it

* Fix implode error in db_table_create

Only relevant when multiple primary keys

* Fix auth issue, parentheses in the wrong location

Was causing too many arguments to be sent to cacti_sizeof which only take 1, instead of get_allowed_devices.

* Fix issue with session_var not properly using class variable

* Fix pass by reference error in get_allowed_devices

get_allowed_devices has a pass by reference on the "total_rows" field.  It is used in several places to pass the total_rows back to a counter.  Here though, we are passing a number directly to the function, which errors out with "Uncaught Error: get_allowed_devices(): Argument #4 ($total_rows) cannot be passed by reference".  So we will just place a dummy variable in front to catch the pass.

This wasn't caught before because the previous parentheses issue.

* Fix undefined variable "field_array" in html_filter

* Fix undefined function 'get_nfilter_filter_request_var'

* Fix undefined variable 'resizable'

I corrected the function parameter, as that was technically the incorrect spelling

* Fix invalid variable $user_id

* Fix undefined vars in spikekill class

* Fix copy and paste error

Oops

* Forgot to use the dummy variables

* Add missing $

Oops

* Start converting to newer PHP Syntax and Functions

* Test fixing the workflow by install composer

* Lets not valid the composer file right now
Seems we have a few things to fix it in

* Validate composer

* Lite formating changes

* lite formatting

* lite formatting

* lite format changes

* lite format changes

* lite format changes

* lite format changes

* lite format changes

* lite format changes

* lite format changes

* lite format changes

---------

Co-authored-by: TheWitness <thewitness@cacti.net>
2025-02-23 15:14:54 -05:00
Jimmy Conner 8358eba453 Fix copy and paste error
Oops
2025-02-22 00:54:44 -06:00
Jimmy Conner 45d050646a Fix undefined variable 'resizable'
I corrected the function parameter, as that was technically the incorrect spelling
2025-02-22 00:16:01 -06:00
Jimmy Conner 50bc380383 Fix undefined function 'get_nfilter_filter_request_var' 2025-02-22 00:12:15 -06:00
TheWitness 69cf00ebbe QA: Restore tab icons 2025-01-15 20:40:13 -05:00
TheWitness c8d988b057 QA: Convert graphs.php to use header icons 2025-01-15 18:15:50 -05:00
Browniebraun d88d3acd30 reverting FontAwesome till better solution has been identified. 2025-01-15 23:04:14 +01:00
TheWitness e43e32321d QA: Merge changes from #6024 - Oauth2
* This merges @xmacan's changes and performs additional functions.
* Adds composer.json and composer.lock to include folder
* Places the flag-icons and phpmailer into that file
* Updates flag-icons and phpmailer to latest
* Adds the autoloader.php to global.php
2025-01-08 09:30:07 -05:00
Browniebraun 5be7d7f18b Migrating icons from FontAwesome to Tabler 2025-01-05 20:58:36 +01:00
TheWitness cefcce60bf QA: Fix a JS Syntax Error 2025-01-02 15:10:38 -05:00
TheWitness 83b13183c0 QA: function loadUrl() does not handle JSON responses 2024-12-30 16:19:04 -05:00
TheWitness 5cd67b098c QA: Switch the spikekill menu to anchor for theme uniformity 2024-12-30 15:55:57 -05:00
TheWitness 3b7ad237c9 QA: Wording Change 2024-12-29 21:39:52 -05:00
TheWitness 51629b63df QA: Restore SpikeKill Menu 2024-12-29 17:41:38 -05:00
TheWitness adef6d6517 QA: Fix: #6030 - Not Resizable Device Data Queries 2024-12-29 17:16:56 -05:00
TheWitness 68c7048993 QA: Remove misuse of tableRowGraph and tune themes 2024-12-29 16:19:46 -05:00
TheWitness c93b3547a0 QA: Fixing multiple graph issues below
* Breadcrumbs would become corrupted depending on actions selected from the graph icon-bar
* Converting graph icon-bar to glyphs
* Adding glyph classes to various Glyph actions
* Adding CSS to 'dark' theme only at this time
* Some double to single quote conversion in layout.js
* Removing some Inline html for various icon-bar's
* Removing duplciated fontawesome.css header inclusion
2024-12-29 14:14:32 -05:00
TheWitness e97c12b7a1 QA: group_source issues when switching templates 2024-12-27 16:55:56 -05:00
TheWitness c82227d05b QA: Fix: #6013 - Issue with filter defaults 2024-12-24 15:07:18 -05:00
TheWitness 7ffb9e5c31 QA: clog.php is not a console page 2024-12-23 12:57:54 -05:00
TheWitness efe329cfd7 QA: Merge the 'preview' page to the Filter Class
* Likely 'List View' is broken.
* Inline Zoom is currently broken.
* Relocating the save button to respect permissions
* Some light renaming and reorganization in files
* Removing deprecated functions
* Stop using deprecated set_graph_config_option() call
* Correcting some misspelling here and there
* New function to down-selecting devices by location and other aspects in callbacks.
* Change 'Metric' to 'Source'
* Use the html_transform_graph_template_ids() function universally
* Remove the prior Sorting Filter code.  Using Filter Class now.
* Prototype filtering logic in graph_view.php for ajax_hosts callback
2024-12-23 12:50:30 -05:00
TheWitness 7a1e1282f3 QA: Implement Filter Class for Tree View
* Also fixed the default sort order when ordering Graphs.
* Preview it still TBD, but now it should be pretty easy
* Moved the multi-select function to layout.js and out of lib/html.php
2024-12-22 22:22:41 -05:00
TheWitness 61f1afdee1 QA: Simplify the layout of the title bar
* Note that these is some JavaScript that needs adjustment.
* I've made the executive decision to not make the entire header force a collapse of the filter.  It will collapse naturally as the screen size adjusts, but clicking the row will no longer collapse the whole thing.  I just need time to do the work to de-content the JavaScript.
2024-12-21 09:37:47 -05:00
TheWitness a6cc58fc05 QA: Correct Issue with empty string 2024-12-18 19:04:28 -05:00
TheWitness d76ff9cc0b QA: First Round of Page Filter Updates
* This first round of implementing the filter class catches a large chunk of our existing filters, though I've only implemented 3 pages in this commit, others will come and the filter class will be enhanced as I go.
* For the most part, this results in a major code html reduction by using the CactiTableFillter class.
* The existing filters, the complicated ones, in the end will just have to receive slight modifications to work in the new design.
* There still remain some JavaScript issues to work through though.
* This also moves these form's to 100% div based.
2024-12-17 14:30:24 -05:00
TheWitness 3bada47208 QA: Phase 1 of filter cleanup prior to migration
* Introduce a new wrapper function for showing the show/hide column indicator
* Migrate all Core packages to use that new wrapper function
* Migrate pages to have JavaScript show immediately below the form object.
* Correct some indentation issues
2024-12-16 13:01:17 -05:00
TheWitness 560cb12df0 QA: Reverting some changes. We need a new function for table header title bars
* The html_start_box() is not going to work.  We need a new function html_start_box_table() specifically for table headers.  Should be a minor change, but affects multiple pages.
2024-12-15 22:27:47 -05:00
TheWitness d8624ab45f QA: Show the show columns for #1401
* This add the capability to show the column, now we need JS behind the scenes to display the data.
2024-12-15 22:18:37 -05:00
TheWitness b82a86070a QA: Use the form_get_table_id() function 2024-12-15 20:30:32 -05:00
TheWitness db8c290d89 QA: Changes in Support of #1401
* This is some pre-work to supporting column visibility enhancements already in place in MidWinter.
* This change should allow generalized support of column visibility storing the settings in the database.
2024-12-15 19:30:33 -05:00
TheWitness 24d988cc66 QA: #5858 - Reporting Changes
* As part of the reporting project remove reports_user.php and rename reports_admin.php to simply reports.php.
* Control permissions by realm and not file in this case.
2024-12-15 09:43:11 -05:00
TheWitness fe06476e74 Fix: #5971 - Show Unknown Data Globally
* Fixing the display of unknown data as a global setting
* Re-arrange some RRDtool options such as business hours to be more prominent in both global and user settings.
* Convert colors to drop-color objects
* Add Business Hours as a Checkbox on Graphs Pages
* Make a filter function for both Thumbnails and Business Hours
2024-12-11 21:37:51 -05:00
Jimmy Conner ad07471bb1 Lots of PHPDoc formatting and cleanup
Lots more to go
2024-12-09 02:50:06 -06:00
TheWitness f3a6eb3ff4 Fix: #5968 - Remove jquery sparklines
* Removing jQuery Sparklines API as we are not using it and have adequate charting libraries
2024-12-08 07:59:49 -05:00
TheWitness 40fe5b174c Fix: #5967 - Remove dygraph-combined.js
Removing dygraph-combined.js as we are not using it and have adequate charting libraries
2024-12-07 09:29:33 -05:00
TheWitness c1bc4ad0aa QA: Issue with form rendering due to API change 2024-12-06 12:36:25 -05:00
TheWitness b36a1f82c9 Fix: #5378 - Auto refresh should not change position on page
* When reload page in browser with graphs created scroll window always return to top
2024-12-05 16:54:22 -05:00
TheWitness 0fdfbb6a4a Fixing #5964 - Zoom Issues
@browniebraun, look at line 971.  It's definitely wrong.  Can you make it right?
2024-12-05 14:29:58 -05:00
TheWitness 1a4809517d QA: More Template page beautification 2024-12-04 20:42:43 -05:00
TheWitness 2aa77d9aea QA: #5952: Incorrect option value 2024-12-04 13:57:12 -05:00
TheWitness 87c9b17bfa Fix #5952 - New Form dropdown type drop_icon
* Allows the dropdown to include font-awesome representations
2024-12-04 13:03:37 -05:00
TheWitness ad058ffd75 Fix: #5941 - Drag and Drop on Graphs and Templates Pages
* Implement Drag and Drop on Graph Templates Edit Page
2024-12-02 15:48:58 -05:00
TheWitness 6369309dc2 QA: Fix #5940 - Graph Template Items showing Gradient color
* This is more of a feature enhancement, but leaving it as QA for now.
* Also getting away from DrawMatrixHeaderItem() calls.
2024-12-02 11:36:36 -05:00
TheWitness b618e9af68 Fix #2572 - Adding advanced DSStats measures
* This change adds sorting measures in addition to average and peak:
  * Percentiles (25th - 95th)
  * Totals/Sum/Bandwidth
* It also allows you to pick from the Consolidation Function (average or max).
2024-11-27 13:35:17 -05:00
TheWitness 1d61fb23e6 QA: Move billboard.css to a common css file. 2024-11-26 11:30:19 -05:00
Linegod c3b176780f typos 2024-11-24 23:22:15 -06:00
Browniebraun 9731ca64c3 - commit live-data update for Zoom 2024-11-17 18:11:22 +01:00