netniV
460ce06ca1
Fix minor QA issue
2020-02-10 01:04:48 +00:00
netniV
8d748b1c42
Make get_client_addr() work properly
2020-02-10 01:00:07 +00:00
cigamit
b3de24f0a5
Resolving Issue #3226
...
Adding a few more possible headers.
2020-02-03 22:06:48 -06:00
cigamit
b89a142f30
More corrections for #3226
...
Adding a few additional header matches
2020-02-03 20:27:01 -06:00
TheWitness
e4b179bd35
Fixing Issues #2937 and #3209
...
* Devices still show in cacti despite being deleted
* PHP Error when Creating New Graphs through Automatically Added Devices using Sync Device Template
2020-01-22 19:08:59 -05:00
cigamit
5010719dbd
Resolving Issue #3201
...
Vulnerability Report: Remote Code Execution due to input validation in Performance Boost Debug Log
2020-01-19 09:10:31 -06:00
netniV
4fa9a68fb3
Update copyright to 2020
2020-01-12 12:19:49 +00:00
cigamit
33ed3079bb
Partial resolution to issue #3164
...
* Array and string offset access syntax with curly braces is deprecated in php 7.4
* As mentioned by @netniv, this will be a 1.3 project, but resolving what was identified in the mean tiem.
* I have verified that multiple plugins are also impacted by this change.
2020-01-08 07:33:36 -06:00
cigamit
1f1c8ff4a3
Resolving Issue #3120
...
PHP 7.4 Compatibility Issues
2019-11-30 08:22:52 -06:00
cigamit
55c17d4f0e
Resolving Issue #3079
...
Allow for domain names to be stripped from long device descriptions
2019-11-09 18:44:53 -06:00
cigamit
145361434d
Resolving Issue #2999
...
Blank arguments can lead to extra spaces in script arguments
2019-11-09 13:30:04 -06:00
cigamit
dfc3109126
Resolving Issue #3032
...
Graph always shows 'MAX' CF for LINE graph instead of AVERAGE/MIN/LAST
2019-11-09 12:08:00 -06:00
cigamit
05ee70d73b
Implement graph_view.php change differently.
...
Relates to this commit: https://github.com/Cacti/cacti/commit/553665944a12aba521956d2ee5a45a41519649c7#diff-190af701aa28435aeae112419ec79c67
2019-10-13 14:23:35 -05:00
cigamit
adf2213443
Resoving Issue #3026
...
Unsafe deserialization in of selected objects in Cacti
2019-10-12 14:56:43 -05:00
netniV
553665944a
Some graph routines are not properly validating incoming variables
...
Closes #3012
2019-10-07 16:06:54 +00:00
cigamit
027d701f1b
Resolving Issue #2925
...
Problem with consolidation function after upgade to 1.2.6
2019-09-04 23:44:56 -05:00
cigamit
b673aaafe2
Resolving Issue #2912
...
Resolve navigation caching array to string conversion issues
2019-08-29 07:26:11 -05:00
netniV
245a34063e
Mailer incorrectly reports it is sending to noone
...
Closes #2902
2019-08-16 12:29:37 +00:00
netniV
9e1e58c240
When path is blank, is_resource_writable() will generate 'Uninitialized string offset: -1'
...
Closes #2820
2019-07-13 13:57:30 +00:00
cigamit
28088b47f8
Resolving Issue #2816
...
Two issues about page navigation under "Logs" tab
2019-07-12 07:44:41 -05:00
netniV
79ffee4ead
Installation wizard does not detect RRDtool version correctly
...
Closes #2282
2019-07-10 22:28:49 +00:00
cigamit
390ded9f10
Additional Resolution on Issue #2805
2019-07-07 15:21:12 -05:00
cigamit
b08f8030fc
Resolving Issue #2783
...
Cacti title_trim() function does not work with UTF-8 or Multi Byte strings
2019-06-30 11:30:06 -05:00
cigamit
1ee746965d
Resolving Issue #2742
...
Resolve a number of QA issues in various files
2019-06-22 09:04:37 -05:00
netniV
2c25435cef
In PHP strict standards mode, rrdtool_function_graph() generates ByRef message for HRULE items
...
Closes #2724
2019-06-09 13:09:54 +00:00
cigamit
d04fb8d176
Resolving Issue #2707
...
Some pages that have permission errors dont raise proper messages
2019-05-27 11:02:20 -05:00
cigamit
3d1252b579
Minor update to issue #2662
2019-05-13 02:24:48 -05:00
cigamit
d0c3ab0daf
Resolving Issue #2662
...
* HRULE objects broken in some cases
* Also two missed escapeshell* change
2019-05-12 06:48:22 -05:00
netniV
a2d3fd8776
Revert "WIP: php argument composition ( #2653 )"
...
This reverts commit 8a23ca33e3 .
2019-04-29 12:43:03 +00:00
David Runge
8a23ca33e3
WIP: php argument composition ( #2653 )
...
* Moving all argument composition for backgrounded calls of php to 'assemble_php_args()' in /lib/functions.php.
* lib/functions.php: Explicitely prepending all assembled arguments.
* lib/functions.php: Removing an accidental appending of the initial args in assemble_php_args().
2019-04-29 13:38:17 +01:00
cigamit
f002bdf58a
Resolving Issue #2523
...
Test email failure on PHP 7.3
2019-04-16 21:22:32 -05:00
netniV
013c8eb644
Resolves multiple issues:
...
-issue#2590: Language selection is not working as expected
-issue#2605: When checking for tables to upgrade, undefined variable $config error occurs
-issue#2608: db_update_table() function should not require an engine type or comment
-issue#2610: Data Sources troubleshooter generates warning that each() function is deprecated
Closes #2590 , 2605, 2608, 2610
2019-04-04 11:49:59 +00:00
cigamit
239d759de6
Remove trailing spaces from names
...
This happens during the presentation of the breadcrumbs.
2019-03-27 07:15:25 -05:00
NotAProfessionalDeveloper
c3195c1be2
Remove grocer's apostrophes ( #2546 )
...
https://blog.oxforddictionaries.com/2011/02/04/random-apostrophization/
2019-03-22 15:58:43 +00:00
cigamit
046590909b
Resolving Issue #2282
...
Install Wizard does not Detect RRDtool Version on Windows
2019-03-10 16:00:41 -05:00
netniV
cade16849a
Fix up incorrect variable name when checking for bad navigation items
2019-03-01 15:39:55 +00:00
netniV
6581274835
Resolving issue #2472
...
Bad navigation items cause Array to string conversion errors
2019-03-01 10:06:42 +00:00
cigamit
350678d3ce
Resolving Issue #2450
...
Undefined index: in file lib/rrd.php when viewing new graph
2019-02-24 07:16:49 -06:00
netniV
173df04100
Make get_timefromdays() handle multiple formats
2019-02-23 22:55:57 +00:00
cigamit
2743fe6dc2
Make the SQL and the get_timeinstate() function consistent
2019-02-23 13:41:32 -06:00
cigamit
4f6a393f12
Compensate for 'Unknown' Device status
2019-02-23 13:04:25 -06:00
cigamit
3daad8c6f0
Minor tweak after testing
2019-02-23 12:29:53 -06:00
cigamit
778131a45f
Correct issue with time in state calculation
...
This will correct time in state calculations for devices that do not
have an availability/reachability check.
2019-02-23 12:21:41 -06:00
netniV
52a6add2e0
Correct issue with days more than 99
2019-02-21 15:13:51 +00:00
netniV
19b14d7f64
Correct dyslexic naming of function call in last commit
2019-02-21 15:01:38 +00:00
netniV
52ea4a8f91
Correct issues with uptime display
2019-02-21 14:58:47 +00:00
cigamit
0370dfea49
Clearn up messaging and add ContentType
2019-02-20 20:48:48 -06:00
cigamit
9314d946f2
Add get_uptime function and fix mailer text email option
2019-02-19 20:13:33 -06:00
netniV
ef64170ab0
Previous commit missed a change
2019-02-19 13:39:40 +00:00
netniV
e6e8c2d922
Resolving issue #2431
...
Default value is text for which mail method to use, should be integer
2019-02-19 13:37:31 +00:00