Commit Graph
84 Commits
Author SHA1 Message Date
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness 0046763ab9 Fixing Issue #4539 - Dependency Message Incorrect
Broken handling of plugin dependencies in 1.2.19
2022-01-31 18:30:40 -05:00
TheWitness 63e1998aab Minor update related to #4390
This allows $ret calls that were initially empty to not trigger an error.  This was applicable for the graph refresh hook that, if the user has no default setting, will initialize as null.
2021-09-08 18:55:52 -04:00
TheWitness 888707aeca Fixing Issue #4390 - Add Plugin Chaining Warnings
The plugin API should detect when plugins are not behaving properly with return variables required for chaining
2021-09-06 12:28:47 -04:00
TheWitness 557f89bd67 Revert "Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x"
This reverts commit 0b597f61cb, reversing
changes made to b062b2bb57.
2021-01-26 19:48:30 -05:00
browniebraun 20e6223f6d Revert "Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x"
This reverts commit 7e0da80345, reversing
changes made to 3ee16196ef.
2021-01-26 19:09:33 +01:00
TheWitness e6258b6d8b Two additional boost optimizations
- Do not overcall the plugin hook DB calls, or checking for rrdtool version in a single script instantiation repeatedly
2021-01-25 12:54:36 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness c57a066226 Additional changes around #3985
* Doing collate and charset as separate transactions
2020-12-19 12:15:15 -05:00
TheWitness b2fce0ac75 Fixing Issue #3985
Update database library function to properly handle collate
2020-12-05 10:38:54 -05:00
TheWitness f86360fa96 Minor fix to #3977 2020-12-03 18:51:38 -05:00
TheWitness 1c9f332794 Fixing Issue #3977
Cacti CLI upgrade_database.php misses constant IN_CACTI_INSTAL which may result in upgrade failures
2020-12-03 08:34:54 -05:00
TheWitness 7fe7bbb693 Fixing Issue #3963
Plugin table creation function misses the table collation setting
2020-11-28 11:11:59 -05:00
TheWitness fc6ffc337a Remove warnings removing plugins
When removing plugin entries from plugins that no longer exist in the plugin management area during upgrade generate warnings.
2020-10-29 10:48:41 -04:00
TheWitness 74bf30cd1e Fixing Issue #3883
No way to remove integrated/orphaned Plugin references from the Plugin Management interface
2020-10-24 10:32:49 -04:00
ddb4github 61b8481fa7 Plugin realm files can not be updated by re-register due to delimiter typo (#3512) 2020-04-29 14:22:42 +01:00
ddb4githubandJing Chen 2dcc79763f More fixing for #2428 (#3460)
* Fixed#2428: More fixing to impl:
	- plugins.php display name: info->name(<>lower(info->name)) > ucfirst(info->name)
	- plugin_xxx->directory is always directory name on disk.

* Update CHANGELOG for PR #3460

Co-authored-by: Jing Chen <three_chenjing@sohu.com>
2020-04-16 15:16:21 -04:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 57ef005ed3 Resolving Issue #2877
Problems sending reports
2019-08-15 22:38:23 -05:00
cigamit e4b8770855 Revert "Resolving Issue #2786"
This reverts commit 02e8c75e3b.
2019-07-01 17:46:28 -05:00
cigamit 02e8c75e3b Resolving Issue #2786
A non-numeric value encountered in \lib\plugins.php on line 930
2019-07-01 17:33:46 -05:00
cigamit 492b3f8919 Resolving Issue #2744
Undefined index: password_change in auth_changepassword.php
2019-06-23 10:17:13 -05:00
Petr Macek 0710d27bc5 fix MySQL (8.0.1) reserved word function (#2736)
* fix mysql (8.0.1) reserved word function

* resolving issue #2736
2019-06-22 21:31:55 +08:00
netniV 6108e8759d Further resolve #2513 2019-03-13 16:35:57 +00:00
netniV 086b5c78df Resolving issue #2513
When a plugin INFO file is malformed or missing elements, plugin_load_info_file() should fill missing elements with defaults which are now defined as:

'name'      => directory holding info file
'requires'  => blank
'longname'  => directory holding info file (first letter is uppercased)
'status'    => 0
'version'   => 0.0
'author'    => 'Unknown'
'homepage'  => If webpage is set, use that otherwise 'Not Stated'
'directory' => directory holding info file

This will ensure consistency and that any attempts to use a key such as requires will be present.
2019-03-13 13:17:15 +00:00
cigamit 7b6e3a403e Resolving Issue #2326
Due to issues reported in the thold plugin
2019-02-09 09:32:59 -06:00
cigamit edc736d871 Additional fixes for Issue #2326
This allows the row format to be dynamic only when the
innodb_file_format is Barracuda, and corrects a bug in detecting MySQL
vs. MariaDB in the version string.
2019-01-26 09:42:37 -06:00
cigamit 683a1de0c4 Partial resolution to Issue #2326
Upgrade errors due to key length.  We will have to mandate a minimum to
implement these changes.
2019-01-26 09:01:31 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit b596e2f235 Resolving Issue #2322
Modifying relam registration files and description not supported in
plugin api
Additionally removing 'Management' from plugins since we have it removed
everywhere else.
2019-01-19 12:57:25 -06:00
cigamit 75ef8b4d5c -issue: timestamp columns with CURRENT_TIMESTAMP cant be created
Additional bracketing for readability
2019-01-18 18:03:32 -06:00
netniV 7924828016 Resolving issue #2319
Primary admin account not always given access to a plugin when that plugin is enabled as previously it was hardcoded to 'admin'
2019-01-17 18:13:46 +00:00
cigamit 0f33a46473 -issue: Plugin dependency handling inconsistent
Additionally, display of dependent plugins non conforming.
2019-01-10 06:38:35 -06:00
cigamit 7b05a6a6f3 Resolving Issue #2250
[1.2.0 Beta 4] Database creation functions do not support charset or
partial indexes
2018-12-31 12:11:19 -06:00
YongBoLiu 87ab0e8554 Fix SQL errors when default value has function. For example, should be default current_timestamp(), not default 'current_timestamp()'. (#2112) 2018-10-23 08:25:40 -04:00
Mark Brugnoli-Vinten a3ce9918a3 Latest QA fixes (#1992)
* Sort required modules for easier reading during installation

* QA fix for template package details

* Correct issue with plugin hooks SQL failing

* Rejig some the layout of Installer class and add some comments

* Some minor QA fixes

* Correct typo with com_dotnet module

* Add more information about collation change
2018-09-29 06:28:15 -05:00
cigamit e0330adfa2 Allow plugin hooks to automatically be enabled
There is a case where you need to register a new hook during an upgrade.
In this case, in the upgrade function, if the plugin is already enabled,
the new hooks will also automatically be enabled.
2018-09-26 21:11:32 -05:00
Mark Brugnoli-Vinten 39efc75c49 Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939 (#1937)
* Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939

* Update import.php
2018-09-16 13:22:32 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 67163f6303 Resolving Issue #1437
Plugin install hover message sometimes shows line breaks rather than
formatted text
2018-05-11 17:48:07 -05:00
netniV 5b69de6d3f Feature #1399: Allow 'requires' to include version against a plugin (#1436)
* feature #1399: Allow 'requires' to include version against a plugin

* Remove debug code

* Remove more debug code
2018-03-03 12:56:02 -06:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 8f6ccf4bc6 Resolving Issue #1388
Realm permissions can be duplicated due to develop branch
lib/plugins.php logic issue
2018-02-22 05:50:21 -06:00
cigamit 160a42c1e6 Resolving Issue #1384
When installing/enabling plugins, current user and admin should get
permissions
2018-02-21 18:33:13 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 99d19d5312 Correct whitespace and formatting issues
Whitespace and formatting in lib
2017-11-19 14:35:17 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
cigamit 1f23fa798a Perform optimization in both functions for PR840 2017-07-07 17:50:24 -05:00