Commit Graph
858 Commits
Author SHA1 Message Date
TheWitness abdb1cb875 Reverting previous commit 2022-11-02 08:15:25 -04:00
TheWitness afc01d89bf Attempt to correct php8.1 issues
This is due to some issues with uninitialized $level in the error handler.
2022-11-01 22:34:42 -04:00
TheWitness 490fa59620 QA: Typo in last commit 2022-10-17 20:14:44 -04:00
TheWitness d791f5fe73 QA: Add debounce function and apply
1) Page errors
2) Poller automation continuous emails when offline
2022-10-17 20:08:05 -04:00
TheWitness 65e07e4d8a Fixing #4960 - PHP8.1 deprecation warnings
2022-10-17 01:32:56 - CMDPHP PHP ERROR Backtrace: (/poller_automation.php[367]:discoverDevices(), /poller_automation.php[825]:rerunDataQueries(), /poller_automation.php[902]:run_data_query(), /lib/data_query.php[57]:get_default_contextoption(), /lib/functions.php[6016]:CactiErrorHandler())
2022-10-17 01:32:56 - ERROR PHP DEPRECATED: Automatic conversion of false to array is deprecated in file: /var/www/html/cacti/lib/functions.php on line: 6016
2022-10-17 09:04:19 -04:00
TheWitness af43a24300 QA: Handle invalid data better 2022-09-11 14:46:43 -04:00
TheWitness 2de850ee33 Fixing #4893 - Realtime sticks
in cacti 1.2.22 real time counter gets stuck and does not count down
2022-08-19 07:02:01 -04:00
TheWitness 15b096bc32 Add two new methods to #4533 Structured Paths
- In my case, I would still have too many base directories.  So, this change will add a third possible level to spread out files within the file system.
2022-08-09 18:46:16 -04:00
TheWitness 6c07b0465e Fixing #4882, #4881, #4880, #4533 - Boost and Structured Paths
This change adds two features, and corrects some minor bugs:

* issue#4880: The MySQL get_lock() function can lead to stalled boost and dsstats processes
* issue#4882: Under rare conditions the boost process can get hung until the poller times out
* feature#4533: Restructuring RRDfile paths takes too long on large systems and will stop polling for potentially several hours
* feature#4881: When boost is running, it's not clear which processes are running and how long they have to complete
2022-08-07 16:39:24 -04:00
Josh SorefandJosh Soref 12ffd6bc7b Multiple Spelling Issues in Cacti (#4792)
* spelling: about

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: accommodates

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: account

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: acquire

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: across

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: actual

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: addition

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: administrative

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: agent

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: algorithms

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: amongst

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: anchor

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: appropriate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: archive

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: arguments

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: assuming

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: asynchronously

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: attachments

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: attribute

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: availability

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: behaves

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: being

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: branch

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: calculate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: callback

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: case of

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: certainly

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: changes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: characters

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: coalition

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: column

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: configuration

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: confirm

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: connect to

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: consistently

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: containing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: convert

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: corrected

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: current

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: data

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: datasource

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: default

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: delimited

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: delimiter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: deprecated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: description

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: destination

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: determines

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: device

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: devices

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: diagnosing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dimensional

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: directory

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: disabling

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: distribution

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: documentation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dynamically

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: embedded

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: enough

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: especially

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: everything is

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: everything

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: example

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exceeds

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exclude

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: existence

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: explicitly

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exported

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extract

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: extraneous

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: failed

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fails

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fallback

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fashioned

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: field values

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: foreground

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: format

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: function

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: functions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: gauge

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: get

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: global

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: graph

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: gzipped

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: hierarchy

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: identify

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: immediately

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: increase

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: increment

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: indexes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: inefficient

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: inherited

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: initialize

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: installation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: insufficient

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: irrelevant

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: label

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: latest

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: leaves

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: local

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: location

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: lockout

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: logging

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: manually

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: menus

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: minimum

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: modifiable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: multi

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: multiple

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: mutually

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: naturally

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: navigation

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: necessary

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: network

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: number

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: occurrences

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: only

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: output

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: overridable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: overridden

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: override

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: package

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: parameters

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: perform

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: performing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: permanently

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: permission

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: piece

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: plugin

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: prevent

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: programmatically

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: propagated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: purpose

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: purposes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: push

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: queries

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: refresh

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: relevant

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: remainder

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: repetitions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: representing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: reserved

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resetting

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: response

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: responsible

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: results

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: retrieve

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: routines

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: running

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: section

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: separate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: sequences

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: session

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: settings

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: setup

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: snmp

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: some

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: specific

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: specification

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: specified

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: stacked

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: statistics

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: string

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: structure

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: structured

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: successful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: successfully

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: suggested

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: suppress

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: suppresses

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: switches

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: synchronization

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: synchronize

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: table

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: temperature

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: template

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: temporary

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: textarea

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: the

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: themselves

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: therefore

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: thoroughly

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: through

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: time

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: timed

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: timespan

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: tries

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: true

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: uninstall

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unless

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unlocks

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: up to

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: update

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: updating

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: useful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: utility

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: variable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: version

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: visibility

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: what is

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: when

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: whether

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: written

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-06-19 08:52:20 -04:00
netniV ea067041c0 When no guest template is set, login cookies are not properly set (#4814)
Closes #4814
2022-06-10 10:48:54 +00:00
TheWitness c7872ae9de More adjustments around #4736 2022-04-24 16:07:08 -04:00
TheWitness df03de26b9 Fixing #4736 - Some Timezones not set accurately 2022-04-24 14:43:51 -04:00
TheWitness a1f3a03fa8 Fix Regressions on #4723 - Index Cleanup 2022-04-24 13:47:39 -04:00
TheWitness aea5440978 Attempt to Fix #4726 - SNMP Errors
- Attempt to fix the SNMP errors reported in #4726
2022-04-19 18:01:17 -04:00
TheWitness 105a4cb47d Fixing #4705 and #4719 - Remember me and Zone Cookies
- Browsers to begin rejecting CactiTimeZone and CactiDateTime cookies due to SameSite Requirements
- Remember me not working after upgrade to 1.2.20 from 1.2.19
2022-04-14 08:24:26 -04:00
TheWitness f6306f427b Fixing Issue #4687 - Poller Output Table Not Empty
Poller output not empty all the time
2022-04-13 21:09:56 -04:00
TheWitness d28f948aef Another fix to #4618
The strpos() function will return the position of the first instance of a string which in PHP is 0.  So, you have to check for "false" insted.  Also, switching to non-case sensitive search for good measure.
2022-03-21 07:07:53 -04:00
TheWitness e22df02e3a Fixing Issue #4630 - Session restart issues
Session decode errors appearing in Cacti log periodically
2022-03-16 18:17:20 -04:00
TheWitness 91e3220fd8 Fixing Issue #4618 - Max runtime disable plugin
Plugins automatically disabled on cacti release when they exceed their maximum allowed runtime
2022-03-14 08:58:32 -04:00
Jing Chen 7d48258e1f Use OS provided DejaVu font for RHEL/CentOS/SLES/Ubuntu(PR#4594) (#4594) 2022-03-12 13:16:58 -05:00
TheWitness 3829317c8b Fixing Issue #4612 - SameSite Secure Issue
Cacti's cacti_remembers Cookie does not include the secure attribute required for Same Site support
2022-03-12 13:12:07 -05:00
TheWitness 5619a17fb9 Fixing Issue #4610 - Hide Disabled Issues
The end user setting Hide Disabled Devices does not appear to be 100% functional
2022-03-11 16:40:51 -05:00
TheWitness 96352c87bd Fixing Issue #4597 - Select Device Debug Remotes
Selective Device Debug does not work with Remote Data Collectors
2022-03-11 11:59:14 -05:00
TheWitness 6702241373 QA: One more missed DSTRACE log messages 2022-03-10 19:29:34 -05:00
TheWitness cbe82ca4b2 Fixing Issue #4602 - undefined function get_guest_account
Had to move these two functions back to lib/functions.php due to the loading order.  No way to get around it.
2022-03-10 08:30:56 -05:00
TheWitness 15fe88aacf Audit of general log finds more variables #4587
These additional variables turned up in overnight polling of the system.  Some are general, many are for polling primarily.
2022-03-02 17:22:33 -05:00
TheWitness 06a2d429d2 Fixing Issue #4593 - Auth Tokens don't use realm
Cacti 'remember-me' does not work with identical usernames from different realms
2022-03-02 17:15:55 -05:00
TheWitness 51ff282bcd Fixing More issues around #4587
Seems that the SESSION variable starts in a awkward place.  This fix has everything working again.  I can confirm now in the general log that the settings table no longer get's thrashed.
2022-03-01 13:12:18 -05:00
TheWitness 18bce0fdd7 More fine tuning to #4587
Extend change to set_config_option() no more big config array copying.
2022-03-01 09:07:22 -05:00
TheWitness 9479fb4223 More QA on #4587
Coding early in the morning is dangerous
2022-03-01 08:21:50 -05:00
TheWitness 2c04f82ab1 QA: to #4587
The array is not initialized if there is no session.  We don't care.  Initialize it as we are the first to touch it if it's not initialized.
2022-03-01 08:15:46 -05:00
TheWitness 2a0f9f0710 Minor speedup to #4587.
This change does two things.
1. Separates variable by their class: web, cli
2. Does not continuously copy the structure instead modifies in place
3. Removes some variables fixed by thold and a duplicate field
2022-03-01 07:50:54 -05:00
TheWitness 805ac5b6ec QA on #4587 - Variable does not exist 2022-02-28 21:38:31 -05:00
TheWitness 29bede5fe5 Fixing issue # 4587 - Settings performance
This change will cause a caching of items to reduce various page times.  That is the expectation
2022-02-28 21:11:19 -05:00
TheWitness e6e850d679 Fixing Issue #4572 - Basic auth issues
When basic authentication is used, the login as regular user should not be shown
2022-02-27 11:24:42 -05:00
TheWitness dfc1bf89b0 Fixing Issue #4563 - breadcrumbs
Cacti breadcrumbs are unreliable due to faulty navigation cache logic #4563
2022-02-21 19:45:19 -05:00
TheWitness ac8aff2ab9 QA: Correct Breadcrumb construction issues in themes that use them 2022-02-21 13:52:34 -05:00
TheWitness 5abde4cdf5 QA: Error Messages Cleared too Soon 2022-02-20 17:53:52 -05:00
TheWitness 3027061e40 Ensure system zone is set when calling cacti_log() from the GUI
Remove some debugging code as well
2022-02-19 11:14:17 -05:00
Browniebraun 15adc29052 fix best CF selection
#4557 - use reset to return the first element.
2022-02-18 19:04:41 +01:00
TheWitness 44bf27863b Work around stricter typing in PHP 8.1.2 when performing some date calculations 2022-02-13 10:46:23 -05:00
TheWitness f26793dbec switch to intval() over floor() for #4548 2022-02-09 10:39:24 -05:00
TheWitness 0503441ac5 Another attempt at #4548
Though the line numbers are not adding up, trying to get this resolved.
2022-02-09 08:42:41 -05:00
TheWitness 7cb3ed56b2 Fixing #4548 - PHP 8.1 Warnings
CMDPHP PHP ERROR Backtrace and other errors
2022-02-08 17:19:40 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness fa27ca53b1 Fixing Issue #4543 - Duplicate Email send fails on some systems
- Some Email systems reject sending email if emails are duplicated in a send request. Cacti should deduplicate them
- I did not fix the duplicate name issue.  We can put that into the backlog as a new issue.
- Used reset() to shortcut getting the first value
- All Emails converted to lower case regardless of RFC as there is some debate there.
2022-02-05 13:19:28 -05:00
TheWitness 4f1ea72ca8 Speedup thold check and add Device Up/Down and Recaches 2022-02-03 20:12:45 -05:00
TheWitness 2bb34e91f3 Fixing soft vs. hard tabs and adding Thold 2022-02-03 19:35:36 -05:00
Sean Mancini e2ff534c19 Add Boost and Thold to log filter (#4542)
* Add Boost and Thold to log filter

* update formatting

* fix thold log capture

* remove thold filtering
2022-02-03 19:06:13 -05:00