Commit Graph
830 Commits
Author SHA1 Message Date
TheWitness 51ff282bcd Fixing More issues around #4587
Seems that the SESSION variable starts in a awkward place.  This fix has everything working again.  I can confirm now in the general log that the settings table no longer get's thrashed.
2022-03-01 13:12:18 -05:00
TheWitness 18bce0fdd7 More fine tuning to #4587
Extend change to set_config_option() no more big config array copying.
2022-03-01 09:07:22 -05:00
TheWitness 9479fb4223 More QA on #4587
Coding early in the morning is dangerous
2022-03-01 08:21:50 -05:00
TheWitness 2c04f82ab1 QA: to #4587
The array is not initialized if there is no session.  We don't care.  Initialize it as we are the first to touch it if it's not initialized.
2022-03-01 08:15:46 -05:00
TheWitness 2a0f9f0710 Minor speedup to #4587.
This change does two things.
1. Separates variable by their class: web, cli
2. Does not continuously copy the structure instead modifies in place
3. Removes some variables fixed by thold and a duplicate field
2022-03-01 07:50:54 -05:00
TheWitness 805ac5b6ec QA on #4587 - Variable does not exist 2022-02-28 21:38:31 -05:00
TheWitness 29bede5fe5 Fixing issue # 4587 - Settings performance
This change will cause a caching of items to reduce various page times.  That is the expectation
2022-02-28 21:11:19 -05:00
TheWitness e6e850d679 Fixing Issue #4572 - Basic auth issues
When basic authentication is used, the login as regular user should not be shown
2022-02-27 11:24:42 -05:00
TheWitness dfc1bf89b0 Fixing Issue #4563 - breadcrumbs
Cacti breadcrumbs are unreliable due to faulty navigation cache logic #4563
2022-02-21 19:45:19 -05:00
TheWitness ac8aff2ab9 QA: Correct Breadcrumb construction issues in themes that use them 2022-02-21 13:52:34 -05:00
TheWitness 5abde4cdf5 QA: Error Messages Cleared too Soon 2022-02-20 17:53:52 -05:00
TheWitness 3027061e40 Ensure system zone is set when calling cacti_log() from the GUI
Remove some debugging code as well
2022-02-19 11:14:17 -05:00
Browniebraun 15adc29052 fix best CF selection
#4557 - use reset to return the first element.
2022-02-18 19:04:41 +01:00
TheWitness 44bf27863b Work around stricter typing in PHP 8.1.2 when performing some date calculations 2022-02-13 10:46:23 -05:00
TheWitness f26793dbec switch to intval() over floor() for #4548 2022-02-09 10:39:24 -05:00
TheWitness 0503441ac5 Another attempt at #4548
Though the line numbers are not adding up, trying to get this resolved.
2022-02-09 08:42:41 -05:00
TheWitness 7cb3ed56b2 Fixing #4548 - PHP 8.1 Warnings
CMDPHP PHP ERROR Backtrace and other errors
2022-02-08 17:19:40 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness fa27ca53b1 Fixing Issue #4543 - Duplicate Email send fails on some systems
- Some Email systems reject sending email if emails are duplicated in a send request. Cacti should deduplicate them
- I did not fix the duplicate name issue.  We can put that into the backlog as a new issue.
- Used reset() to shortcut getting the first value
- All Emails converted to lower case regardless of RFC as there is some debate there.
2022-02-05 13:19:28 -05:00
TheWitness 4f1ea72ca8 Speedup thold check and add Device Up/Down and Recaches 2022-02-03 20:12:45 -05:00
TheWitness 2bb34e91f3 Fixing soft vs. hard tabs and adding Thold 2022-02-03 19:35:36 -05:00
Sean Mancini e2ff534c19 Add Boost and Thold to log filter (#4542)
* Add Boost and Thold to log filter

* update formatting

* fix thold log capture

* remove thold filtering
2022-02-03 19:06:13 -05:00
TheWitness b519f56226 feature: Create more filters for the Clog Message Type
This minor enhancement made it easier to debug problems in a system with many 10's of thousands of log rows.
2022-02-03 09:33:06 -05:00
TheWitness d809a368d7 Adding three minor features associated with user management
* Allow the get_template_account() function to be hookable by third party plugin
* Allow The User Management interface to be filterable by Realm
* Prevent Template User Accounts from being Removed
* Move the get_guest_account() and get_template_account() functions into lib/auth.php
2022-01-30 11:57:18 -05:00
TheWitness fddfa631f5 Fixing Issue #4529 - Admin Notification Broken
Primary Admin account notifications not working in some cases
2022-01-29 15:19:59 -05:00
TheWitness 11e0efc564 Fixing #4502
Had the wrong value passed to this function.
2021-12-23 09:20:17 -05:00
TheWitness 86e0bcef80 Fixing Issue #4475
Running cacti with PHP8.1 shows lots of warnings in the log
2021-11-30 17:46:54 -05:00
netniV ccdfe6ac3b Fixing dsv_log usage (#4462) 2021-11-14 16:05:16 +00:00
netniV 18bee3d4ca Titles may show "Missing Datasource" incorectly (#4457)
Closes #4457
2021-11-14 12:50:09 +00:00
netniV fe494457f0 Add some more DSV logging 2021-11-01 18:42:55 +00:00
TheWitness b0f28ba4d3 Related to #4439 - Ensure the Zone name is known to PHP 2021-10-25 15:10:18 -04:00
TheWitness 738d3731ca Fixing #4439 New Timezone API's
New Browser Breaks Plugins that depend on non UTC date time data
2021-10-22 11:44:15 -04:00
TheWitness 7c89b2a3c3 Check all pages catches it's first victim 2021-10-10 19:56:16 -04:00
TheWitness 90f7fc8fbe Add additional prepared statement 2021-10-10 13:40:21 -04:00
TheWitness 5a1de9efdf Fixing Issue #4409 - Test Data Sources Optional
* When creating a Graph, make testing the Data Sources optional by Template
* Release preparation steps
2021-09-25 14:13:40 -04:00
netniV 9a45ef5b0d Potential fix for grave/backtick XSS usage (#4356) 2021-09-25 10:16:06 +00:00
TheWitness 110ddb8647 More robust resolution to #4403
This solution should address all the current oddball timezones.
2021-09-19 16:00:20 -04:00
TheWitness 11f23ccbde Minor logging updates 2021-09-15 08:10:51 -04:00
TheWitness 9355593845 Turn on Data Source Validation function when Data Source Trace is enabled
Also getting some of the comments in proper phpDocumentation style.  I feel I've been here before.
2021-07-01 13:02:09 -04:00
netniV c414764767 Restore DSV_LOG, remove random prints, fix script output 2021-06-27 19:11:04 +00:00
TheWitness b05b547c51 Fixing Issue #4273 - Device CLI generating errors
There were multiple fixes to this file, but this corrects issues with the Script Server script testing.
2021-06-25 17:25:02 -04:00
netniV 43cc617d02 Fix up for #4309, following on from #4250 2021-06-17 23:06:21 +00:00
netniV 8f6637c292 Remove erroroneous trace logging 2021-06-14 14:14:19 +00:00
netniV c5c088d2d1 Further fix of test_data_source() [#4250] 2021-06-11 20:05:00 +00:00
netniV 5a2d51c02f Further fix of test_data_source() [#4250] 2021-06-09 14:00:59 +00:00
netniV 9c5720137b Unable to create graphs due to Data Source verification failure (#4250)
Closes #4250
2021-06-05 20:32:01 +00:00
TheWitness b1686206a3 Correct two minor issues, one unchecked variable and one with a forced zone issue 2021-04-21 19:21:56 -04:00
TheWitness 6bbcb538a6 More fixes around issue #645 - Test Data Source
This change allows for testing of data source from the Graphs New page to reduce the likelihood of graphs being created that will never be rendered
2021-04-02 18:36:16 -04:00
TheWitness 65d77ac9e2 Minor fix related to issue #4182
SNMP Query based graphs should render now.
2021-03-29 21:36:35 -04:00
TheWitness 0dc4a93cca Update around issues #645 and #4182 2021-03-25 17:45:43 -04:00