Commit Graph
176 Commits
Author SHA1 Message Date
Mark Brugnoli-Vinten ed57331dfd Fixes for Issue 1729 and 1730 (#1747)
* Fixes QA issues with upgrades from older versions

* Redirect install/index.php to install/install.php

* Further QA fixes

* Ensure upgrade matches new password field length

* Add 'Installation In Progress' message

* Fix QA issues
2018-07-25 08:45:41 -04:00
cigamit 179cd07b73 Resolving Issue #1711
Support specifying MySQL SSL file paths in the database API
2018-07-14 14:53:46 -05:00
cigamit 4c9d109f06 Add transaction support to database library 2018-05-10 07:28:10 -05:00
Jimmy Conner 8f4d2cfc78 Fix for PR #1587 2018-04-30 17:52:54 -05:00
Francisco Javier 6abe0913f5 Fix open database when in home directory there is file or directory named localhost (#1587)
Nice tweak!
2018-04-28 10:36:30 -05:00
cigamit dfca74f360 Final fix for issue #1467
This setting forces the database connection to use the same timezone
specified in the poller table for remote data collectors therefore
allowing the data collectors to be in their own timezones and not all
UTC.

Add one slight wording change for the data collector name.
2018-04-22 08:07:32 -05:00
cigamit 901537e1b6 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	lib/ldap.php
2018-03-03 13:10:27 -06:00
netniV 3433f26ad6 Feature #1408 - Update SQL / Backtrace to use new clean_up_lines() function (#1435) 2018-03-03 08:26:46 -06:00
netniV 4834d55983 issue #1421: When SQL had all bad modes, missing variable warning was generated (#1425)
* issue #1421: When SQL had all bad modes, missing variable warning was generated

* Update database.php
2018-03-02 06:41:09 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 99d19d5312 Correct whitespace and formatting issues
Whitespace and formatting in lib
2017-11-19 14:35:17 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
cigamit f97dd82a48 Resolving Issue #964
Bad SQL modes not being replaced as expected
Emergency fix.
2017-09-11 16:18:10 -05:00
cigamit 8173ec8b1b Resolving database corruption issue due to MariaDB/MySQL sql_mode
This change also will speed up initial login under certain
circumstances.
2017-09-08 18:35:19 -05:00
cigamit fb0274f09e Resolving Issue #891
lib/database.php unable to connecto to MySQL when using port different
than 3306
2017-08-05 10:50:18 -05:00
cigamit 678716ae35 Optimize lib/database.php for readability 2017-05-15 17:56:18 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit e1f010f241 Resolving Issue #622
Can not connec to MySQL over a socket
2017-04-26 06:03:07 -05:00
Patrick 97b666f724 Update database.php
Restoring db_add_index()
2017-04-22 15:16:36 +02:00
Patrick aea4b7c40b Database optimisations
- Removed unused functions
- Double check of !is_object() optimised
- Resolved some alignment issues
2017-04-16 11:51:51 +02:00
patrick 467ab201aa executing 4x1 str_replace() instead of 4x3 2017-04-06 18:05:33 +02:00
cigamit 8c2150c7aa Log full database errors in LOW or higher logging mode
Makes debugging easier
2017-02-18 13:20:21 -06:00
cigamit 06de177235 Add DB Query count for debugging purposes 2017-02-05 13:04:04 -06:00
cigamit 485a3b3be8 Make the db_add_index safer from reserved words 2017-02-04 14:02:02 -06:00
cigamit 3ab2feaedf add db_add_index() function to core
Was included in the installer, but not in the core api.
2017-02-04 13:55:56 -06:00
cigamit e4c27e4555 Another check to prevent invalid date format errors
This is related to Issue #227
2017-01-23 17:10:59 -06:00
cigamit 2376e9d48b Remove STRICT mode 2017-01-22 17:14:45 -06:00
cigamit 8e239faa74 Add comment field to db functions 2017-01-14 00:07:21 -06:00
cigamit 636e68a336 Ensure we are doing a proper comparison for columns 2017-01-11 21:58:04 -06:00
cigamit c25065ede7 Fix two database issues
The issue with the CURRENT_TIMESTAMP being applied to the various
columns does not make sense.  In the code the $column['default'] == 0 is
also equating to 'CURRENT_TIMESTAMP'
2017-01-11 19:52:07 -06:00
cigamit c59c2f9443 Resolving issues #149 2017-01-05 17:27:45 -06:00
cigamit 790f6a2199 Fix undefined variable error in cacti_log() 2017-01-02 13:12:08 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit e9a8a5b555 Fixing database.php db_add_column to handle CURRENT_TIMESTAMP 2016-12-29 14:58:01 -06:00
cigamit 762e1ffd96 Add 'on_update' to rest of DB functions 2016-12-28 23:06:54 -06:00
cigamit 41dda1654c Add new option 'on_update' to db_add_column
This fixes 'duplicate column' errors when upgrading
2016-12-28 22:24:38 -06:00
cigamit 473aa93c5e Correct issues with remote connections.
This is part of remote poller install testing.  Finding a few
regressions.
2016-12-26 22:27:28 -06:00
cigamit 0054f1d7e9 Correct logic when openning connection to 2nd DB
Since we aren't passing a connection id (and its not even saved to the
db session yet), we need to utilize the PDO functions directly instead
of db_execute, otherwise these commands just get ran on the default
connection again, not the new one.
2016-10-26 00:27:13 -05:00
cigamit 2e7d0df40f more logging and remove removed mysql_error() call 2016-09-21 09:44:27 -05:00
cigamit 4a53491b6b taking a more conservative approach until we can do a full check on the code 2016-09-20 19:52:20 -05:00
cigamit 8b770c8337 another change to database.php to account for auto_increment integers 2016-09-20 17:19:04 -05:00
cigamit 6a2d6c7429 more precise handling of integers 2016-09-19 16:37:33 -05:00
cigamit e1b06a5c9a partial resolution of bug#1042
this change will allow logging by file.  it's not quite by device and
plugin, but it is a start.
2016-09-16 22:03:36 -05:00
cigamit 71483fb020 adding one more mode to exception list 2016-09-05 09:10:31 -05:00
cigamit 9561b97528 disable magic_quotes_gpc forced emulation
this is a significant change that may impact plugins.  please report
bugs if you find tham.
2016-08-28 15:28:42 -05:00
cigamit 97880fce15 Installer cleanup
Remove need to specify the Cacti Version on every function call
Add new functions for adding / dropping columns
Add new functions for renaming / dropping tables
Lots of error checking (stops most SQL errors when re-upgrading)
General Cleanup
2016-08-22 16:48:34 -05:00
cigamit ef6c9ec217 additional mysql 5.7 compatibility 2016-07-11 19:23:56 -05:00
cigamit 00f0d0af45 Truncate SQL Error message for "Got a packet bigger than 'max_allowed_packet' bytes"
This is stop the error log from skyrocketing in size because of the
resource cache
2016-06-26 23:22:44 -05:00