Commit Graph
609 Commits
Author SHA1 Message Date
cigamit 9a5cf5ae54 Inform the primary Cacti administrator of problems by Email 2018-07-27 17:31:22 -05:00
Mark Brugnoli-Vinten 33aa71448e Feature 1734 - Visual enhancements to RRD error message when file not found (#1755)
* Remove unnecessary issues

* Feature #1734 - Visual enhancements to RRD error message when file not found

This commit adds a visual enhancement to the RRDTool's file not found error.

* Further improvements
2018-07-26 21:32:54 -04:00
Mark Brugnoli-Vinten ef7a318ef1 Feature #1692 - Separate option for logging Input Validation issues (#1696)
* Feature #1692 - Separate option for logging Input Validation issues

This commit adds a separate option for feature #1692 to enable logging Input Validation issues even when developer mode is turned off

* Finalise renaming of developer_mode to log_validation for cleaner understanding

* Remove log_validation from legacy location
2018-07-21 11:44:06 -04:00
Mark Brugnoli-Vinten 6bb5b36b64 PR for Issue #1716 and #1718 (#1720)
* Fixes for issues #1716 and #1718

* Add changelog details

* issue#1721 - Console Side Bar not correct on first login
2018-07-19 06:54:33 -04:00
Mark Brugnoli-Vinten cab3863f2b PR for issues #1282 and #1700 (#1701)
* PR for issues Â#1282 and #1700

This pull request adds additional functionality for #1282 allowing network discovery to email upon completion and also corrects issues found during #1700 with unauthenticated mail causing errors to appear.

* Fix settings QA issue
2018-07-14 10:49:15 -05:00
Mark Brugnoli-Vinten d3ee9512bf Fix for issue #1298 (#1702)
* Fix for issue #1298

* Minor QA fix
2018-07-11 04:39:09 -05:00
cigamit 5a1ba8c3fe Resolving Issue #1614
Graph management not display graph names
2018-06-02 12:30:30 -05:00
cigamit bb25cba41d Properly set graph top tab and right tabs when present 2018-06-02 12:11:16 -05:00
cigamit 07544275a3 Another MySQL 8.x Reserved word related to #1655
The word 'path' appears to be moving into the reserved domain as well.
Related to issue #1655
2018-06-02 09:07:15 -05:00
cigamit 6fd2cc9ee2 Improve handling of CSRF timeouts
Now page will automatically refresh.
2018-05-14 18:26:18 -05:00
Mark Brugnoli-Vinten 5d075f62fc Feature #1034: Ensure tables are UTF8 (#1635)
* Feature #1034: Ensure tables are UTF8

* Make PHP 5.4 happy
2018-05-12 15:35:50 -05:00
cigamit de9fc0b72a Make all user settings dynamic and allow resetting to default.
This is a partial revert of feature #1400.  It removes the 'Save' button
and makes all settings default.  It will not allow setting anything that
is not defined in the user setting array as well.
2018-05-06 12:56:16 -05:00
Mark Brugnoli-Vinten c70642b93f feature #1400: User settings should have checkbox to enable overriding of default settings (#1577)
* feature #1400: User settings should have checkbox to enable overriding of global settings

* Fix for enable/disable styles

* QA fix for settings not being cleared

* QA fix to prevent double saving
2018-04-29 10:08:46 -05:00
Mark Brugnoli-Vinten ddddaec6ae Ajax Installer (#1586)
* Beginning of Install via AJAX calls

* Added steps 3 & 4 to the installer system

* Add background update procedure.  Still needs more upgrade code adding, like upgrading the DB

* Minor fixup during QA

* Remove debug code from lib/functions.php

* More QA fixes, add slight delay to index.php initialisation to see javascript warning (should be removed)

* beta3 - added data source profiles

* beta4 - fix some issues found in QA

* beta5 - upgrade databsae routines added, error results screen styled

* Add some colour to the thumb icons

* QA fix to remove unneeded option

* Fix for PHP 5.4 travis failure
2018-04-29 10:05:32 -05:00
cigamit ec5608e20e Resolve Issue #1560
Warning that escapeshellarg() is escaping a null
2018-04-21 18:31:40 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
linusat 7075067914 Resolving Issue #1213 (#1481)
Fix inadvertent removal of this minor fix.
2018-03-21 17:25:53 -05:00
cigamit ddaec1c5ac Additional XSS protection related to #1457 2018-03-17 08:04:30 -05:00
cigamit e7c7dbe3a1 Resolving Issue #1453
Title of add_graphs.php being ignored
2018-03-08 12:58:53 -06:00
cigamit b1894a6638 Revert "Resolving Issue #1453"
This reverts commit e584222b9e.
2018-03-08 12:56:42 -06:00
cigamit e584222b9e Resolving Issue #1453
Title of add_graphs.php being ignored
2018-03-08 12:55:44 -06:00
cigamit d76f925383 Resolving Issue #1457
Path-Based Cross-Site Scripting (XSS) issues
2018-03-08 11:49:17 -06:00
netniV 16aaa1cc8d Feature #1395: Ensure messages have each new line keep the same prefix in cacti_log() (#1439)
* feature #1395: Ensure messages have each new line keep the same prefix in cacti_log()

* Change multi-line output to use clean_up_lines to create a single line
2018-03-07 06:04:11 -06:00
netniV 1f5c7e232d Correct issue where filtering no longer filters after #1419 (#1450) 2018-03-07 06:03:42 -06:00
netniV a47b297f30 issue #1371: Further fix for #1371 due to incorrect sign usage (#1445) 2018-03-05 18:10:14 -06:00
cigamit a36eaf7e3b Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-03-04 14:24:35 -06:00
cigamit 6ca405470e Resolving Issue #1419
CLog: preg_match can blow up log file
2018-03-04 10:04:31 -06:00
netniV 3433f26ad6 Feature #1408 - Update SQL / Backtrace to use new clean_up_lines() function (#1435) 2018-03-03 08:26:46 -06:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 8b5d789213 Resolve issues with messaging
- Discovered in QA
- Secpass password verification does not return meaningful error
messages
- Missing some i18n in login verification process
- Return missing function
- Correct customer error message instances to new display output
- Minor audit of functions for readability
2018-02-24 23:25:57 -06:00
cigamit 253ebe9ce4 Second pass is a charm 2018-02-19 19:39:30 -06:00
cigamit 74ac427752 QA on logging functions due to backtraces 2018-02-19 19:33:58 -06:00
netniV 3bacbd485d issue: Allow dynamic setting of from name when emailing (#1371) 2018-02-19 17:25:44 -06:00
cigamit 366f136ee8 Correcting multiple issues with filters, settings and page refresh
Per the CHANGELOG:
-issue: Allow multiple errors to be returned from save operations
-issue: Optimize filter visibility functions and make html consistent
-issue: Allow error fields to be highlighted on the settings page
-issue: Some error fields not showing when saving under Settings > Paths
-issue: When refreshing some pages using F5, header would be removed
2018-02-19 17:23:14 -06:00
cigamit 7e70e27940 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	include/themes/modern/main.css
#	tree.php
2018-02-18 16:26:26 -06:00
cigamit 7343c8e4c1 Resolve Issue #1366
Improve error/info message display
2018-02-18 14:20:50 -06:00
cigamit 2f7f40fb42 Resolving Issue #1340 and Two Additional
Unable to open Time Graph View in new tab
Disable graph context menu items that have no right context
Resolve JavaScript errors when coming out of Realtime
2018-02-17 09:52:17 -06:00
Patrick 3f6d121a4c Translations (#1335)
* Updates Dutch translations with latest cacti.pot file

* Fixed some language string inconsistencies

* Fixed typo in mailer logregistry

* Updated Dutch translations

* Updated changelog

* Fixed some language string inconsistencies

* Updated Dutch translations
2018-02-13 00:31:42 -07:00
cigamit 3de172f337 Resolving Issue #564
Can't move items in graph template as desired
2018-02-09 21:10:02 -06:00
cigamit 5db506d649 Resolving Issue #564
Can't move items in graph template as desired
2018-02-09 21:04:12 -06:00
cigamit ca1a3c4159 Resolving Issue #1319
FrontEnd + Remote Poller - Connection timeout issue
2018-02-08 18:51:57 -06:00
cigamit 3a13f1c7a8 Resolving Issue #1319
FrontEnd + Remote Poller - Connection timeout issue
2018-02-08 06:59:33 -06:00
cigamit b25896415a Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-02-06 08:08:43 -06:00
cigamit d3536ed321 Consolidation for Issue #1305
Code reduction by making all the header into a function.
2018-02-04 22:01:16 -06:00
cigamit 4ca8f1d441 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	lib/functions.php
#	lib/html_validate.php
2018-02-04 13:19:43 -06:00
netniV b6e18d8250 Fix for issue #1292: browser caching of javascript and css files (#1305)
* issue #1292: Fix issues with browser caching of javascript and css files

* Removing unnecessary variable set.

* Minor changes to format and syntax

Use return and not echo, minor spacing changes.
2018-02-04 11:44:45 -07:00
netniV 46e8a7643a issue #1296: CactiErrorHandler now ignores suppressed errors (#1297) 2018-02-04 08:48:49 -07:00
cigamit 7b60a000a8 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	lib/api_automation.php
2018-02-03 13:36:09 -06:00
netniV 27e858e089 issue#1040: Correct sizeof() issues with get_data_query_array() and get_graph_group() results (#1299) 2018-02-03 06:59:20 -07:00
netniV abd42b042a feature: Links and names for Poller, Data Query and Data Sources (#1294)
* feature: Links and names for Poller, Data Query and Data Sources now show in clog

* - Defaults return value to full match so that a value is always return
- Made regex parsing more efficient using a single regex string rather than multiple parses of different regex over same string
- Updated get_data_source_titles to handle issues when datasource id is completely missing
- Updated regex functions so that a static array of regex/functions to be called is built.
- Commented function call for api_plugin from clog_regex_array() as needs more code to handle loading of plugins functions

* Updated with CLog changes

* Further documentation update

* Update clog_webapi.php

* Making some style changes here prior to merge.
2018-02-03 06:55:51 -07:00